Installing works on GitHub Enterprise - almost

[release-drafter]

Installing works on GitHub Enterprise - almost

[toolmantim]

Sorry you’re having trouble there!

I believe Smee should only be used for development, you’ll be wanting to point the GitHub App webhook settings directly to where you’re hosting the Probot app I believe?

[jonbrohauge]

@toolmantim Thanks for the clarification. Now to figure out how to host Probot app on-prem... Any ideas?

[toolmantim]

probot/probot#500 (comment) Seems to be the best advice.

[jonbrohauge]

Got the app working inside a docker container.

I have updated the Webhook URL to point to my app. Doing a PR in my repo, sends a json-payload to the app, and the app basically returns "OK" in the body. And nothing further happens.

What is expected as a response for the app to do stuff?
I'm trying to figure out what goes wrong where, but I'm currently stuck at everything looks green, but it does not do anything.

[toolmantim]

The Docker container log should contain a bunch of debug output that's run when the webhook is processed. Can you check that?

[jonbrohauge]

This is the output of the docker logs.
https://gist.github.com/jonbrohauge/d68af675b54e853618fab6cb66cc92ac

[jonbrohauge]

Hmmm... Tried again without any changes, and I get this:

2:38:17.472Z ERROR probot: Integration not found
  HttpError: Integration not found

https://gist.github.com/jonbrohauge/f1fc271ddaf57fa91d89bc5ff6783943

[toolmantim]

Have you created a new "app" in your GitHub Enterprise for Release Drafter, and installed it on the repos?

[jonbrohauge]

I cloned your project.
Configured the .env to use GHE_HOST.
Added corporate proxy.
Got the app up and running on my dev machine, and had smee.io configured, as per original input in this issue.

--> Installed the app into my GHE at this point

I took the values in the updated .env file, and loaded them into a Dockerfile.
Got the build using the Dockerfile, and spun up a container running the app.

[jonbrohauge]

I must admit that I'm not experienced with npm-stuff, and fighting a corporate proxy, thus having to host the app "in-house" is not doing me any kindness.

[jonbrohauge]

Restarted from scratch.

Got way more action in the log-file now. Now I see an error, that I could not earlier:

11:55:42.598Z DEBUG github: GitHub request: POST /graphql - 200 OK (installation=6)
  params: {
    "baseUrl": "https://github.domain.local/api",
    "mediaType": {
      "format": "",
      "previews": []
    },
    "request": {},
    "query": "\n  query findCommitsWithAssociatedPullRequests(\n    $name: String!\n    $owner: String!\n    $branch: String!\n    $since: GitTimestamp\n    $after: String\n  ) {\n    repository(name: $name, owner: $owner) {\n      ref(qualifiedName: $branch) {\n        target {\n          ... on Commit {\n            history(first: 100, since: $since, after: $after) {\n              totalCount\n              pageInfo {\n                hasNextPage\n                endCursor\n              }\n              nodes {\n                id\n                message\n                author {\n                  name\n                  user {\n                    login\n                  }\n                }\n                associatedPullRequests(first: 5) {\n                  nodes {\n                    title\n                    number\n                    author {\n                      login\n                    }\n                    mergedAt\n                    isCrossRepository\n                    labels(first: 10) {\n                      nodes {\n                        name\n                      }\n                    }\n                  }\n                }\n              }\n            }\n          }\n        }\n      }\n    }\n  }\n",
    "variables": {
      "name": "probot-test-repo1",
      "owner": "probot-testing",
      "branch": "master"
    }
  }
11:55:42.599Z ERROR event: Field 'associatedPullRequests' doesn't exist on type 'Commit' (id=6ef50462-9d89-11e9-94e3-622e07411d0c)
  GraphqlError: Field 'associatedPullRequests' doesn't exist on type 'Commit'
      at request.then.response (/app/node_modules/@octokit/graphql/lib/graphql.js:31:15)
      at Object.dynatraceOnServiceExecutionIndicator (/opt/dynatrace/oneagent/agent/res/nodeagent/nodejsagent.js:1650:20)
      at Object.c.safeInvoke (/opt/dynatrace/oneagent/agent/res/nodeagent/nodejsagent.js:1701:29)
      at /opt/dynatrace/oneagent/agent/res/nodeagent/nodejsagent.js:6844:25
  --
  event: {
    "event": "push",
    "id": "6ef50462-9d89-11e9-94e3-622e07411d0c",
    "installation": 6,
    "repository": "probot-testing/probot-test-repo1"
  }
11:55:42.600Z ERROR probot: Field 'associatedPullRequests' doesn't exist on type 'Commit'
  GraphqlError: Field 'associatedPullRequests' doesn't exist on type 'Commit'
      at request.then.response (/app/node_modules/@octokit/graphql/lib/graphql.js:31:15)
      at Object.dynatraceOnServiceExecutionIndicator (/opt/dynatrace/oneagent/agent/res/nodeagent/nodejsagent.js:1650:20)
      at Object.c.safeInvoke (/opt/dynatrace/oneagent/agent/res/nodeagent/nodejsagent.js:1701:29)
      at /opt/dynatrace/oneagent/agent/res/nodeagent/nodejsagent.js:6844:25
11:55:42.601Z  INFO http: POST / 500 - 559.85 ms (id=6ef50462-9d89-11e9-94e3-622e07411d0c)
11:55:42.601Z TRACE http:  (id=6ef50462-9d89-11e9-94e3-622e07411d0c, res.duration=559.85)
  HTTP/1.1 500 Internal Server Error
  x-powered-by: Express
  x-request-id: 6ef50462-9d89-11e9-94e3-622e07411d0c
  set-cookie: dtCookie=4$61B4404D070E54FCBB7D56544A70C857; Path=/; Domain=.domain.local

What am I missing?
BTW. we have DynaTrace OneAgent installed on our hosts to monitor our Docker containers.

[jetersen]

Ask GitHub to update their enterprise edition 😆
#234 (comment)

[jonbrohauge]

@Casz nicely spotted. Good thing I'm the GHE admin 😁
Upgrade is on for tonight. Will comment if version 2.17.x is good enough

[jonbrohauge]

Upgrading to GitHub Enterprise 2.17.4 makes magic happen.

[toolmantim]

Woohoo @jonbrohauge! 🎉🎉🎉

[hmp3094]

@jonbrohauge I am sorry to comment on this old issue but couldn't find anything relevant elsewhere. I wanted to know how did you configure the release-drafter on GHE. I have the app running on an internal server and pointed the app to it. We don't have GitHub actions enabled on our instance yet and I am not really sure if it is a hard requirement.

[jonbrohauge]

@hmp3094
We have moved on to enable GitHub Actions on our GHES. Due to the fact that it was a hit-n-miss operation to get Release Drafter to work properly as an installed application. My advise is it enable GitHub Actions. There is a good UI to control in which repositories are allowed to use Actions, and you can allow for only specific actions to run if you are worried about your users doing weird stuff. The docs have an excellent explainer in how to run on your GHES.