renestein / rstein.asynccpp Goto Github PK

The RStein.AsyncCpp library is a set of types that should be familiar for anyone who knows the Task Parallel Library (TPL) for .NET (C#).

License: MIT License

C++ 98.62% Batchfile 1.38%

coroutine task-parallel-library coroutines async await concurrency functional-task taskcompletionsource task hot-tasks

rstein.asynccpp's People

Contributors

Stargazers

Watchers

Forkers

blockspacer linecode mediabuff ajunlonglive

rstein.asynccpp's Issues

Can't co_await a std::shared_future in a c++/winrt UWP app (doesn't compile)

Do you have any idea why this is? I have set the c++ version to latest and added /await compiler flag.
I am able to co_await a std::future, so I am probably able to use a lot of Rstein.AsyncCpp already.

This doesn't compile:

Windows::Foundation::IAsyncAction MainPage::ClickHandler(IInspectable const&, RoutedEventArgs const&)
{
    std::promise<void> promise;
    promise.set_value();
    std::shared_future<void>  _completedFuture = promise.get_future().share();
    co_await _completedFuture;
}

I get:
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\future(1034,1): error C3312: no callable 'await_resume' function found for type 'std::shared_future'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\future(1034,1): error C3312: no callable 'await_ready' function found for type 'std::shared_future'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\future(1034,1): error C3312: no callable 'await_suspend' function found for type 'std::shared_future'

So this isn't compiling:

  auto transform1 = DataFlowAsyncFactory::CreateTransformBlock<int, string>([](const int& item)-> Tasks::Task<string>
                                                      {
                                                        auto message = "int: " + to_string(item) + "\n";
                                                        cout << message;
                                                        //await async operation returning standard shared_future.
                                                        co_await GetCompletedSharedFuture();
                                                        co_return to_string(item);
                                                      });

Support BufferBlock in DataFlow?

Will you implement BufferBlock counterpart in DataFlow here? I think it's a useful feature to work together with coroutine.

`dynamic atexit destructor for 'threadPool'

I'm getting a weird exception / crash at end of runtime.

This console program produces it:

#include <RStein.AsyncCpp/Tasks/TaskCompletionSource.h>

int main()
{
		RStein::AsyncCpp::Tasks::TaskCompletionSource<__int64> _tCS;
}

I had never heard of atexit() before this, and it was quite confusing. Should I ignore this crashing? Is there a work-around?

Here is the call stack for the above:

>	[Inline Frame] FolderOpenerTestConsole.exe!std::thread::{dtor}() Line 95	C++
 	[Inline Frame] FolderOpenerTestConsole.exe!std::destroy_at(std::thread * const) Line 325	C++
 	[Inline Frame] FolderOpenerTestConsole.exe!std::_Default_allocator_traits<std::allocator<std::thread>>::destroy(std::allocator<std::thread> &) Line 721	C++
 	[Inline Frame] FolderOpenerTestConsole.exe!std::_Destroy_range(std::thread * _First, std::thread * const) Line 950	C++
 	[Inline Frame] FolderOpenerTestConsole.exe!std::vector<std::thread,std::allocator<std::thread>>::_Destroy(std::thread * _First, std::thread * _Last) Line 1680	C++
 	[Inline Frame] FolderOpenerTestConsole.exe!std::vector<std::thread,std::allocator<std::thread>>::_Tidy() Line 1764	C++
 	FolderOpenerTestConsole.exe!std::vector<std::thread,std::allocator<std::thread>>::~vector<std::thread,std::allocator<std::thread>>() Line 712	C++
 	[Inline Frame] FolderOpenerTestConsole.exe!RStein::AsyncCpp::Schedulers::SimpleThreadPool::{dtor}() Line 35	C++
 	FolderOpenerTestConsole.exe!`RStein::AsyncCpp::Schedulers::Scheduler::initDefaultScheduler'::`2'::`dynamic atexit destructor for 'threadPool''()	C++
 	ucrtbase.dll!00007ffb4f4cbea0()	Unknown
 	ucrtbase.dll!00007ffb4f4cbdb7()	Unknown
 	ucrtbase.dll!00007ffb4f4cbd6d()	Unknown
 	ucrtbase.dll!00007ffb4f4ca17a()	Unknown
 	ucrtbase.dll!00007ffb4f4ca10f()	Unknown
 	ucrtbase.dll!00007ffb4f4ca0af()	Unknown
 	FolderOpenerTestConsole.exe!__scrt_common_main_seh() Line 295	C++
 	kernel32.dll!00007ffb4f5e54e0()	Unknown
 	ntdll.dll!00007ffb5174485b()	Unknown

CP.51: Do not use capturing lambdas that are coroutines

CP.51: Do not use capturing lambdas that are coroutines
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cp51-do-not-use-capturing-lambdas-that-are-coroutines

Dealing with types without default constructors

I am trying to deal with winrt::Windows::Storage::StorageFile objects from c++/winrt . I can just wrap this type, but is there anything else I can do? Is there any hope that default constructors won't be a requirement in the future?

Doesn't compile; "no appropriate default constructor available":

        auto  m_folderActionBlock = 
         DataFlowAsyncFactory::CreateActionBlock<winrt::Windows::Storage::StorageFolder>([](const Windows::Storage::StorageFolder& item)-> Tasks::Task<void>
            {
                // auto message = "Final action: " + item + "\n";
                // cout << message;
                // await async operation returning Task.
                co_await Tasks::GetCompletedTask();
                //_processedItems.push_back(item);
            });

_state = Tasks::TaskState::RunToCompletion;

I have been trying to trace the cause of some intermittent non-completion of tasks.

CP.53: Parameters to coroutines should not be passed by reference

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cp53-parameters-to-coroutines-should-not-be-passed-by-reference

Fix build on Azure pipelines

Temporarily disable CLANG builds
Fix reference to gtest