repodio/react-native-scrubber

A video/audio scrubber for react native.

react-native-scrubber's Issues

What is the LICENSE for this repo?

Please add a LICENSE file so I know whether it can be used in commercial projects. For instance MIT is a popular permissive license. Here's an example: https://github.com/nick-michael/react-scrubber/blob/master/LICENSE

onSlidingStart only starting if onSlide is defined

An onSlidingStart function supplied as a prop is only called, if the onSlide prop is also present.

As a substitute I was able to supply an empty function for onSlide, and onSlidingStart is executed as it should.

Warning "Animated: `useNativeDriver` was not specified" when interacting

When interacting with the scrubber, the Animated library in react-native will throw a warning:

Animated: useNativeDriver was not specified. This is a required option and must be explicitly set to true or false

Although not stated in the documentation of Animated, apparently the config of Animated.timing is also required to specify a value for useNativeDriver.

Found in version [email protected].

tapNavigation isn't working on IOS device

Hi,
tapNavigation feature seems not working on IOS. The event from TapGestureHandler component doesn't fire, maybe due to elements which override the background track.

After making some tests, wrapping TapGestureHandler around trackContainer View seems to fix the issue. We can nest multiple gesture handler so it'll not affect the PanGestureHandler one. Like this:

<TapGestureHandler
    onHandlerStateChange={this.onTap}
    maxDurationMs={2000}
    hitSlop={{ top: 20, bottom: 20, left: 0, right: 0 }}
    >
        <View style={styles.trackContainer} onLayout={this.onLayoutContainer}>

What do you think ?

HitSlop for bottom for draggable scrubber is not working

Description

When trying to drag the scrubber, the hit area isn't working for bottom, possibly due to the values container below. Here's a video:

scrubber have some leg after in slide complete

After onSlideComplete i see the scrubber for short time on the position before i started the slide.
it took me long time to find workaround but it still happens sometimes.
I used url and not local file.

Add tap to navigate support?

Users might want to tap on a location to navigate there. Most media controls support this feature. Any plan to add this?

I'd like to implement this and make a PR, how should we do this? I'm thinking of using TouchableWithoutFeedback with an onPress handler for track container.