Giter Site home page Giter Site logo

react-native-scrubber's People

Contributors

3djakob avatar bakkerjoeri avatar capitanredbeard avatar dependabot[bot] avatar patrickjames242 avatar shahzaibmuneeb avatar sjsakib avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

react-native-scrubber's Issues

tapNavigation isn't working on IOS device

Hi,
tapNavigation feature seems not working on IOS. The event from TapGestureHandler component doesn't fire, maybe due to elements which override the background track.

After making some tests, wrapping TapGestureHandler around trackContainer View seems to fix the issue. We can nest multiple gesture handler so it'll not affect the PanGestureHandler one. Like this:

<TapGestureHandler
    onHandlerStateChange={this.onTap}
    maxDurationMs={2000}
    hitSlop={{ top: 20, bottom: 20, left: 0, right: 0 }}
    >
        <View style={styles.trackContainer} onLayout={this.onLayoutContainer}>

What do you think ?

Add tap to navigate support?

Users might want to tap on a location to navigate there. Most media controls support this feature. Any plan to add this?

I'd like to implement this and make a PR, how should we do this? I'm thinking of using TouchableWithoutFeedback with an onPress handler for track container.

onSlidingStart only starting if onSlide is defined

An onSlidingStart function supplied as a prop is only called, if the onSlide prop is also present.

As a substitute I was able to supply an empty function for onSlide, and onSlidingStart is executed as it should.

Warning "Animated: `useNativeDriver` was not specified" when interacting

When interacting with the scrubber, the Animated library in react-native will throw a warning:

Animated: useNativeDriver was not specified. This is a required option and must be explicitly set to true or false

Although not stated in the documentation of Animated, apparently the config of Animated.timing is also required to specify a value for useNativeDriver.

Found in version [email protected].

scrubber have some leg after in slide complete

After onSlideComplete i see the scrubber for short time on the position before i started the slide.
it took me long time to find workaround but it still happens sometimes.
I used url and not local file.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.