reporter123/hfsplusdkms

hfsplusdkms's Issues

Wrong sector number: 0 or buffer size: 0

I did an Arch Linux install with the 3.12 kernel and current git of this repo on a case-sensitve, journaled, hfs+ partition. While it's been stable and everything works, I've been getting this message showing up in TTYs and in dmesg.

Looking at the source, it seems to be an issue with the journal.

Let me know if there is any additional information you need or tests you would like to be done.

Hardware: Macbook Pro 11,1

Filesystem Corruption

I get errors of the sort "Could not read the contents of : error when getting information for : cannot allocate memory" as well as "error while loading shared libraries: cannot open shared object file: Invalid argument"

Here's my dmesg | grep hfsplus:
https://www.dropbox.com/s/3kimt0olovyc6yk/hfsplusdmesg2.log

Kernel panic on setxattr

Might be related to bug #2, but I encountered a kernel panic when I started to download and compile the linux-git package from the AUR [1]. I It got through the download, but immediately afterwards it crashed with the error in the attached picture.

[1] https://aur.archlinux.org/packages/linux-git/

PPA repository

Could it be possible to publish this kernel module on a PPA to make it easier to get integrated and updated with new kernel versions? My intention is to use a hfsx partition for $HOME both for MacOS X Yosemite and (mainly) Ubuntu Mate 15.04. Also, is this intended to be integrated in upstream Linux kernel code?

Any chance of updating this for more recent kernels?

This is what happens on 4.11.x:

  CC [M]  /var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/ioctl.o
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c: In function ‘hfsplus_releasepage’:
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:90:25: error: ‘PAGE_CACHE_SIZE’ undeclared (first use in this function)
  if (tree->node_size >= PAGE_CACHE_SIZE) {
                         ^~~~~~~~~~~~~~~
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:90:25: note: each undeclared identifier is reported only once for each function it appears in
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:92:29: error: ‘PAGE_CACHE_SHIFT’ undeclared (first use in this function)
    (tree->node_size_shift - PAGE_CACHE_SHIFT);
                             ^~~~~~~~~~~~~~~~
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c: In function ‘hfsplus_journaled_writepage’:
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:131:38: error: ‘PAGE_CACHE_SHIFT’ undeclared (first use in this function)
  const pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT;
                                      ^~~~~~~~~~~~~~~~
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c: In function ‘hfsplus_direct_IO’:
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:155:17: error: implicit declaration of function ‘iov_iter_count’ [-Werror=implicit-function-declaration]
  size_t count = iov_iter_count(iter);
                 ^~~~~~~~~~~~~~
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:158:27: warning: passing argument 1 of ‘blockdev_direct_IO’ makes pointer from integer without a cast [-Wint-conversion]
  ret = blockdev_direct_IO(rw, iocb, inode, iter, offset,
                           ^~
In file included from ./include/linux/seq_file.h:10:0,
                 from ./include/linux/pinctrl/consumer.h:17,
                 from ./include/linux/pinctrl/devinfo.h:21,
                 from ./include/linux/device.h:24,
                 from ./include/linux/genhd.h:64,
                 from ./include/linux/blkdev.h:10,
                 from /var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:11:
./include/linux/fs.h:2850:23: note: expected ‘struct kiocb *’ but argument is of type ‘int’
 static inline ssize_t blockdev_direct_IO(struct kiocb *iocb,
                       ^~~~~~~~~~~~~~~~~~
/var/lib/dkms/hfsplus-dkms/1.1-ppa1/build/inode.c:158:31: error: passing argument 2 of ‘blockdev_direct_IO’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  ret = blockdev_direct_IO(rw, iocb, inode, iter, offset,
                               ^~~~
In file included from ./include/linux/seq_file.h:10:0,
                                                                32,1           0%

Support for newer kernels?

The kernels in Ubuntu Trusty and Utopic (3.14 and 3.16 respectively) are too new for this driver, it seems. It doesn't want to compile on either. Is there any chance we could get this updated?

Extended attributes and bsdtar

I see this message several times when compiling PKGBUILDs and compressing them with bsdtar:

bsdtar: Couldn't list extended attributes: No data available