retextjs/retext-syntax-urls

plugin to classify url-like values as syntax, not natural language

retext-syntax-urls's Issues

Regression in 3.1.0 - TypeError: Cannot read property 'type' of undefined

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

3.1.0

Link to runnable example

n/a

Steps to reproduce

git clone [email protected]:IsaacScript/isaacscript.github.io.git
cd isaacscript.github.io.git
git checkout c7acddaaf2aa66dcc593040384f2a269894c0b8f
vim .remarkrc.mjs

Comment out the line that says .use(retextSyntaxURLs) and save the file.

./lint.sh

Notice that it succeeds.
Now, uncomment out the retextSyntaxURLs line.

./lint.sh

Notice that it fails with the following error:

docs\converting-lua-code.md
  1:1  error  TypeError: Cannot read property 'type' of undefined
    at mergeLinks (file:///D:/Repositories/isaacscript.github.io/node_modules/retext-syntax-urls/index.js:86:12)
    at Object.iteratee (file:///D:/Repositories/isaacscript.github.io/node_modules/retext-syntax-urls/node_modules/unist-util-modify-children/index.js:48:12)
    at arrayIterate (file:///D:/Repositories/isaacscript.github.io/node_modules/retext-syntax-urls/node_modules/array-iterate/index.js:37:25)
    at Array.iterator (file:///D:/Repositories/isaacscript.github.io/node_modules/retext-syntax-urls/node_modules/unist-util-modify-children/index.js:37:5)
    at Of.run (file:///D:/Repositories/isaacscript.github.io/node_modules/parse-latin/lib/index.js:46:23)
    at Of.Constructor.<computed> [as tokenizeSentence] (file:///D:/Repositories/isaacscript.github.io/node_modules/parse-latin/lib/index.js:374:17)
    at Of.parser (file:///D:/Repositories/isaacscript.github.io/node_modules/parse-latin/lib/parser.js:13:43)
    at Of.Constructor.<computed> [as tokenizeParagraph] (file:///D:/Repositories/isaacscript.github.io/node_modules/parse-latin/lib/index.js:374:35)
    at Of.parser (file:///D:/Repositories/isaacscript.github.io/node_modules/parse-latin/lib/parser.js:13:43)
    at Of.Constructor.<computed> [as tokenizeRoot] (file:///D:/Repositories/isaacscript.github.io/node_modules/parse-latin/lib/index.js:374:35)

Separately, you can confirm that this is a regression in this specific package by setting "retext-syntax-mentions": "3.0.0", in the package.json file, doing an npm install, and then running ./lint.sh, and observe that it succeeds (without commenting anything out).

Expected behavior

It should not produce any errors.

Actual behavior

It does produce an error.

Runtime

Node v16

Package manager

npm v7

OS

Windows

Build and bundle tools

Docusaurus

`localhost` URLs not recognized as valid

Very common in a README, I would think, to point the developer to a localhost URL.

Example: http://localhost:3000/home

Perhaps this is more of an issue with retext in general, but I am using it in the context of this package with retext-spell:
https://github.com/tbroadley/spellchecker-cli

Issue with parsing on-premise URLs

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

3.1.1

Link to runnable example

No response

Steps to reproduce

The plugin fails to parse on-premise URL. Example:

import { unified } from "unified";
import retextEnglish from "retext-english";
import retextSyntaxUrls from "retext-syntax-urls";
import { visit } from 'unist-util-visit';
import { inspect } from 'unist-util-inspect';

const content = 'on-premise URL: https://CorporateIntranet/page.aspx'
const processor = unified()
            .use(retextEnglish)
            .use(retextSyntaxUrls);
const tree = processor.parse(content);
console.log(inspect(tree));

Expected behavior

The source node should be: https://CorporateIntranet/page.aspx

Actual behavior

The source node is: page.aspx

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

Issue with parenthesis

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

3.1.1

Link to runnable example

No response

Steps to reproduce

import { unified } from "unified";
import retextEnglish from "retext-english";
import retextSyntaxUrls from "retext-syntax-urls";
import { visit } from 'unist-util-visit';
import { inspect } from 'unist-util-inspect';

const content = 'Incorrect source node (e.g. [email protected])'
const processor = unified()
            .use(retextEnglish)
            .use(retextSyntaxUrls);
const tree = processor.parse(content);
console.log(inspect(tree));

The bug is described below.

In addition, if I change the content to:

const content = '(e.g. [email protected])'

The library will give an exception saying that: 'TypeError: Cannot read properties of undefined (reading 'type')'

Expected behavior

Source node is '[email protected]'.

Actual behavior

Source nodes are: '(e.g' and '[email protected])'

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response