rethore/fused-wake

A repository of wind plant flow models connected to FUSED-Wind

fused-wake's Issues

All models documented

All models should be documented with reference, docstring, and example of use case

• GCL
• NOJ
• Ainslie
• sDWM

Unit-tests ready for all models

All models should have the following unit tests:

• comparison to fixed analytical or previous values when possible
• comparison of the functions between fortran and python implementation

Models:

• GCL
• NOJ
• Ainslie
• sDWM

Move all FortranWake

Move all FortranWake unit tests to NOJ and GCL new directories

Remove all legacy FUSED-Wind dependency

TravisCI doesn't work with python3.5

TravisCI doesn't work with python3.5 distribution. This error has been reported in multiple places

$ pip install -U tox
You are using pip version 6.0.7, however version 7.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting tox
  Downloading tox-2.3.1-py2.py3-none-any.whl (40kB)
    100% |################################| 40kB 7.3MB/s 
Collecting virtualenv>=1.11.2 (from tox)
  Downloading virtualenv-13.1.2-py2.py3-none-any.whl (1.7MB)
    100% |################################| 1.7MB 234kB/s 
Collecting py>=1.4.17 from https://pypi.python.org/packages/2.7/p/py/py-1.4.31-py2.py3-none-any.whl#md5=aa18874c9b4d1e5ab53e025008e43387 (from tox)
  Downloading py-1.4.31-py2.py3-none-any.whl (81kB)
    100% |################################| 86kB 1.4MB/s 
Collecting pluggy<0.4.0,>=0.3.0 (from tox)
  Downloading pluggy-0.3.1-py2.py3-none-any.whl
Installing collected packages: pluggy, py, virtualenv, tox
  Found existing installation: py 1.4.26
    Uninstalling py-1.4.26:
      Successfully uninstalled py-1.4.26
Successfully installed pluggy-0.3.1 py-1.4.31 tox-2.3.1 virtualenv-13.1.2
$ tox
GLOB sdist-make: /home/travis/build/rethore/FUSED-Wake/setup.py
py35 create: /home/travis/build/rethore/FUSED-Wake/.tox/py35
ERROR: InterpreterNotFound: python3.5
___________________________________ summary ____________________________________
ERROR:   py35: InterpreterNotFound: python3.5
The command "tox" exited with 1.
Done. Your build exited with 1.

Input file based on windIO

FUSED-Wake should be able to import wind farms and wind turbines defined with windIO

Readme ready

The Readme should include the following sections:

• Installation instructions
• Running the benchmarks
• How to use as a library
• Reference to the articles
• Citation instruction for the repository
• Zenodo badge when the repo has been tagged for version 0.1

FarmEfficiency notebook uses files that are not in the repo

It seems that there is a directory missing:
'../data/LillgrundEfficiency/sDWM/Dominant/'

Windows installation guidelines

Is FUSED-Wake supported by Windows and if yes, are there any guidelines for installation?

A few benchmarks

The repo should have a few test cases to showcase and test the models:

• Horns Rev I
• Nysted
• Middelgrunden
• Lillgrund

So that should include the input files, and some normalised validation datasets already available in public reports or articles. The demonstration should be done through Jupyter notebooks and the test should be done in a new directory call benchmarks, that should be run with the other unit tests.