reujab/enquote

A Rust library that quotes, unquotes, and unescapes strings

enquote's Issues

Error's fmt::Display implementation recurses

The Error implementation will infinitely recurse when printed (but not debug printed).

For example, from an evcxr prompt:

> println!("{}", enquote::unquote(r#""hello \/world""#).unwrap_err())
Child process terminated with status: signal: 11

Unfortunately I'm not sure there's an idiomatic way to fix it now without making breaking changes, since Error::description() has now been deprecated. I think this might be sensible fix:

use std::error;
use std::fmt;

#[derive(Debug, PartialEq)]
pub enum Error {
    NotEnoughChars,
    UnrecognizedQuote,
    UnexpectedEOF,
    IllegalChar,
    UnrecognizedEscape,
    InvalidUnicode,
}

impl fmt::Display for Error {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        write!(f, "{}", match self {
            Error::NotEnoughChars => "not enough chars",
            Error::UnrecognizedQuote => "unrecognized quote character",
            Error::UnexpectedEOF => "unexpected eof",
            Error::IllegalChar => "illegal character",
            Error::UnrecognizedEscape => "unrecognized escape sequence",
            Error::InvalidUnicode => "invalid unicode code point",
        })
    }
}

impl error::Error for Error {}

I'd be happy to propose this as a pull request, but held off since it's a possibly breaking change.