Comments (9)
Just noticed this after #36 was merged. #34 (comment) also fixes it on my end. How long has it been like this? 🤔
I have updated the README.md file 17 days ago 😅
Ref: 1027eec
@mgrachev yeah, I think the reason is tripped up a few of us is because it was a breaking change BUT it broke silently. We had no idea the check was not actually working since it just returned 0 rubocop errors.
I've just gone though all our repos and updated the workflows so all good but maybe for these kind of changes, make it clear it's a breaking change. Do appreciate your work on this though, this action is GOLD.
from action-rubocop.
Hey @dnorth98 👋
Do you use the setup-ruby action in your workflow file?
Example:
name: reviewdog
on: [pull_request]
jobs:
rubocop:
name: runner / rubocop
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v1
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0.0
- name: rubocop
uses: reviewdog/action-rubocop@v1
with:
rubocop_version: gemfile
rubocop_extensions: rubocop-rails:gemfile rubocop-rspec:gemfile
github_token: ${{ secrets.github_token }}
from action-rubocop.
@mgrachev Oh interesting! No, we don't. Guess this is a new requirement? I'll look at adding that and see if it addresses the problem.
from action-rubocop.
That did it. Thanks for the info! 👍
from action-rubocop.
I got the same error and #34 (comment) fixes it on my end. Thanks.
from action-rubocop.
Just noticed this after #36 was merged. #34 (comment) also fixes it on my end. How long has it been like this? 🤔
from action-rubocop.
Just noticed this after #36 was merged. #34 (comment) also fixes it on my end. How long has it been like this? 🤔
I have updated the README.md file 17 days ago 😅
Ref: 1027eec
from action-rubocop.
It seems like on self-hosted runners there might be an issues with permissions; thing that didn't really exist in docker-based action. I have an error like this:
Run ruby/setup-ruby@v1
with:
ruby-version: default
bundler: default
bundler-cache: false
working-directory: .
env:
ImageOS: ubuntu18
Using 2.7.2 as input from file .ruby-version
Error: EACCES: permission denied, mkdir '/opt/hostedtoolcache'
At the moment I've pinned version to 1.7.1
to fix that; I'm gonna investigate this issue later. Might be a purely my side issue, but I'm not 100% sure.
from action-rubocop.
You should add permission to write for the /opt/hostedtoolcache
directory.
More information here: https://github.com/ruby/setup-ruby#using-self-hosted-runners
from action-rubocop.
Related Issues (20)
- Can't seem to be able to run the correct rubocop version HOT 1
- Add ability to skip install of rubocop and extensions HOT 1
- How i can use my own robocop rule? HOT 1
- Set default token to `github_token` input parameter HOT 5
- Undefined method `begin' for PseudoSourceRange HOT 6
- Fail running rubocop step if rubocop command itself fails HOT 5
- gem install was failed with Ruby 2.6.6 HOT 2
- Getting undefined method `cleanpath` when running via GitHub HOT 6
- Takes too long HOT 5
- getting REVIEWDOG_GITHUB_API_TOKEN error HOT 2
- [BUG] Invalid request. Only 65535 characters are allowed; 70292 were supplied. HOT 6
- undefined method `begin' for nil:NilClass HOT 2
- Possible to suggest linting corrections? HOT 5
- GitHub marketplace shows v1 as the latest HOT 2
- Rubocop info severity causes build failure
- reviewdog fails to parse when `--server` option is given HOT 1
- `Style/MethodDefParentheses` creates a suggestion with just one opening parenthese
- Cache ruby gems to speed up installation HOT 2
- Replace actions/create-release HOT 1
- rubocop_extensions installation version from Gemfile does not work with wrong definition order of gems HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-rubocop.