revive-adserver/revive-adserver

The world's most popular free, open source ad serving system. You can download the latest release at:

Revive Adserver

The world's most popular free, open source ad serving system

Revive Adserver is an open source ad serving tool that enables publishers to:

• Serve ads on their websites;

• Manage their campaigns from different advertisers and/or ad networks using the simple, easy-to-use interface;

• Track and report on campaign success, including click-through rates;

• Set rules to target the delivery of campaigns, or even ads, to specific users, to help maximise the effectiveness of campaigns.

Download

DO NOT DOWNLOAD AS A ZIP FILE FROM GITHUB

Download the latest version from: https://www.revive-adserver.com/download/

Revive Adserver as available from github as a zip file is not suitable for installation on a server. It contains a number of files that are for development only, and are removed during the release packaging process.

Please ONLY download Revive Adserver as a release package from the Revive Adserver website at https://www.revive-adserver.com/.

Hosted edition

If you'd like to use the Revive Adserver software without having to download, install, configure, and maintain it yourself, there is also a Hosted edition.

You can find out more about the Hosted edition, and subscribe at https://www.revive-adserver.net/.

License

Revive Adserver is copyrighted; please see the COPYRIGHT file.

This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA

---

This product uses GeoLite2 data created by MaxMind, available from the https://www.maxmind.com/ website. See also: https://www.revive-adserver.com/blog/new-geotargeting-plugin-in-revive-adserver-v5-an-overview/

revive-adserver's Issues

Saving settings can corrupt configuration files

Background

A master OpenX setup and a separate ad delivery address.

Campaign managers and system administrators log in on master.example.com, so there is a master.example.com.conf.php config file.

Ad delivery is done via a subdomain delivery.example.com, so there is a delivery.example.com.conf.php config file as well.

Partial content of master.example.com.conf.php:

[webpath]
admin="master.example.com/www/admin"
delivery="delivery.example.com"
deliverySSL="delivery.example.com"
images="images.example.com"
imagesSSL="images.example.com"

Partial content of delivery.example.com.conf.php:

;<?php exit; ?>
;*** DO NOT REMOVE THE LINE ABOVE ***
realConfig="master.example.com"

Problem

When an administrator logs in on master.example.com/www/admin and adjusts some settings or adds a plugin, the link between the config files is broken.

In delivery.example.com.conf.php, the line

realConfig="master.example.com"

goes missing, and settings and plugin configuration lines will end up in delivery.example.com.conf.php instead of master.example.com.conf.php.

Deprecate instances of old constants

For example:

• OA_VERSION
• MAX_PRODUCT_NAME
• MAX_PRODUCT_URL

etc.

Directories missing in the git repo

i.e var/plugins

HTTPS safe HTML ads are not served via HTTPS

They only do if "Alter HTML to enable click tracking for" is set to "Richmedia - OpenX".

Rebranding - Update plugins

All of the existing plugins should be updated to change, as far as possible, their names. This may require additional functionality in the application to handle a change of plugin key value, but it should be possible to do.

Previously disabled plugins are enabled during upgrade

The install-plugin.php code migrates and enables everything, regardless of their previous status.

Deprecate plugin server code & check mechanism?

In the plugin_repo directory, there is code for a plugin server that could be checked to see if there are any updated plugins. However, the OX_PluginManager::checkForUpdates() is not used anywhere in the Revive Adserver code base. Should we deprecate the server code and associated checking for updates code / configuration options? Is this required? Plugins can be updated with releases of Revive Adserver - or would an update mechanism be better to have?

Rebranding - Logo

Update the logo throughout the application to the new Revive logo.

Rebranding - Documentation Update

Migrate user & administrator documentation to GitHub.

Deprecated warning on the conversion tracking settings page

On the:

Configuration > Global Settings > Conversion Tracking Settings

page, a deprecation warning is returned:

"Assigning the return value of new by reference is deprecated"

when using PHP 5.3

Inventory Setup Wizard

The inventory setup wizard link for a zone seems to depend on the OpenX Market plugin, which is no longer present.

Perhaps the entire OpenX Workflow plugin needs to be removed from Revive?

Rebranding - Policy

Review and update the policy document as part of the rebranding process.

Deprecate the M2M system

Should all of the M2M code be deprecated and removed?

Add new delivery plugin hook(s) to replace hardcoded behaviour in core

Banners using OpenX/Max 3rdParyAdserver plugin are often treated as exceptions in the core code. See e.g. #22 (comment)

Appropriate plugins hooks should be provided and the code moved where it actually belongs.

Rebranding - File headers

Updated the product name, copyright, etc. in all code file headers.

Cannot link banners via the zone view

When viewing a zone's linked banners tab, it's not possible to find any advertisers/campaigns to link, even when valid ones exist.

Removed deprecated database fields

Once #17 is merged into trunk, create a new database migration that removes deprecated database fields related to M2M, adnetwork and advsignup. Also add the necessary configuration file items to the deprecated configuration file so that they are removed from the user's configuration as well.

OpenX -> Revive ? What's going on? :)

Hey guys,

As I see you guys took over openx source?
Do you mind posting some info about your plans, etc?
Are you part of openx Inc, or not? If not, will that repo stay under openx account?
Who is the owner of github openx account?

I'm running couple of very big openx setups and willing to help, if the project is in right hands.

I guess, there are other people who would like to contribute as well.

Thanks!

Rebranding - Update sync server

Update the details of the sync server that is contacted for upgrade messages.

Update default database prefix

Update the default database prefix for new installations.

Adding a favicon.ico

I would like to propose adding a favicon.ico file, for 2 reasons:

• it improves the look of the application, for example in browser favorites and address bar
• it stops the many "404 File not found" errors in webserver log files, since browsers tend to look for a favicon.ico file even it if is not included in the HTML code

Adding it is very simple:

• in file /lib/templates/admin/layout/main.html
• just before line 94:
  </head>
• add this line:
  <link rel="shortcut icon" type="image/x-icon" href="favicon.ico" />

Of course, a favicon.ico file needs to be present in the www/admin folder of the script.

Remove OpenX Market Intro on Upgrade

On upgrade, an introduction to the OpenX Market is displayed on the final page of the upgrade wizard. This needs to be removed.

Rebranding - Plugins

Update the name of plugins (just the name, not necessarily the ox prefix for this release) that are available/used. Needs to ensure that upgrades change plugin versions correctly.

Add compatibility for PHP 5.4+

PHP 5.3 is security only now ;)

Remove Market - Upgrades

Ensure that on upgrade to Revive, the old OpenX Market and OpenX Workflow plugins are removed from the user's installation.

PSR-0 and Composer compatibility for API classes?

Hi. I'm browsing through the XML-RPC API v2 classes for PHP and I'm thinking whether it would be a good idea to refactor the API classes to support PSR-0 autoloading and also add composer.json. This would make the API library sooo much easier and nicer to use with modern PHP frameworks (I'm a Symfony2 guy myself). So my questions are:

1. Are you planning or doing something like this?
2. If not, are you willing to accept PRs containing this kind of refactoring? It's of course a BC break, so some kind of versioning would be required.
3. If yes, will it be beneficial work or are you planning of changing the API soon anyway?

Move plugins to a new repository.

Now that the code is being managed in GitHub, it makes sense to just be able to tag releases, and have GitHub create the .zip file. So, the plugins_repo should be moved out of the Revive Adserver repository, and into their own repository.

Deprecate the M2M system

Should all of the M2M code be deprecated and removed?

Rebranding - Update old links

Update old links to OpenX domains (e.g. forum, help links, documentation, etc.) as these are either no longer there, or will be removed at some stage.

Merge in security fixes

Security fixes already disclosed in the OpenX 2.8.11 release need to be merged into the Revive Adserver 3.0.0 release.

Rebranding - Remove OpenX Market from openXReports plugin

The openXReports plugin has a hard-coded reference to the OpenX Market plugin, which is deprecated. Update and release the openXReports plugin with this hard coded reference removed.

Review developer tools

The /www/devel directory contains a lot of (possible old) developer tools. These need to be reviewed to decide if they are worth keeping or not.

Investigate segmentation faults due to PHP bug

During the fixes to add 5.4+ compatibility, I've stumbled upon a PHP GC bug: http://bugs.php.net/65367

The bug has been fixed and will be part of the next 5.4/5.5 releases, but that means that the code isn't fully working on PHP versions <5.4.19 and <5.5.2. It would be pretty bad to add such requirement during the install / upgrade phase, and it would also not help people upgrading PHP to some of the affected versions.

It would be great if we could find the code that is triggering the bug and fix that.

Rebranding - Application name

Update the application name throughout the user interface, documentation, etc.

Remove Market - UI Code

There are a number of places where the UI code tests to see if the OpenX Market plugin is installed, and if so, performs custom actions. Remove these, as the OpenX Market is deprecated and will not be included in the application any more.

Remove Market - Installer

Remove the need to sign up for an OpenX Market account and do not install the OpenX Market plugin on installation.

Doesn't work in Chrome

The CSS fails to load in Chrome, making the UI unusable. Test

Remove the oxAuthCAS plugin

Only appears to be in the plugin repository, not actually used.

Web based phpunit test system fails

It fails with an error whenever used to try to run tests.

Remove site/zone category, country and language settings?

Now that the Market plugin (along with associated functionality in the core system) is being removed, I would like to propose to also remove the drop downs for Category, Country and Language in the Site properties dialog, and for Category in the Zone properties dialog.

These classifications were, as far as I know, used by OpenX v2.8 when the impression was sent to the OpenX Market, to correctly classify the impression for the buyers there.

Categories also appear in the Linked Zones tab for a campaign, and there they can be used as a way to filter the lists of available and linked zones.

I've had many confusing conversations with clients, about the need to specify these classifications. I would like to propose to remove them, now that the Market features are being removed from Revive. If we do keep them, it should be made more clear what they are for (i.e. virtually nothing) and that people don't have to spend a lot of time to correctly specify all of them since it doesn't affect the ad selection mechanism anyway.

Set up Bamboo CI

Quite a lot of work went into tests in the past - these should be run through Bamboo CI and update where required, so that tests are working with CI.

Rebranding - Remove OpenX Market Strings

There are still some OpenX Market strings in the EN translation files, as they are referenced in the code base. Need to figure out where and how these are used, so they can be safely deprecated and removed.

Rebranding - Dashboard Update

Dashboard needs to have the following removed:

• OpenX Community Profile
• OpenX Community Statistic
• OpenX News
• OpenX Support Forums

Automatically regenerate delivery scripts

MySQL 5.5+ expects ENGINE rather than TYPE in CREATE TABLE statements

MDB2's createSequence method uses the deprecated/unsupported syntax.

Deprecate Canoo tests

The Canoo tests have not been maintained, and the current maintainers don't know how to run them. Given what's needed re: testing, it's probably best just to deprecate the Canoo tests.

Rebranding - Remove Hard Coded OpenX Market Plugin Calls

Seems like there are lots of places the OpenX Market plugin is hard-coded in the UI code. These hard coded calls need to be removed, as the OpenX Market plugin is deprecated and no longer installed / removed on upgrade to Revive.

Remember statistics dates

When moving about between various statistics views, the most recently selected date range to view (e.g. today, yesterday, all statistics, etc.) could be remembered, so that users don't have to keep re-selecting the appropriate value as they change what they are looking at.

Rebranding - README etc.

Update the README, COPYRIGHT files, etc.

Strict standards error message

"Strict standards: Non-static method PEAR::setErrorHandling() should not be called statically in lib/Max.php on line 207"