rgsteele/psadt-lenovothininstaller

A PSADT wrapper for deploying the Lenovo Thin Installer utility

psadt-lenovothininstaller's Issues

Add option to initiate SCCM hardware inventory scan after update installation

If using the option to save Lenovo update installation status to WMI, it would be useful to initiate a hardware inventory scan after the completion of update installation to ensure the update status in the SCCM database is as current as possible.

Here's the PowerShell command to use:
Invoke-WMIMethod -ComputerName $Server -Namespace root\ccm -Class SMS_CLIENT -Name TriggerSchedule "{00000000-0000-0000-0000-000000000001}"

It could be initiated right away if there is no immediate reboot pending, or scheduled to occur after reboot.

Scan for needed updates fails with Thin Installer 1.3.00018

When used with Thin Installer version 1.3.00018, the scan for updates [1] exits with a non-zero error code and the update db is not populated.

[1] Line 164: Execute-Process -Path "ThinInstaller.exe" -Parameters "/CM -search A -action SCAN -repository $RepositoryLocation -includerebootpackages 1,3,4,5 $exportToWMIswitch"

Add support for web-hosted repositories

Currently, PSADT-LenovoThinInstaller only supports a repository hosted at a local or UNC path. It should be updated to support a URL as a repository location.

Only suspend BitLocker when PCR 7 is not enabled

Currently, PSADT-LenovoThinInstaller will always suspend BitLocker before performing any update which forces a reboot (i.e. BIOS and other firmware). This is because a BIOS update will cause a lockout. However, this is only the case if Secure Boot is disabled and/or PCR 7 isn't defined. If both of these are defined, suspending BitLocker isn't necessary and shouldn't be done.

Hung installation of an update stalls the whole script

Some updates stall without completing (possibly because they are waiting for user input, despite being run with a silent install switch). The script should detect this condition and kill installations that run longer than a specific duration (say, 20 minutes).

Reboot doesn't occur when updates are installed with no user logged in

The script completes with exit code 0 when updates with reboot type 3 (Reboot required but not forced by the package) are installed and no user is logged in. The following lines are logged:

[Pre-Installation] :: *** Applicable updates ***		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: Type 0 (No reboot required): 2		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: Type 1 (Reboot forced by the package): 2		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: Type 2 (Reserved): 0		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: Type 3 (Reboot required but not forced by the package): 16		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: Type 4 (Shutdown forced by the package): 0		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: Type 5 (Reboot delayed): 1		2019-08-28 2:39:38 PM	0 (0x0000)
[Pre-Installation] :: **************************		2019-08-28 2:39:38 PM	0 (0x0000)
[Installation] :: [ThinInstaller.exe] successfully resolved to fully qualified path [C:\WINDOWS\ccmcache\2n\Files\ThinInstaller.exe].	Execute-Process	2019-08-28 2:39:38 PM	7872 (0x1EC0)
[Installation] :: Working Directory is [C:\WINDOWS\ccmcache\2n\Files].	Execute-Process	2019-08-28 2:39:38 PM	7872 (0x1EC0)
[Installation] :: Executing [C:\WINDOWS\ccmcache\2n\Files\ThinInstaller.exe /CM -search A -action INSTALL -repository \\nootka\LenovoUpdates -includerebootpackages 3 -noicon -noreboot -exporttowmi]...	Execute-Process	2019-08-28 2:39:38 PM	7872 (0x1EC0)
[Installation] :: Standard error output from the process: User Parameters:  /CM -search A -action INSTALL -repository \\nootka\LenovoUpdates -includerebootpackages 3 -noicon -noreboot -exporttowmi 
Launching the application in mode: CM
Send the following parameters to the application: System.Collections.ArrayList
Launching COMMAND LINE with parameters -search A -action INSTALL -repository \\nootka\LenovoUpdates -includerebootpackages 3 -noicon -noreboot -exporttowmi 
	Execute-Process	2019-08-28 3:18:52 PM	7872 (0x1EC0)
[Installation] :: Execution completed successfully with exit code [0].	Execute-Process	2019-08-28 3:18:52 PM	7872 (0x1EC0)
[Installation] :: Install will force reboot or shutdown, so prompting user		2019-08-28 3:18:52 PM	0 (0x0000)
[Installation] :: Bypassing Installation Prompt [Mode: NonInteractive]... An important software update is available. This update will restart your computer, so save and close your documents before proceeding. Do not unplug or shut down your computer until the Windows sign in screen is displayed.	Show-InstallationPrompt	2019-08-28 3:18:52 PM	7872 (0x1EC0)
[Post-Installation] :: Bypass Installation Restart Prompt [Mode: NonInteractive].	Show-InstallationRestartPrompt	2019-08-28 3:18:52 PM	7872 (0x1EC0)
[Post-Installation] :: Lenovo_ThinInstaller_1.3.0007_EN_01 Installation completed with exit code [0].	Exit-Script	2019-08-28 3:18:52 PM	7872 (0x1EC0)
[Post-Installation] :: -------------------------------------------------------------------------------	Exit-Script	2019-08-28 3:18:52 PM	7872 (0x1EC0)

Reboot doesn't occur when ThinInstaller.exe exits with error code 1

When ThinInstaller.exe exits with error code 1, the script terminates without performing any required reboots.

Some exe-based detections steal the program focus

Some of the executable-based detection methods (used for firmware updates) cause the application focus to be "stolen" from the active application. This has been observed specifically when the PSADT script is initiated manually from the SCCM Software Center and it's unknown if the same issue occurs when the script is initiated from a scheduled deployment. It may be possible to avoid the issue by having the detection programs run in a separate process that is not user-interactive.