ricardo-ch/go-tracing

Easy to use tracing with zipkin or jaeger tracing in golang

go-tracing's Issues

docker compose missing

depencendies management missing

add tool to handle vendors in this repository
be careful about bug with thrift and opentracing (latest version of both will fail)

Example not working

Your basic example is not working (the others maybe too)

if you do

docker run -d -p 9411:9411 openzipkin/zipkin
go run examples/basic/main.go

you will see no trace on your zipkin traces page.

It is due to the fact that you use

	tracing.SetGlobalTracer(appName, "http://localhost:9411/")

instead of (removing the last /)

	tracing.SetGlobalTracer(appName, "http://localhost:9411") 

So when you create the collector
url := zipkinURL + "/api/v1/spans"

you have //.

There are 2 ways to fix it :
Or remove the / on the example (and maybe others examples)
Or fix the createCollector using maybe a path.join with a url.

OS : Ubuntu 18.04 LTS

Version `0.3.3` Fails with some java http clients

This causes traces to fail with the following error:

{
	"Accept":"application/json, application/json, application/*+json, application/*+json",
	"Connection":"keep-alive","Uber-Trace-Id":"32b656ada59bca7d%3A32b656ada59bca7d%3A0%3A1",
	"User-Agent":"Java/1.8.0_181",
	"component":"users",
	"err":"String does not match tracer state format"
}

codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella

Problem

The codahale/hdrhistogram repo has been transferred under the github HdrHstogram umbrella with the help from the original author in Sept 2020 (new repo url https://github.com/HdrHistogram/hdrhistogram-go). The main reasons are to group all implementations under the same roof and to provide more active contribution from the community as the original repository was archived several years ago.

The dependency URL should be modified to point to the new repository URL. The tag "v0.9.0" was applied at the point of transfer and will reflect the exact code that was frozen in the original repository.

If you are using Go modules, you can update to the exact point of transfer using the @v0.9.0 tag in your go get command.

go mod edit -replace github.com/codahale/hdrhistogram=github.com/HdrHistogram/[email protected]

Performance Improvements

From the point of transfer, up until now (mon 16 aug 2021), we've released 3 versions that aim support the standard HdrHistogram serialization/exposition formats, and deeply improve READ performance.
We recommend to update to the latest version.

How to set HttpResponseCode tag in span?

Hi，I’m using go-tracing and it is nice to use. And I also have a question that how to set http status code tag in one span？It seems tracer can only set tag in http handler.

func handler(w http.ResponseWriter, r *http.Request) {

	var tag map[string]interface{}
	tag = make(map[string]interface{})
	tag["http.url"] = r.URL.Path
	tag["http.status_code"] = ?
	span, ctx := tracing.CreateSpanFromClientContext(r, "hello-handler", &tag)
	defer span.Finish()
	nestedFunc(ctx)
	log.Print("Hello world received a request.")
	target := os.Getenv("TARGET")
	if target == "" {
		target = "golang"
	}
	fmt.Fprintf(w, "Hello %s!\n", target)
}