Giter Site home page Giter Site logo

Comments (8)

richardschneider avatar richardschneider commented on June 3, 2024

I agree, but the if (AnswersContainsAddditionalRecords) should be before the DNS-SD test.

Would you like to create a PR. This way you will get credit as a contributor!

from net-mdns.

eshvatskyi avatar eshvatskyi commented on June 3, 2024

I do, ) I have 1 optimization for DNS
and fix for mdns (using with multiple NIC)

from net-mdns.

eshvatskyi avatar eshvatskyi commented on June 3, 2024

Please let me know how I could create a PR

from net-mdns.

richardschneider avatar richardschneider commented on June 3, 2024

https://help.github.com/articles/creating-a-pull-request/

from net-mdns.

eshvatskyi avatar eshvatskyi commented on June 3, 2024

Lol )) I meant I dont have permissions ) to do this, should I fork it? or how to do this better?

from net-mdns.

richardschneider avatar richardschneider commented on June 3, 2024

Just make a fork of my repo. I noticed that you have done this but your fork is not current; just delete and re-fork. Make your changes. Finally you can submit by clicking new pull request.

You do not need any permissions on my repo.

from net-mdns.

eshvatskyi avatar eshvatskyi commented on June 3, 2024

Created 2 PRs, please check. not perfect ) but tested on multy Nics works perfect on windows 10 host.
Later will test on linux alpine. Missed implementation for AnswerAllQuestions, will add in case you interested in my PR

from net-mdns.

richardschneider avatar richardschneider commented on June 3, 2024

Does #40 resolve this issue?

from net-mdns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.