riiconnect24/rc24-bot

Server bot for the RiiConnect24 Discord server that can store Wii friend codes to be added. | https://discord.gg/rc24

rc24-bot's Issues

!add is broken

I have Wii friend codes on the bot, but !add is not working.

GameTDB Search

Just a cool feature that'd be nice to have.

• !gametdb RMGE01 would take you to Super Mario Galaxy.
• !gametdb Wii Sports would search for games with Wii Sports.
• !gametdb Switch AAACA would take you to Super Mario Odyssey.

You could also be fancy and make some embeds if you'd like. It being able to search for stuff is sufficient.

No mod commands implemented yet

So what are you going to use for mod commands? I found a lib for JDA mod commands, or maybe Artuto can help

Stats command is broken

Right now it looks like this.

We don't have any services in progress right now.

Mailparse doesn't throw an error if the nwc24msg.cfg is invalid, is longer than it should be, etc.

Parse error: undefined
Call stack: undefined KaitaiUnexpectedDataError: expected [80,75], but got [87,99]

Server log needs to be more flexible

Currently, #server-log is required. The name can't be changed. This should go by config and also split with #mod-log

Add country flag to profile

That'd be a pretty cool feature, the flag would be represented by an emoji, of course. I just thought of it.

Move !error command to use OkHttp

Stop using Java's basic utility in favor of OkHttp which is better.

Incorrect username shown

Upon running !add user, the user being added's name is sent in place of the user who requested to add them.

Observe, when a user tried to add PokeAcer (with Japanese nickname).

I'll try and fix this myself later.

Fix !wads link

Please fix the !wads link so that it links to RiiConnect24-Patcher instead of IOS-Patcher. The latter's deprecated.

Possible permissions error

!config setchannel gives no permissions error. Looking at BotConfig.java there's no apparent permission checking (I might have missed something in another file) and it allows (seemingly all) users to run !config setchannel.

https://vgy.me/U22rrz.jpg
https://vgy.me/UuAxU4.jpg

Birthday duplicate checking

The bot should check if a user's birthday is in the birthdays.yml file before adding it again. If it's on a different day (IDK why you'd change it), delete the old entry.

Commands are case sensitive.

This should be relatively to fix, but I don't have enough knowledge about Ruby to make a proper PR.

Fix NEWS/FORE error code case

!error NEWS000006 works.

!error news000006 doesn't.

Also, it should say that the riiconnect24-batteryfix trick only works with the Forecast Channel.

Removing a code incorrectly implies it's a Wii fc

Running a command such as !code remove game | <game name> incorrectly says something such as below:

RiiConnect24 Bot BOT - Today at 21:57
:x: A code for Wii <game name> is not registered. 

Presumably it would have human readable versions of the name but ¯/_(ツ)_/¯

Fix Mail patcher

What the title says

Birthday parsing is broken

This might be server-side but parsing someone's birthday is broken. Seriel was trying to fix it earlier today but she might have broke it more.

Add GitHub actions file

Add config file to Build and archieve packages.

Birthdate Note

When displaying a birthdate, or adding one, it should mention that you need to put/it's displayed in /

!help - Grammar

In the Wii-related section of the !help command:

!code - Manages wii for the user.
!add - Sends your friend wii to another user.

Birthdate Format

The birthday command should indicate that the format of the birthday is DD/MM. Why is it in that format anyway? I forgot why.

Fix Engrish

If you haven't added your birthday, RC24 Bot says "You don't have set your birthday". It should say "You haven't set your birthday".

Migrate to RiiConnect24 GitHub

Per a discussion with @larsenv, it might be useful to move this to the official GitHub where all the related community can see it, compared to just yours where other communities can see it.

(I'm down for it if you want)

Backloggery Support

It would be cool if you could link to your Backloggery with code lookup. Since it's already possible to add it as a game, if it can be embedded into !code lookup as an image, that would be cool.

Roles broken when added to new server

RC24 Bot complains when it's added to a new server.

!patch not working

the bot doesn't reply to uploaded mail files. It doesn't error out or smth, but just doesn't do anything, as seen below:

Cant add it to my server

i cant add it

Badges screw-up

When looking up someone's profile on RC24 Bot, there's a problem that shows the user that looked up the code's badges instead of the user that you looked up.

Small typo when setting channel

Small typo when using the command !config setchannel <type> <channel>
http://i.imgur.com/s0RoDUW.png

RiiTag command is not searching for users async

Sentry Issue: RIICONNECT24-BOT-34

UnsupportedOperationException: Blocking operations are not permitted on the gateway thread
    at xyz.rc24.bot.utils.FinderUtil.retrieveMembers(FinderUtil.java:68)
    at xyz.rc24.bot.utils.FinderUtil.findMembers(FinderUtil.java:57)
    at xyz.rc24.bot.utils.SearcherUtil.findMember(SearcherUtil.java:43)
    at xyz.rc24.bot.commands.general.RiiTagCmd.execute(RiiTagCmd.java:69)
...
(20 additional frame(s) were not displayed)

One of the EventListeners had an uncaught exception

Unable to lookup stored friend codes

I am unable to lookup any friend codes that are stored. When I try, it brings up an embed with "Please select a code type:" and nothing else.

Fix the !code help command

When typing in !help, the prefix for the bot shows up as @RiiConnect24 Bot, and I want !code help to show the instructions on how to add a code, with the platforms and stuff. Not to call out names, but Jaume was very confused.

Add !code rename and allow the code types to work in capitals

If the things in the title are added they will be useful and will make things easier!

Make embed color be user's role color for !code lookup

This was a small thing that was in previous versions of RiiConnect24 Bot. It added a little touch to the embed.

Also, can the birthday you find from a user be embedded, and maybe have a cake emoji?

Copyright invalid

Tons of the copyright here is messed up, as several parts written by @ArtutoGamer, @spotlightishere, @Seriell and @larsenv either have invalid names or are omitted entirely.

I'll be attempting to fix DC24’s bot throughout this as well, will take a picture once completed.

Auto-role for RC24 Server

We left few days ago the Verified role. Now iBot's auto-role feature adds to each new member the new Checkpoint role (that is just an inverted Verified).
We would like to have a second bot to handle the task in the case iBot is down when someone joins.

So, when someone joins the RiiConnect24 server. We wait like 5 seconds, then we check their roles.
If the member has the Checkpoint role, it's okay.
If the member doesn't have, we add that role to them. (ID:374627304560656384).

Thank you 👍
(Artuto was supposed to do it)

Add DS section to the friend code bot

Requesting this for a friend

1.1.1.1

On the !dns command, please make it say that 1.1.1.1 can be an alternate DNS used.

8.8.8.8 can be your Secondary DNS (or 1.1.1.1, alternatively)

Fix birthday timing

Not sure how easy this would be to fix, but I think the birthday times need to be fixed.

So today was BlueHairedBoi's birthday (the 19th, happy birthday!) but the bot didn't say happy birthday until midnight UTC (that would be the 20th).

!config partially shortens role names

Due to a bug most likely introduced in 10f3e05, role names are shortened when possibly listed, and role types aren't checked.

A new feature!

Since your bot only displays Wii Information, I would like to propose a 3DS function!
This would give more users (like me :D) another option, such as Nintendo servers
And in future development could bring upon more such as Nintendo Switch Profiles or Wii U Profiles
I think this would give the bot a boost in recognition, but anyways I really do like this bot's UI so i hope it'll get more features soon.

Move to MySQL

Due recent issues with redis and it being too dumb.

I have discussed with @larsenv and we think the best option is to move to MySQL.

This will need a rewrite of the database system.

Add Stackdriver integration

As RC24-Bot currently runs on a Google Cloud Platform instance, it has the option of Stackdriver integration. This would help greatly for finding issues.

This would also have to be optional, as I'm sure not all users would want it. More research into the libraries available for issue reporting will have to be made.

Double check the role exists for everything

This was an issue in the Ruby implementation -- it never cared enough to check for permissions, nor if the channel even existed.

The current solution will be done:

• Upon addition to a server, the default log names will be used.
• Log will be off by default.
• #mod-log will be optional.
• The server owner will be DMed regarding results, or sent information about configuration of the log.

Upon failure to access log:

• Owner sent DM
• Log type disabled.

Missing _ in a string

Hola,

I think there's a mistake in the Larsenv's commit which adds the facts command to the RiiConnect24 bot.
event.respond("_**Did you know?**__ " + facts.sample + " Got any facts we should add? Ask Larsenv or another RiiConnect24 developer!")
should be replaced with
event.respond("__**Did you know?**__ " + facts.sample + " Got any facts we should add? Ask Larsenv or another RiiConnect24 developer!")

GameTDB 4 character ID

Currently the bot doesn't support 4 character disc IDs. Perhaps this needs an API or some method of grabbing the ID?

Custom roles per server, defined by a config

Currently roles are hardcoded: "Moderators", "Bot Helpers" and "Developers".

Perhaps a !config command needs to be introduced?

!add - Not working

When you try to add someone by typing in !add (Somebody) it just doesn't work.

Mod log

Currently, on servers without a mod log, we get the following:

[ERROR : et-14417 @ 2017-03-26 23:02:57.454] Exception: #<NoMethodError: undefined method `resolve_id' for nil:NilClass>
[ERROR : et-14417 @ 2017-03-26 23:02:57.454] /home/spotlight/gems/ruby/2.4.0/gems/discordrb-3.2.1/lib/discordrb/cache.rb:33:in `channel'
[ERROR : et-14417 @ 2017-03-26 23:02:57.454] /home/spotlight/RC24-Bot/modules/userjoin.rb:13:in `get_mod_log?'
[ERROR : et-14417 @ 2017-03-26 23:02:57.454] /home/spotlight/RC24-Bot/modules/userjoin.rb:89:in `block in <module:Userjoin>'
[ERROR : et-14417 @ 2017-03-26 23:02:57.454] /home/spotlight/gems/ruby/2.4.0/gems/discordrb-3.2.1/lib/discordrb/events/generic.rb:98:in `call'
[ERROR : et-14417 @ 2017-03-26 23:02:57.454] /home/spotlight/gems/ruby/2.4.0/gems/discordrb-3.2.1/lib/discordrb/bot.rb:1227:in `block in call_event'

A check should be added. I don't have enough time to do it myself.

Implement paginator for codes

Implement paginator for code lookup.