rikkigibson/corvallis-bus-ios

The iOS client for the Corvallis Bus service.

corvallis-bus-ios's Issues

Adopt SFSafariViewController

https://developer.apple.com/documentation/safariservices/sfsafariviewcontroller

Might be able to delete BusWebViewController and replace with this. This could solve some of the problems where the city redirects the bus route's URL, etc.

Handoff

Handoff between the website and app could be implemented. How cool would that be? Let's do it.

Remove Flurry Analytics

If user agent strings include the iOS version there's no need for third-party analytics. Since there are console warnings now about calling status bar orientation stuff outside of the main thread, might as well just remove Flurry to silence them.

Widget in iOS 10

iOS 10 has introduced some changes to the way widgets work. The background color is light now, which requires that text and images match. There's now conditional logic to show light or dark images and text based on whether the app is running on iOS 10 or a higher version. Ideally, we would be able to check the background color and use the appropriate theme, or just use the built-in colors of a theme, but this didn't pan out on iOS. Oddly enough, it was easy to do in macOS.

Widgets need to be able to collapse to a limited height. This height permits showing just one favorite stop with the current table cell design. The best thing to do in this case is to show the user's nearest favorite stop, regardless of whether they have enabled showing the nearest of all stops. The Show More/Show Less button can be used to reveal between 2 and 7 total favorite stops. The button should not appear if there is only 1 stop to display.

There is an inelegant case where the user wants to show 1 favorite stop, and has enabled "Show Nearest Stop". Show More/Show Less is available in the widget, and hitting it causes the widget to alternate between showing the user's nearest favorite or the nearest stop. The solution I'm leaning toward for this is to limit iOS 10+ users to show only 2-7 favorite stops, and not 1. If they want to see 1, they can simply collapse the widget.

The nearest stop is intended to be a quick supplement to your regular usage patterns, or something to show if you haven’t added any favorites at all yet. If there's anyone who only wants to show the nearest stop in the widget, and has favorited any stops in the app, they won't be able to do that any more. I doubt there are many people who use the app this way.

Action items:

• use the appropriate color theme based on iOS version (already done)
• if the widget is collapsed, show a single stop; either whatever came back if there was only one stop in the results, or the nearest favorite. (already done)
• set the minimum number of stops to show in favorites to 2 on iOS 10+. (about to do)

Dark mode support via vectorized graphics

iOS 11 adds support for vector graphics in asset catalogs. This is good for dark mode because you can just use system colors on the vector graphics that automatically change to the right color.

Tutorial/user's guide

The current tutorial that pops up the first time you launch the app is a bit sloppy and confuses a lot of users despite the intent. It would probably be better to replace it with a dialog on first launch that offers to show a web view that explains the basics more simply and allows people to find out the nitty gritty behaviors of the app if they really want to know.

Use Xcake

A good amount of headway was made with Xcake, workarounds and all. It would be nice to be able to merge that feat-xcake branch in and just commit or script modification of whatever targets aren't being generated properly.

Also, it would be a good opportunity to stop versioning the Pods folder if that turns out to be appropriate. People seem divided on the question.

Use MKWebView or SafariViewController instead of UIWebView

Some crash reports are coming in that are probably due to the use of the old UIWebView component. This is used because it's the best that iOS 7 can support. However it would be wise to either drop iOS 7 support or figure out a way to conditionally use the right web view for the user's OS version.

Service alerts list items have weird alignment

I don't have a screenshot, but basically for service alerts whose titles are a particular length, the blue "unread" dot can get pushed off the left edge of the list item and become invisible. The text can also start farther left than it should.

This can probably be fixed by tweaking the list row constraints.

Fix iPad size class

http://stackoverflow.com/a/30792550/2855742
Based on this answer, allow the iPad to view a nice table on the left in landscape instead of an ultra wide table on the bottom.

Label text size shrinks too small

Whatever mechanism is sizing the text to fit the available space is not working very well. The label text should be considerably larger.