Giter Site home page Giter Site logo

Comments (10)

jjscheel avatar jjscheel commented on August 23, 2024

Upon further review, it does appear that the project has a license file (licensing.adoc). There are two problems with this file:

  1. It needs to be named "LICENSE" not "licensing" for GitHub to recognize it.
  2. For full license recognition by GitHub, the file needs to be raw text or .md. I'm recommending the raw format for organizational consistency.

@vlsunil, how would you like to proceed? Should I add the LICENSE file per previous post and let you deprecate the licensing.adoc by moving the copyright information into the README?

from riscv-platform-specs.

vlsunil avatar vlsunil commented on August 23, 2024

@jjscheel : Yes, please go ahead and add LICENSE file. Thanks!. I think we can remove licensing.adoc since README already has the copyright information.

from riscv-platform-specs.

jjscheel avatar jjscheel commented on August 23, 2024

@vlsunil, I've added the new file. After another look at the licensing.adoc, I think we should move the Copyright information somewhere, perhaps back into the README. I don't think we want to lose that information.

Do you want to take care of that? I'm happy to do it if you'd prefer.

I'll leave this open until we decide.

from riscv-platform-specs.

kumarsankaran avatar kumarsankaran commented on August 23, 2024

Is this issue resolved?

from riscv-platform-specs.

jjscheel avatar jjscheel commented on August 23, 2024

@kumarsankaran, I still see the licensing.adoc file in the tree and the text in it is not in the README. So, I'd say that this is not done.

I'm happy to complete the work if you'd prefer.

from riscv-platform-specs.

kumarsankaran avatar kumarsankaran commented on August 23, 2024

Yes, please Jeff. Can you complete what's needed and close this issue?

from riscv-platform-specs.

jjscheel avatar jjscheel commented on August 23, 2024

On retrospect, the licensing.adoc file should be part of the document, not the site.

@kumarsankaran, I don't see license info in the document. I believe it should be there, do you agree?

from riscv-platform-specs.

kumarsankaran avatar kumarsankaran commented on August 23, 2024

@jjscheel Yes, the licensing info should be there in the document.

from riscv-platform-specs.

jjscheel avatar jjscheel commented on August 23, 2024

@kumarsankaran, when I review the last published riscv-platform-spec from Nov 1, I don't see the licensing information nor the changelog nor the contributor. While I'm not yet an expert in asciidoc, I suspect that you failing to include these in your top file (riscv-platform-spec.adoc). I see them listed in the Makefile as $PARTS and see where that file starts the build in the top file, but I don't see any additional include files.

I'll let you folks hand this as you want. You can either continue to work it here, or open a new issuse and close this one.

Sound ok?

from riscv-platform-specs.

jjscheel avatar jjscheel commented on August 23, 2024

I see that these have now been included. Closing.

from riscv-platform-specs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.