Comments (7)
How about that in below? That actually means FW provides the GetTime implementation that works with the implementation-specific system date/time mechanism.
"Must be implemented by firmware and incorporated with the underlying system date/time mechanism."
from riscv-platform-specs.
No, changing "to incorporate with" to "and incorporated with" does not address my comment that that "with" may be grammatically wrong (or at least highly unusual). Nor does it make the sentence any more understandable to the reader.
I'm guessing what it intends to say is that GetTime() shall read the time from a chip-/system-specific RTC peripheral and return it. Neither of the two sentence variants makes that clear though. Even if we had a better verb, like I suggested, saying that GetTime() shall implement/expose/whatever "the underlying system date/time mechanism" is kind of non-explaining to the reader.
SetTime() below does not have such weird language and just says "must be implemented".
So why not just have GetTime() say "Must be implemented and is not allowed to return EFI_UNSUPPORTED."? That would avoid both the incorporation wording and the system mechanism wording and would leave the how-to to generic UEFI specs.
from riscv-platform-specs.
m guessing what it intends to say is that GetTime() shall read the time from a chip-/system-specific RTC peripheral and return it. Neither of the two sentence variants makes that clear though. Even if we had a better verb, like I suggested, saying that GetTime() shall implement/expose/whatever "the underlying system date/time mechanism" is kind of non-explaining to the reader.
The initial sentence was mentioned RTC as the underlying system date/time implementation. But we removed it to avoid the dependency of the specific hardware implementation. for Get/SetTime(), instead the current sentence is used.
from riscv-platform-specs.
I will leave the decision to @kumarsankaran, whether or not to simply says "Must be implemented".
from riscv-platform-specs.
How about this folks?
GetTime must be implemented by the firmware and is not allowed to return EFI_UNSUPPORTED
from riscv-platform-specs.
I have no problem with this. Thanks Kumar.
from riscv-platform-specs.
Fixed. Thanks.
from riscv-platform-specs.
Related Issues (20)
- Unnecessary/Inappropriate documentation of kernel address space decisions HOT 9
- Missing LICENSE file HOT 10
- RVM platform requirements HOT 1
- How to handle non-coherent I/O masters HOT 5
- Inconsistent mtime requirements HOT 1
- CLIC requires original basic interrupt mode HOT 1
- both CLIC and CLINT seems to be used for the same thing HOT 4
- Hypervisor guard hole HOT 4
- relax "If Hypervisor extension is supported then the misa.H bit must be writable." HOT 2
- relax RAS precise exception on uncorrectable data HOT 2
- Future interrupt controller of M platform
- Adopt the RISC-V documentation format HOT 1
- I/O ordering requirements (for non-PCIe devices) HOT 6
- Eventual completion for vacant memory HOT 17
- PCI ECAM requirements HOT 4
- Virtual timers require an offset value HOT 1
- PCI cache coherency HOT 4
- Specify word-size accesses to UART registers HOT 1
- A question about self/cross-modifying code (SMC/CMC)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riscv-platform-specs.