rise-vision/bootstrap-form-components

Bootstrap Font Picker jQuery Plugin

bootstrap-form-components's Issues

When initializing font picker with custom font, custom font name is not retrievable

@donnapep

if (currentFont === CUSTOM_FONT_TEXT) {
   var fontFamily = _getCustomFontName();

   utils.loadCustomFont(fontFamily, customFontURL, options.contentDocument);
}

_getCustomFontName is only a private function which means when initializing font picker with a custom font, there is no public API in retrieving the custom font name. Specifically, I am creating sample text to show the user their font selected and I can't apply a value for font-family without the custom font name.

Google Fonts popup list from Font Picker is blank

When I choose More Fonts from the Font Picker, the Google Fonts popup list is blank, although I can select fonts from the list by clicking in it - http://screencast.com/t/YBmllP9tPTCP

According to Alan Clayton, the same issue is occurring in the Financial Table Widget Alex built.

Rename repo to a more generic name

The font picker popup is cut off

Select custom font or More Font and you will see the top of the dialog get cut off within the Widget. http://screencast.com/t/oNf3xEhaMRK4

"customFontSelected" event returning empty "" for font family value

I'm listening for "customFontSelected" and the value of fontFamily being returned is an empty "". The URL value is returned with the correct value.

Add i18n support

Because we are going international, yo.

Gulp casperjs task doesn't work on Windows

Put font picker logic into its own folder

Gulp build task for CSS/SASS

Gulp CI process got stuck on failure

See output here:

http://devtools1.risevision.com:8080/job/Component-Bootstrap-Form-Components-PR-Tests/94/console

Gulp task for building CSS for each subcomponents

Currently we only have build task for generating all.css and all.min.css. Would be nice to also produce separate .css/.min.css for each subcomponent under the dist/ folder.

"googleFontSelected" event does not pass font name or font family

      $googleFonts.on("select", function(e, family) {
        addGoogleFont(family, true);
        $googleFonts.modal("hide");

        currentFont = $family.val();

        $selectBox.trigger("googleFontSelected", family);
      });

The event being triggered is passing family but this is a jquery object. For the purposes of what I need, I need the value from the function getFontStyle(). It could also be helpful to pass the font too via getFont()

Using a Custom Font is not saved in the Widget Settings

How it works now:

1. Select "Use Custom Font" from the dropdown, and enter the path to your font. Notice that the Sample Text updates to show your font.
2. Close and save the Widget Settings, and open them back up again, Notice that the Sample text is no longer using your custom font, and the Use Custom Font textbox is blank.

For further clarification: https://dl.dropboxusercontent.com/u/8237394/Screencasts/2014-10-30_1024.swf

How it should work:
The Custom Font should be saved in the textbox, as well as show in the Sample Text.

Originally logged as Issue 173 in widget-settings-ui-components.

Remove font-loader.j and replace with common.js

There is currently code in fontloader.js that is identical to what is already here - https://github.com/Rise-Vision/common/blob/master/scripts/rise/common.js. My question is, can we use the code from this repo instead of duplicating it in fontloader.js so that we don't have to maintain it in 2 places?

After selecting Times New Roman font and saving, it changes to show Custom Font as the selection

When I choose Times New Roman with the Font Picker, Save and then come back, it has changed to show Custom Font as the chosen font. I have tried to replicate it with a handful of other fonts in the list but have only seen this behaviour with Times New Roman.

See jing: http://screencast.com/t/oFfI7b5h

font-picker not working when you change selection

Hi,
I'm struggling to make this work for the past one week. I followed your guidelines as mentioned below:
http://rise-vision.github.io/style-guide/#/components/font-picker
Though, it missed mentioning dependency,risevision.widget.common.fontpicker, to be added to my angular module, somehow i found it in one of your other examples and added it. Now its loading the font dropdown but when i select it, i'm getting below script error:

TypeError: Cannot set property 'type' of undefined

It seems its not the issue with my application. Even your demo gives same error when you change dropdown:

Please help me out.

Need a more generic gulp build task for js

Currently each sub-component has its own gulp concat task. This is not ideal, as we have to manually add a new task each time we add a new sub-component.

A better approach would be auto detect all components based on what's inside src/js, iterate through all relevant folder names, and auto-build for each. Finally, create the all-encompassing all.js under dist/ in case people don't bother to to pick and choose what to include.

@stulees @donnapep FYI