rise-vision/widget-settings-ui-components

Various UI components shared across Angular-based Widget settings

widget-settings-ui-components's Issues

Table-Settings Fails to fully bootstrap on load

see https://www.youtube.com/watch?v=0uoXI0B1Xx8

source code: https://github.com/nexus-uw/widget-earnings-announcements/tree/b930f7a62fb2a6c5704850cd40200b5c132ec5dd

Color Picker allows alpha but always returns hex value

Color Picker allows a user to set an alpha value on the color, however in this line of code:

$scope.color = color.toHexString();

it does conversion on the user selection to hex string. This conversion only uses r g b values of what was configured. Whatever alpha value that was set is not included in the value stored.

No vertical space between buttons when they wrap at small resolutions

Example here - http://www.screencast.com/t/v7EnSMgJT

Using a Custom Font is not saved in the Widget Settings

How it works now:

1. Select "Use Custom Font" from the dropdown, and enter the path to your font. Notice that the Sample Text updates to show your font.
2. Close and save the Widget Settings, and open them back up again, Notice that the Sample text is no longer using your custom font, and the Use Custom Font textbox is blank.

For further clarification: https://dl.dropboxusercontent.com/u/8237394/Screencasts/2014-10-30_1024.swf

How it should work:
The Custom Font should be saved in the textbox, as well as show in the Sample Text.

Originally logged as Issue 81 in the Spreadsheet Widget repo.

The icons in the Widget Button Toolbar Buttons are larger than they are in the Style Guide

How it works now
As you can see from the screenshot, the icons showing next to the words in the Widget Button Toolbar buttons are smaller in the Style Guide than they are in the Widget, which results in them being a bit off center:

Overlapping settings in Column Selector and Table Settings

The table settings component and the column selector component have overlapping settings:

• there is width in column selector and colPadding in tableSettings
• there is alignment in column selector and alignment in header and data font settings in tableSettings

Column Settings Width value type should be a number

Since the the input's units are 'pixels', the input should be of type number. Having the input be a text input, the form is considered valid if the user inputs non-numeric or negative values

Scroll section does not have a title

How it works now:
Look at all the sections of the Widget (Spreadsheet, Columns, Table Format, etc), notice that each of them have a title, except Scroll:

How it should work:
The word "Scroll" should be removed from the body and should be the title of the section. If it can't be removed, we should include a title for this section to make it match the other sections.

Originally logged as Issue 78 in the Spreadsheet Repo.

Alignment in Column Setting instead of Table Setting

@alex-deaconu I'd previously removed alignment from Column Setting due to the conflict @nexus-uw raised about their being alignment in Table Setting and also Column Setting components. I thought it made sense to define it in Table Setting only. However, this was a mistake since we're no longer able to specify alignment on a per column basis for a data table.

I propose we add alignment back in to Column Setting and make Table Setting omit alignment for both column heading and data font styling.

@alex-deaconu @nexus-uw Agreed?

column settings attaches irrevalent properties to the model

For example, if the column is of type text, the following additional properties are attached to the column model

• colorCondition: "none"
• date: "medium"
• decimals: 0
• sign: "arrow"

No "None" choice for Sign selection in Column Setting

@alex-deaconu In the previous Spreadsheet Gadget, there used to be a choice "None" for Sign selection. In the gadget code, particular formatting gets applied based on that selection. Did you intentionally leave this out in Column Setting for a reason?

When entering a Custom Font URL, it doesn't update the font on the display

When I enter a URL for a custom font (http://s3.amazonaws.com/Robbs_Testing_Bucket/KaushanScript-Regular.otf) that Robb and Neal use successfully for testing, it doesn't update to show that font in my presentation:

http://screencast.com/t/RcnvthOeFPr

This font works when entered in the Clock Gadget, for example, and shows on a display.

test

test

"Select A Column To Add" should be changed to "Select Columns To Format"

How it works now:
When you add a Spreadsheet to the Widget, all columns show up. The "Select A Column To Add" section gives the impression that nothing is going to show up until you add them in this section, and that you can only add one column.

How it should work:
The title should be changed to "Select Columns To Format". This way the user knows that all columns will show up in the Presentation, but this is where they select the multiple columns they want to format for the Presentation.

Originally logged as Issue 75 in Spreadsheet Widget repo.

Custom font with spaces in name doesn't show in preview text of Settings

What is not working/What is currently happening:
When you enter a custom font that contains spaces in the font name it doesn't show in the preview text.

http://rise-vision.github.io/widget-settings-ui-components/#/font-setting

Custom font: https://storage.googleapis.com/risemedialibrary-a9dbdcf0-00c2-45c6-aa6e-14933558ec46/Presentation%20Assets/Trade%20Gothic%20LT%20Bold.ttf

What is expected to work/What is the client expecting:
The custom font displays in the preview text

Sample Text for Data shows incorrect alignment (should show left aligned, not centered)

The Sample Text for the data font shows it as being centered when it is actually left-aligned by default. Sample text for header font does reflect the alignment correctly - http://screencast.com/t/xE7lI3I1q1

Title gets cut off for both Custom Font and More Fonts (Google Fonts) popups from Font Picker

The title is cut off in the popups for both "Custom Font" and "More Fonts" (Google Fonts) - http://screencast.com/t/oNf3xEhaMRK4

mismatch between scroll configurations

The auto scroll plugin configuration and scroll settings components both use the same configuration parameters but there is slight differences between the two. This requires pointless conversion code between the settings page and widget page.

the scroll settings component provides

{
 by : "page",
 speed : "medium",
 pause: "5"
}

but the auto-scroll plugin uses

{
  scrollBy: "page",
  scrollSpeed: "medium",
  scrollResumes: 5
}

Also, note that scrollResumes is an int but pause is a string (purposed fix PR here)

Could @donnapep and/or @stulees decide on a standard configuration object and update the respective repo?

Thanks