rishikeshdarandale/apollo-datasource-soap

A simple implementaion of apollo datasource for soap requests

Rishikesh Darandale

I am full stack developer with more than 16 years of development experience. Mostly, my experience is with eCommerce web applications. Also, worked with few telecom based product in early career. I love contributing to open source projects.

I am passionate about code hygiene, design, user interface and security. Currently I am focusing and learning more about the serverless world.

I'm a hands-on Technical Architect who has design, built and maintain software products with small, medium engineering teams, and provided guidance at all the phases of software product. I'm not only motivated to use the latest and greatest technology, but also to product success and business growth.

---

apollo-datasource-soap's Issues

SSL Certificate Validation error despite rejectUnauthorized set to false

The Problem

An invalid server certificate on SOAP server closes the connection with a server certificate validation error. However, when setting rejectUnauthorized set to false, the same error persists.

Environment

• babel/node: "^7.6.3"
• apollo 2.9.7
• apollo-datasource-soap": "^1.1.7

Details

When connecting to a server with an invalid SSL certificate, apollo throws the expected validation error. However, in this particular case, it is a development server that only has a different domain name while still carrying the production server certificate so in this specific case, it should be sufficient to just disable the SSL validation, at least for testing purpose.

Expected behaviour

Usually, setting and http header should somehow disable SSL certificate validation.
For example:

request.wsdl_headers = {skipSSLValidation: true}
In some cases, a custom http agent should do the trick, like so:

async willSendRequest(request) { // override the soap endpoint for all requests request.endpoint = 'http://service.tws'; // these should be used for all soap calls request.agent = new HttpsProxyAgent({ rejectUnauthorized: false, skipSSLValidation: true }) }

Actual behavior

Despite having rejectUnauthorized set to false, it throws an invalid SSL error.

Question:

How do I disable SSL Cert validation for a Soap datasource?

Debug logs

Error:

 "Error: Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: service.mir.co.id. is not in the cert's altnames: DNS:mirbpm855v2.miroffice.com, DNS:www.mirbpm855v2.miroffice.com",...

Exception on empty response

The Problem

When received an empty response like the follow example:

<soap:Envelope> <soap:Body> <DocumentoFacturaByNumeroResponse/> </soap:Body> </soap:Envelope>

We received an empty response because there are 0 results.

invoke method throws a new ApolloError but it is correct? Maybe an empty response shouldn't be an Exception.

Environment

• node version 10.15.3
• apollo-server-express version 2.7.0
• apollo-datasource-soap version 1.1.6

Expected behaviour

An empty response without throwing an exception.

Actual behaviour

invoke method throws a new ApolloError

Debug logs

Error: Did not received the response from the endpoint
at WSInternoSoapDataSource.invoke
at process._tickCallback (internal/process/next_tick.js:68:7) extensions: { code: null } }

Cannot read property 'proxy' of undefined

The Problem

In short please describe the issue you are facing or a new feature that you want to include.

Environment

• node version
• apollo server version

Details

If necessary, please describe the issue/feature in more detail to help us understand the more!

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

Debug logs

It will be great, if the debug log of the issue is mentioned here in code block.

SOmething that will help to debug the issue
...