risingwavelabs/helm-charts

Helm Charts for RisingWave

helm-charts's Issues

Support OBS as a state store backend

Reference: risingwavelabs/risingwave#13844

Expose log level values

RisingWave writes alot of logs. I would like to reduce RUST_LOG level for each service however these values are not exposed.

TODO:

• Add RUST_LOG for each service to values.yaml

feat: upgrade operator chart to use v0.5.6 image

which contains critical bug fixes:

https://github.com/risingwavelabs/risingwave-operator/releases/tag/v0.5.6

Connector resource limits are incorrectly applied.

A connector container is scheduled into the same pod as the compute component as specified in the risingwave-compute statefulset.

The helm chart declares values for configuring cpu/memory requests/limits.

However these values are not used by the helm chart.

There are several issues:

• .values.metaComponent.resourceLimits.* are used in place of .values.connectorComponent here.
  • This means connector component is configured with resource specified for meta component rather than connector. This problem is made worse because compute component is preempted by the connector when under resource contention!
• In values.yaml a comment suggest connector should be scheduled into the same pod as both the meta and compute components. However the kubernetes manifests only schedule the connector container on the compute pod.

TODO:

• Update resource requests and limits reference for connectorComponent
• Either fix comment or schedule connector component on both compute and meta components

Network slowness on aliyun when pulling container images

The pod is pulling container image abnormally because there are other pods pulling it at the same time, which may block the current process. The pods's container images are [ghcr.io/risingwavelabs/risingwave:v1.3.0 ghcr.io/risingwavelabs/risingwave:v1.3.0 ghcr.io/risingwavelabs/risingwave:v1.3.0].

Pod my-risingwave-compactor-58d5c94d5b-jn99t 存在异常：拉取镜像超时

Add support for risingwave 1.5

RisingWave v1.5.0 should be supported: https://github.com/risingwavelabs/risingwave/releases/tag/v1.5.0

serviceAccount annotations are rendered as labels

When configuring serviceAccount for state store on s3 on eks infrastructure, if serviceAccount.create is true a annotation is used to associate the serviceAccount in eks with aws IAM role for accessing the state store bucket.

However the current helm chart renders the annotations as a label. This makes the serviceAccount resource manifest generated by helm invalid.

For example a rendered manifest will look like:

# Source: risingwave/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: risingwave
  labels:
    helm.sh/chart: risingwave-0.1.21
    app.kubernetes.io/name: risingwave
    app.kubernetes.io/instance: risingwave
    app.kubernetes.io/version: "v1.2.0"
    app.kubernetes.io/managed-by: Helm
    eks.amazonaws.com/role-arn: arn:aws:iam::1234567890123:role/s3/some-role

notice the eks.amazonaws.com/role-arn key should be a annotation and not a label.

This happens because the template has the following content

{{- if .Values.serviceAccount.create -}}
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ include "risingwave.serviceAccountName" . }}
  labels:
    {{- include "risingwave.labels" . | nindent 4 }}
  {{- $annotations := (include "risingwave.annotations" . ) | trim }}
  {{- if $annotations }}
  annotations:
    {{ nindent 4 $annotations }}
  {{- end }}
  {{- with .Values.serviceAccount.annotations }}
    {{- toYaml . | nindent 4 }}
  {{- end }}
{{- end }}

The problem is that the .Values.serviceAccount.annotations is being rendered directly under the metadata.labels section instead of the metadata.annotations section due to how the templating has been written.

Instead the template should be:

{{- if .Values.serviceAccount.create -}}
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ include "risingwave.serviceAccountName" . }}
  labels:
    {{- include "risingwave.labels" . | nindent 4 }}
  {{- $annotations := (include "risingwave.annotations" . ) | trim }}
  annotations:
    {{- if $annotations }}
    {{- nindent 4 $annotations }}
    {{- end }}
    {{- with .Values.serviceAccount.annotations }}
    {{- toYaml . | nindent 4 }}
    {{- end }}
{{- end }}

this will then render as:

apiVersion: v1
kind: ServiceAccount
metadata:
  name: risingwave
  labels:
    helm.sh/chart: risingwave-0.1.22
    app.kubernetes.io/name: risingwave
    app.kubernetes.io/instance: risingwave
    app.kubernetes.io/version: "v1.2.0"
    app.kubernetes.io/managed-by: Helm
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::1234567890123:role/s3/some-role