ritamsarmah/accelerate

Safari extension for video playback controls

accelerate's Issues

Add support for split video/audio streams

Description

Users have reported echo360.org has updated their video player. This has resulted in the extension controls no longer working correctly (supposedly due to them splitting their video and audio streams).

We will want to investigate adding support for these split A/V players, since some other websites use this implementation as well.

Steps to Reproduce

No response

Expected Behavior

No response

Accelerate Version

4.1.2

Operating System

macOS, iOS

Additional Info

No response

Global shortcuts do not work for all websites

Description

Original email:

I have the Accelerate extension for macOS 14.2.1, and I have mapped option+command+left arrow for a rewind global shortcut and option+command+p for PiP global shortcut. However, they only work when the safari tab is open, and I use it for YouTube. I tried the troubleshooting methods on the website, but to no avail[...]

Steps to Reproduce

1. Create a global keyboard shortcut, e.g., Skip Forward / Option + Command + P
   • Toggle Enable the global shortcut
2. Open in a website other than YouTube (e.g., Netflix) and play a video.
3. Switch to a different app and attempt to use global shortcut.

Expected Behavior

No response

Accelerate Version

4.1.2

Operating System

macOS

Additional Info

No response

Keyboard shortcuts don't ignore Reddit search bar

Description

Trying to enter something in the search bar using letters mapped to Accelerate shortcuts will incorrectly trigger the controls. This needs to be ignored by activeElementHasEditableText

Steps to Reproduce

No response

Expected Behavior

No response

Accelerate Version

4.1.2

Operating System

macOS, iOS

Additional Info

No response

Audio mutes when increasing speed

Description

When increasing playback speed on youtube, the audio mutes for a few seconds and then plays again. Happens all the time.

Steps to Reproduce

Open youtube and adjust playback speed.

Expected Behavior

Video speed increases without muting.

Accelerate Version

4.2.0

Operating System

macOS

Additional Info

13in M2 MacBook air. MacOS 14.3.1. Safari 14.3.1 19617.2.4.11.12.

Round playback rates to two decimals

Feature Description

Certain websites display the current playback rate in the video player as-is. I configured the speed up/down actions with a 0,1 step. In JavaScript, floating point operations are subject to round errors and result in long numbers which may not fit in a video player (see the screenshots for an example, the one with normal playback rate is for reference)


I suggest to apply a .toFixed(2) to the numbers after playback rate deltas addition. I'd do it myself but I'm not sure if changing JS files is enough for a Safari extension (I don't have XCode installed)

Operating System

macOS