riyadhalnur/node-base64-image

Download images from remote URLs or use local images and encode/decode them to Base64 string or Buffer object

node-base64-image's Issues

Make a new release with all of the dependency updates.

• node version: 12.14.1
• npm version: 6.13.7

Error output

  High            Prototype Pollution                                           
                                                                                
  Package         lodash                                                        
                                                                                
  Patched in      >=4.17.12                                                     
                                                                                
  Dependency of   node-base64-image                                             
                                                                                
  Path            node-base64-image > lodash                                    
                                                                                
  More info       https://npmjs.com/advisories/1065    

More details

The fixes have already been merged on master. We just need to make a release for it on NPM.

Question - How can I get a wrapped version of base64?

Currently it returns base64 encoded string of an image. It is a long line of a string. In MIME types the base64 encoded strings are wrapped at 76 characters. Any option to directly get that?

For example, there are multiple types of base64 encoded strings. You can find those in the Android Base64 class here. Is there any way to directly get any type of base64 (like wrapped or unwrapped)? If not, any plans to include that?

Error not returned from base64encoder if image doesn't exist

I have encountered this issue when encoding some images from a URL.
I was trialling your component and iterating over an array of images URLs.
The number is encoded strings I received was one less than the number of items in the array.
No error was reported but I found that my source array had a misspelling on one of the images.
The path was correct, the filename was not.

decode adds extension to filename

decode automatically appends an extension to the filename, hard-coded to '.jpg'. This is not a safe assumption to be made as either an extension may already be provided and/or the contents may not be a jpeg image.

local files url not accessing

• node version: 10.23.0
• npm version:6.14.8

Error output

ECONNREFUSED

im trying to encode image from local url
const url = 'file:///C:/Users/'my pc user name"/Desktop/ImageDecordEncorder/src/assets/images/example.jpg';

working fine with global url

Support for callback and promises

The title is self explanatory. Essentially, all methods will support promises and callbacks. Enables users to use what suits them best. I don't it's right to enforce a single style in this case. Usability over readability.

Example code

As @josephrocca pointed out in #18, it would be nice to have example code.

using http auth in url

• node version: 10.11.0
• npm version: 6.4.1

Error output

Error retrieving image - Status Code 401

More details

This module seems not to work with http auth urls, like below. Whenever call such url i will get the error above.

http://user:[email protected]/image.jpg

Custom headers?

Unless I'm mistaken, you can't pass in custom headers for http requests? Because of this issue I couldn't use this library. maybe other people are in the same boat. Just a heads up.

Cheers

Trying to get in touch with you regarding a security issue

Hi there,

I couldn't find a SECURITY.md in your repository and so am not sure how to best contact you privately to disclose the security issue.

Can you add a SECURITY.md file with your e-mail to your repository, so that I know who to contact? GitHub suggests that a security policy is the best way to make sure security issues are responsibly disclosed.

Once you've done that, please let me know so I can ping you the info.

Thanks! (cc @JamieSlome)

Converting to base64 works fine in development, not in production

• node version: 8.11.1
• npm version: 5.6.0

Error output

This is the base64 string for an image in development

iVBORw0KGgoAAAANSUhEUgAAArgAAAOECAIAAADFbdUaAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyZpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuNi1jMTExIDc5LjE1ODMyNSwgMjAxNS8wOS8xMC0wMToxMDoyMCAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wTU09Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9tbS8iIHhtbG5zOnN0UmVmPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvc1R5cGUvUmVzb3VyY2VSZWYjIiB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC8iIHhtcE1NOkRvY3VtZW50SUQ9InhtcC5kaWQ6RDcxRTdEOEUzMUE0MTFFNkI0RTA4NTlCQTQ5MkNFMjMiIHhtcE1NOkluc3RhbmNlSUQ9InhtcC5paWQ6RDcxRTdEOEQzMUE0MTFFNkI0RTA4NTlCQTQ5MkNFMjMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENDIDIwMTUgTWFjaW50b3NoIj4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6MUM4NDE2MzIzMDA4MTFFNkI0RTA4NTlCQTQ5MkNFMjMiIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6MUM4NDE2MzMzMDA4MTFFNkI0RTA4NTlCQTQ5MkNFMjMiLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz5B8FHiAAJY3UlEQVR42uy9CbhdRZU2XMMeznjnm5uRDASSEKaEGUFkVmR0gEaku8X+wLltW23/1rafbtun29ZWu3+1H0RRUPpzxAkFZXAAmZOQBEggAyFzbnLne4Y91v/WXrnbI5LvN34BMqz3CYd99qldw6q6td61alVtObhormAwGAwGg8F4MSgWAYPBYDAYDCYKDAaDwWAwmCgwGAwGg8HYd3Bav3QuXcMSYTAYDAbjEMfQ4iPya/YoMBgMBoPB2COYKDAYDAaDwWCiwGAwGAwGg4kCg8FgMBgMJgoMBoPBYDCYKDAYDAaDwWCiwGAwGAwGg4kCg8FgMBgMJgoMBoPBYDCYKDAYDAaDwWCiwGAwGAwGg4kCg8FgMBgMBhMFBoPBYDAYTBQYDAaDwWAwUWAwGAwGg8FEgcFgMBgMBhMFBoPBYDAYTBQYDAaDwWAwUWAwGAwGg8FEgcFgMBgMBhMFBoPBYDAYTBQYDAaDwWAwmCgwGAwGg8FgosBgMBgMBoOJAoPBYDAYDCYKDAaDwWAwmCgwGAwGg8FgosBgMBgMBoOJAoPBYDAYDCYKDAaDwWAwmCgwGAwGg8FgosBgMBgMBoMhnAOlosaYfZKPlHKv8t/b9Htb7oEuh31Vz/2tX14pOb9S8tlX45PBYLBHgcFgMBgMBhMFBoPBYDAYjJdn6cFMQEoZx7Hnef39/YVCCXeSJMHXRqOBT6QsFAq+746P1yuVEr42GkGx6IchHnFwE8+Wy2UkxoMdHW1IkCRG690u02YzDIIARaRpigT4LBaL4+PjruviolDwkBjJtBZBEDWbTaRE6b7v1+t1x3GoelkCXa2WcbF9ez+Kw01kG4ZhT0/P4OBgR0dHrVbr6upA8iiKqLbIDTkopahFAK7b29vRzMmTJ9PXKApRB2Q7NlajNHikra0ahannWbqWpLYtuI8K4Gsch0iAJqO2KN1xPAjHdTXJcHR0FBcQGmpIzmTcHBkZwZ22tjakxwVJA7VFAmSFNNQcVIYkBhHhGp+4ibbgkYGBAdf10ZxJk3riOEWbSMKjo+NIA2FOmdJXrzdLpcLIyBjqiUKROR5EiZAzPlHE0NBQV1cXCkECEikahVJwHzJB90GG+ESn5NUIbCMNblYqlXLFj6JEyt11FplXfOvWreVyFfmUS1W0Hb2mtKB2oc7Tp09FBlRD5FetVlEZ1A0507hC0WgpnoIM0d24QN2o+fiVBlg+zFBKNjYi1BApUQqSUUvRQFzgK4rIm0BjG5x7eHg4GzzVbOg2kJiKQCUhXhSNZuITybq7u6lEagt+RbKJcYJB5SMT5Elje3BwmCSMUYfuUMoKFQVCqKgMCrJiKZdR2YGBITQchUKMjiPxlYZBqVRCSmsWZA/TwEBNUASKQ869vd0kB+oy1BBNg6C6ujrRPhoeyHnbtm3oWdzv7OzkqZPBYKKwz0BzJeYa0sS4Xrp06c0335ymwsuASRxzFma67du3L1q06K/+6q/AEqBNoa0x90FnYEpds2bdT37yk02bNmFiRZ5z5849//zz582bh+ksSUSmX83PMuBXTIuYmjPl6qB0fJ555pmHH374sccejekVGSLZXXfdhYmPNHE2I1u1QaoO2b7zne+EyvniF7+IGdPKyHFoEkca6N2ZM2dec801hx8+2/Nc1PMb3/jG8uXLKSvUhxTD2NgYEuPOJZdccumll2Za01u9+tlnnnnmF7/4BX6CJkAa/LTwqGMOO2xqFBnXk5lutiwhm5dthijuox/9h4whVVGruXPnoLa33Xbbb37zG2RywQUXvPGNb6QSP/vZz0KA4Aof+chHjjzySGQCffOd73zn/vvvR0pSElddddWcOXOmTp1KSi7XlOgXSADPfu1rX3v22bVQ5H//938PKpbzsK985StPPfUU7r/nPe+ZPXsm7t94443r1q1DxxHPIIIFhkFf3/KWt7z61WfQAAgzfOELX9iyZQsSQMe84Q1vOPXUU3ETzUS/I83atWs/8+nPQ7295jWvueTS1xOjIoaBT1Tsy1/+MsiKpXdCU7cmaSQmVtzf+973otfuvfde9AWevfLKK88777ycZ0BW3/zmN9FS3LzsssswPH5/fO7OBHkuW7b84YcfRkszuhlDUKgPqgrNCmGivz74wQ/iJyhLDICFCxfSU3gcHXTzzV9fsWIFxieEjH75l3/5F9BEkDY0IR/5aDLxquuvv37hwgW//OUvb7/9dsgNmVMC6GBUD3wUOfzZn12J/HfuHPjc5z6HO729vZdffvkJJyzCIFEWGJbq+9//0UMPPbRr1y4MswsvvPA///M/octR6Gc+82lo/f/5n/958sknMaqRDz6J6NA4h+Qvvvhi1BDtRV4YM7NmHYY/NKR8+OFHsz9Py7He9ra3nXTSCWgdhLlhwwbUZMeOHajb1VdfnfM8BoNx0OMlX3rI7VeyaTDjYFrE1I9PzL9kZSINFDMmuFWrVmGuh1VHNj3mRMx0X/7yV/7pn/4JLAFpMD0hPdTtTTfdBO31wAMPTGgpSRfIBPMg5nRMc/jENA1lf8cdd4AZkEcBRjmKgwKm9MgTcyIRBVLMSI80nZ3teBxpSEPggqxJUqhQkxs2bEQGqCdZdU4GzL9oFH1FBSgxBDA0NPK///e3Mf/+9Kc/JbWEPJH4u9/97le/+tWbb77VdWUmHEVah5wK5JY4/fTTcbF582bM6bCbcfHEE0+gPn19fWeccQZKIVYEnY2y8CDULZ5FQ5A5SAmeRX0gE1QMZf33f/83cqBZnrqGvCB4EGURaSOHBISfOT4MKWyy0SENegRSgsRIw5FVijRQcvlP1N307LPPPos64yeUC6326KOPUhHEEohMIB/UMyvCywePzoCnkCeUKOpATiDqO/IWBBmI0BBxIbMYKVEx0pEkEAiKruknlEVExPfd5ctX3pgBnI/UOSqDIXfrrbd+5jOfgTJGtqjta1/7WuT83HPPgUxQMpIh5LZs2TKUC75y8skng6xAtUOeMgONHOKRlBj1JDqIUsgHhgaSlwttAYn8+c9//v3v/wBdAFv/pJNOQs3Xr1//2GOPIaes46z/DMzpzjvvRLbgEGeddRaIHWgKxn/Wdqh5B19RBDqFCqIewVeMeQgTlQe3IN4AOaAsok1IgAqDz+ER1IRYAjl1kBijDg1klsBgMFF4SUCaJvfckl6BoY9JE18nT55MTlfo/u9///vQiPQUlAqmadhwAwMDmBCnT5+O+RePIB/QhbvvvpvmeqIgZGtirpwxYwayOvroo5H+sMMOw5yIaQ4GHHQ0plrUBJM+qeHZs2dPmTIF+aMCyB+2OKZCTJpkt2F+xPSNSiINfkViWNVQdZhDYeMODAyh3O7ubpie+MSvRCzQEHxF5ngEn0gD3XzPPfdg4sYc3dPTgwwxEeMp1Bbt+u1vf/vkk6upyfnSA6leXMA6ByFAox588EGoKOSDWR71f+c734laEQNDi5AtmoBnUTqyhRhBSlAZ8IZPf/rTH//4x2FPIxn0DegC0SNy81BxRF+QnhwAZCtD2WQ8ICHFRn2HeoLQ2DWCcpm80BDytGnT2jPMnDkTypLoC2UCpbJ27VpIFU1APvgJWhakh/RWpqLsahTpntQCxMVAX+Y8Ay1CS9E66ikIn4YQ8oScZ82ahYEEDUdrDVJqGtVoF4hB1jQY6w7SkEomJgFREJMjHvvrX/96zZo1JDq0BXli2KAUJEBtH3nkEdQHX/ET0qCq5K+C0DA8SDKoJ2nWSZMmjY3VMl+X9SWghsiKxi1kdViGjGQIIi6oFfpu7ty5UzJggIFE4hNcATwAmWNMguVA2qhM

This is the base64 string for the same image in production

PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICA8bGluayByZWw9InN0eWxlc2hlZXQiIHR5cGU9InRleHQvY3NzIiBjbGFzcz0iX19tZXRlb3ItY3NzX18iIGhyZWY9Ii81MzFhNDU1YjBiYjJjOWQxOTBjMGFhMjY2MzliNDc4ZWJmMGM1YWQ0LmNzcz9tZXRlb3JfY3NzX3Jlc291cmNlPXRydWUiPgogIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgdHlwZT0idGV4dC9jc3MiIGNsYXNzPSJfX21ldGVvci1jc3NfXyIgaHJlZj0iLzJmNDQ1NGY2MzY1N2NiOTViOTY5MzkxOTExODkwOGNmMTkyZDlkN2YuY3NzP21ldGVvcl9jc3NfcmVzb3VyY2U9dHJ1ZSI+CiAgPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiB0eXBlPSJ0ZXh0L2NzcyIgY2xhc3M9Il9fbWV0ZW9yLWNzc19fIiBocmVmPSIvZWU2OGJiODA4ZmE3ZjFiNGM3OTVmY2E3NzRmNWMxNmM0ODhhZjJjMS5jc3M/bWV0ZW9yX2Nzc19yZXNvdXJjZT10cnVlIj4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iaHR0cHM6Ly9qcy5zdHJpcGUuY29tL3YyLyI+PC9zY3JpcHQ+Cgk8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJodHRwczovL2NoZWNrb3V0LnN0cmlwZS5jb20vY2hlY2tvdXQuanMiPjwvc2NyaXB0Pgo8bWV0YSBjaGFyc2V0PSJVVEYtOCI+CgogICAgPHRpdGxlPk1lZGljIG9uIERlbWFuZDwvdGl0bGU+CgogICAgPG1ldGEgbmFtZT0iYXBwbGljYXRpb24tbmFtZSIgY29udGVudD0iTWVkaWMgT24gRGVtYW5kIj4KICAgIDxtZXRhIG5hbWU9ImF1dGhvciIgY29udGVudD0iT25lQkksIHd3dy5vbmViaS5ldSI+CiAgICA8bWV0YSBuYW1lPSJkZXNjcmlwdGlvbiIgY29udGVudD0iTWVkaWMgT24gRGVtYW5kIj4KICAgIDxtZXRhIG5hbWU9ImtleXdvcmRzIiBjb250ZW50PSJtZWRpYywgbWVkaWNpbmUsIGhlYWx0aCI+CiAgICA8bWV0YSBuYW1lPSJyb2JvdHMiIGNvbnRlbnQ9ImluZGV4LCBmb2xsb3ciPgogICAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwgbWluaW11bS1zY2FsZT0xLjAsIG1heGltdW0tc2NhbGU9MS4wLCB1c2VyLXNjYWxhYmxlPW5vIGluaXRpYWwtc2NhbGU9MS4wIj4KICAgIDwhLS08bGluayBocmVmPSIvY2xpZW50L2xpYi9zZWxlY3QyL3NlbGVjdDIubWluLmNzcyIgcmVsPSJzdHlsZXNoZWV0IiAvPi0tPgogICAgPCEtLTxzY3JpcHQgc3JjPSIvY2xpZW50L2xpYi9zZWxlY3QyL3NlbGVjdDIubWluLmpzIj48L3NjcmlwdD4tLT4KICAgIDxsaW5rIHJlbD0iaWNvbiIgdHlwZT0iaW1hZ2UvaWNvIiBocmVmPSIvaGVhbHRoLWljb24uaWNvIiBzaXplcz0iMzJ4MzIiPgoKPC9oZWFkPgo8Ym9keT4KCgoKICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+X19tZXRlb3JfcnVudGltZV9jb25maWdfXyA9IEpTT04ucGFyc2UoZGVjb2RlVVJJQ29tcG9uZW50KCIlN0IlMjJtZXRlb3JSZWxlYXNlJTIyJTNBJTIyTUVURU9SJTQwMS41LjIuMiUyMiUyQyUyMm1ldGVvckVudiUyMiUzQSU3QiUyMk5PREVfRU5WJTIyJTNBJTIyZGV2ZWxvcG1lbnQlMjIlMkMlMjJURVNUX01FVEFEQVRBJTIyJTNBJTIyJTdCJTdEJTIyJTdEJTJDJTIyUFVCTElDX1NFVFRJTkdTJTIyJTNBJTdCJTIyTG9nZ2VyJTIyJTNBJTdCJTIyZmlsdGVyU2V2ZXJpdHklMjIlM0ElNUIlMjJJTkZPJTIyJTVEJTdEJTJDJTIyZG9jdG9yc1BlclBhZ2UlMjIlM0E0JTJDJTIyc3RyaXBlJTIyJTNBJTdCJTIydGVzdFB1Ymxpc2hhYmxlS2V5JTIyJTNBJTIycGtfdGVzdF9wdFBvdXpvS0hsTlZldUtrMjVJSjNyOFklMjIlMkMlMjJsaXZlUHVibGlzaGFibGVLZXklMjIlM0ElMjJwa19saXZlX2ZFUmtqdm5Venlqem9xVUxyY1lDRHR4YiUyMiU3RCUyQyUyMmNhcHRjaGElMjIlM0ElN0IlMjJzaXRlS2V5JTIyJTNBJTIyNkxlbERnY1VBQUFBQU84cWljV2dDb1BjLThsa2JUUFdmMjQ2UjViTiUyMiU3RCU3RCUyQyUyMlJPT1RfVVJMJTIyJTNBJTIyaHR0cHMlM0ElMkYlMkZkZXYubWVkaWNvbmRlbWFuZC5jb20lMkYlMjIlMkMlMjJST09UX1VSTF9QQVRIX1BSRUZJWCUyMiUzQSUyMiUyMiUyQyUyMmFwcElkJTIyJTNBJTIyMTE4cHNnZzFwcXp5N2R5MTBuM3QlMjIlMkMlMjJhdXRvdXBkYXRlVmVyc2lvbiUyMiUzQSUyMmY2NTU2NGE3MmZiOTEzNzZiNjZiY2ZlZmFhODc4ZjQxMTg4YTEwNTclMjIlMkMlMjJhdXRvdXBkYXRlVmVyc2lvblJlZnJlc2hhYmxlJTIyJTNBJTIyYjYyYTJmNmZhODNiNWQ0YWU4ZGJkMTVkZTNlOTRiMzYzMTEzN2Q5NiUyMiUyQyUyMmF1dG91cGRhdGVWZXJzaW9uQ29yZG92YSUyMiUzQSUyMm5vbmUlMjIlMkMlMjJhY2NvdW50c0NvbmZpZ0NhbGxlZCUyMiUzQXRydWUlN0QiKSk8L3NjcmlwdD4KCiAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iLzE2OTk1ZTE1ZjdjYTBiYWE2YWFiODY1YWQxNjk3ZjNiNzk2ODcwMzQuanM/bWV0ZW9yX2pzX3Jlc291cmNlPXRydWUiPjwvc2NyaXB0PgoKCjwvYm9keT4KPC9odG1sPg==

More details

I use this package in Meteor.js and on the server side, I'm trying to convert the file to base64 string. This, eventually works fine in development and doesn't work in production. Here's the code:

    import { encode, decode } from 'node-base64-image';

    encode(fileUrl, { string: true }, (error, result) => {  // Encodes a remote or local image to Base64 encoded string or Buffer
        if (error) reject(error);
        if (result) resolve(result);
    });

Invalid URI when calling base64.encode

• node version: v6.10.2
• npm version: 3.10.10

Error output

 Error: Invalid URI "//cdn.macrumors.com/article-new/2016/01/iOS-9-Siri-250x213.jpg?retina"
    at Request.init (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\node-base64-image\node_modules\request\request.js:275:31)
    at new Request (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\node-base64-image\node_modules\request\request.js:129:8)
    at request (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\node-base64-image\node_modules\request\index.js:55:10)
    at Object.encode (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\node-base64-image\dist\node-base64-image.js:63:27)
    at Promise (C:\Users\acer\OneDrive\Projects\newsfeed\lib\post.js:48:14)
    at tryCallTwo (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\promise\lib\core.js:45:5)
    at doResolve (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\promise\lib\core.js:200:13)
    at new Promise (C:\Users\acer\OneDrive\Projects\newsfeed\node_modules\promise\lib\core.js:66:3)
    at share (C:\Users\acer\OneDrive\Projects\newsfeed\lib\post.js:45:12)
    at Timeout._onTimeout (C:\Users\acer\OneDrive\Projects\newsfeed\share-test.js:45:18)
    at ontimeout (timers.js:380:14)
    at tryOnTimeout (timers.js:244:5)
    at Timer.listOnTimeout (timers.js:214:5)

More details

Error thrown when callin base64.encode passing an URI containing upper cases letters

Is node-base64-image written in typescript?!?!?

• node version: n/a
• npm version: n/a

Error output

I am curious: https://github.com/riyadhalnur/node-base64-image/blob/master/src/node-base64-image.js#L27

type Callback<T> = (err: ?Error, x?: T) => void;

export function encode(url: string, options: Object = {string: false, local: false}, callback: Callback<mixed>) {

More details

The code pretty much looks like TypeScript!

But there is no tsconfig.json in the repo, or am I blind? And the code is in a .js file (not a .ts). So what is this?!? I am curious!

ES6 Rewrite

The code as it stands is a bit clunky and all over the place. With a move to ES6, hopefully, the code will be modular and cleaner.

I have started work on this in a separate branch named es6-rewrite which will be merged into master once everything's good to go.

incorrect code in examples

Hi
Thank for you module.
But correct your examples code please.

Ex.1

var options = {string: true}

base64.base64encode('www.someurl.com/image.jpg', function (err, image) {
if (err) { console.log(err); }
console.log(image);
});

MUST

var options = {string: true}

base64.base64encoder('www.someurl.com/image.jpg', options, function (err, image) {
if (err) { console.log(err); }
console.log(image);
});

Ex.2

base64.base64encode( --> base64.base64encoder(

new version to fix vulnerability

if I npm install this package, the following deps get installed as well:

`-- [email protected] 
  +-- [email protected] 
  `-- [email protected] 
    +-- [email protected] 
    `-- [email protected] 

https://nodesecurity.io/advisories/130 advises to upgrade to tough-cookie 2.3 or higher, which [email protected] does.

Although the package.json file was updated to use [email protected], it seems like the npm version itself wasn't (still 1.0.1) so the npm install is still using the 2.72 version of request

Could you publish a new version to fix this vulnerability ?

Thanks

Unit tests in ES6 and coverage

Move all unit tests to ES6 as well and introduce coverage reporting.

decode

encode outputs either a string or a buffer, while decode only accepts buffers - it should also accept a string for consistency.

Fix server side request forgery vulnerability

• node version: latest lts
• npm version: latest lts

Error output

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Server-Side Request Forgery                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ axios                                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.21.1                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ node-base64-image                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ node-base64-image > axios                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1594                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

More details

Should be simple enough, run npm audit fix and publish the patch.

The latest merge to master hasn't been released (axios high security issue)

Hello! I've noticed the latest merge to master (aed7f24) solves the high security issue on axios, but it hasn't been released.

Could you please release it to us, so we can use this package with no security issues?

Thanks!

convert img to base64

• node version:10
• npm version:"^2.0.1"

I need to convert images to base64. When I do it from my local machine, in debug mode it works perfectly, but when I run the function on GoogleCouldPlatfom, it fails.
Can you please tell me if there are any dependencies or what should I do to make it work ?

let filename = "https://images.nwgmedia.com/Media.aspx?fileId=219135";
const options = {
string: true,
headers: {
"User-Agent": "my-app"
}
};
const base64EncodedImageResponse = await encode(filename, options);

{ Error: Parse Error}

[Suggestion] Return metadata

Hi, I'm using this lib for about 4 months now and the only thing I guess could be improved is a new option param that returns the base64 string + some metadata such as format, maybe its size (width/height), etc.

The format I guess that it's possible to get on the Axios request itself, and the size would be possible to get using something such as probe-image-size.

That's all, cheers.

const response = encode(url, {
    metadata: true, // it could be a better naming fore sure 👍 
})

console.log(response)
/*
 * {
 *     data: <base64>,
 *     format: <jpg, png, etc>,
 *     width: <number>,
 *     height: <number>,
 * }
 */

How to sync convert base64

How to sync convert base64
I need to convert batch images to base64

Support image decode and encode to be rendered as an image source in an image tag

Can you support directly decoding an image from a image tag source and also encoding a base64 data from a data base to render directly as a source in an image tag

Public facing API update

At the moment, the 2 main methods are base64encoder and base64decoder. It makes more sense to rename them to encode and decode respectively.

Error: Cannot resolve module 'fs'

• node version: 9.3.0
• npm version: 4.6.1

Error output

Module not found: Error: Cannot resolve module 'fs' in E:\R\exclusivi-dashboard\node_modules\node-base64-image\dist

Using it in browser, with webpack-dev-server

dependency to lodash 4.17.11 presents high vulnerability

More details here: https://github.com/lodash/lodash/issues/4348

Fix: Should increase lodash version to latest.