rizumita/ctfeedbackswift

Feedback mail composer for iOS re-written in Swift of CTFeedback

ctfeedbackswift's Issues

Bug: Attachment selection

the plug-in works but is not showing permission to the user to use camera or library. NSPhotoLibraryUsageDescription & NSCameraUsageDescription are set on info.plist - app getting rejected :/ (device used iPhone 7 iOS 12.1.1)

Add new Platform Names

Hi,
can you add the Platform Names for new devices?
Or is possible to use the lib "Device Kit"? https://github.com/devicekit/DeviceKit

Present CTFeedbackSwift modally

Hi,
at the moment if you present modally there isn't the "send" button.
Is there a possibility to add the compatibility to present che view controller modally?

Thank you

Pod support?

Hi, great work?
Any plan to support pod in the near future?

Mac Catalyst support

Do you plan to support MacOS apps written with UIKit/Catalyst and detect the OS listed as such? Thank you. I am just trying out this library which looks pretty great.

CTFeedbackSwift support swift 4.2

Hello, thank you for your lib but really need support swift 4.2

thank you

iPhone X, Xr and max

Hi,
can you add support for new iOS device?

Feedback Generation Error when "hidesAppInfoSection: true"

If you sethidesAppInfoSection: true like so:

let configuration = FeedbackConfiguration(toRecipients: ["[email protected]"], hidesAppInfoSection: true, usesHTML: true)

You have Feedback Generation Error when pressing the Send button.

Delegations like MFMailComposeViewControllerDelegate?

I need delegates like in MFMailComposeViewControllerDelegate to handle few events based on users action with CTFeedbackSwift. Is it already implemented? If no, do you mind providing this feature at your earliest?

TopicViewController height

Hi,
Is it possible to change the height of the TopicViewController?

How to validate if I will able to send a message in advance before opening FeedbackViewController?

Is there something like MFMailComposeViewController.canSendMail() { ... } from your library?

I don't want my user that they will get to know that he can't send me an email because he has not setup mail account in his phone after he filled-up everything.

iPadでAttachmentCellを選択すると落ちます

iPadで「フィードバック添付画像を選択」をタップすると落ちます。

func showAttachmentActionSheet(deleteAction: (() -> ())?)で

        alertController.addAction(UIAlertAction(title: CTLocalizedString("CTFeedback.Cancel"),
                                                style: .cancel))
        
        let screenSize = UIScreen.main.bounds
        alertController.popoverPresentationController?.sourceView = viewController?.view
        alertController.popoverPresentationController?.sourceRect = CGRect(x: screenSize.size.width/2, y: screenSize.size.height/2, width: 0, height: 0)
        alertController.popoverPresentationController?.permittedArrowDirections = .init(rawValue: 0)

        viewController?.present(alertController, animated: true)

だと、とりあえず回避できました。

You are forcing mail through the mail app not the default app selected

We have a lot of users that use third party mail apps, and you are forcing this through the default ios mail app and not using the SELECTED default app.

This is a huge problem.

Xcode 13 Errors

Xcode 13 (beta 3) throws an error when calling UIApplication.shared.openURL(url). This seems to break using CTFeedbackSwift with SPM.

From the docs:
@Property(class, nonatomic, readonly) UIApplication *sharedApplication NS_EXTENSION_UNAVAILABLE_IOS("Use view controller based solutions where appropriate instead.");

Problem with large title and tableview

Hi,
if you present the CTFeedback controller from a navigation controller with large title, the fist section of the table view, probably, has the height set to 0 (or more probably has no title).
This cause the problem that you can see in screenshot below:

How to open Feedback View Controller with only 1 topic?

I don't want my users to choose a topic after they select "Feedback".

Instead I want to provide an option like:

"Question"
"Feedback"
"Report Bugs"

... and on behalf of them, I would like to set default topic as per the user selection of an item.

I couldn't find my self how to do it? Can you help?

Enabling/disabling photo attachment

Hello,
it would be possible to add the possibility of enabling/disabling the possibility of attaching images (from roll or camera) to the feedback email

Bug: Camera permission

Hello,
thanks for nice plugin there is small on selection camera

thank you

Device name does not appear when it's installed via Swift Package Manager.

We can see device name like "iPhone14,2" at Mail compose screen if CTFeedback is installed via CocoaPods.
But we can never find if it's installed via SPM.

Xcode 12 warning

Hi,
when i add with SPM the library, after a buil xcode tell me this warning:

found 2 file(s) which are unhandled; explicitly declare them as resources or exclude from the target

/Users/marcor./Library/Developer/Xcode/DerivedData/Quiz_Patente_Nautica²-artbtxmikkngezdmetqktnqpnidv/SourcePackages/checkouts/CTFeedbackSwift/CTFeedbackSwift/Info.plist
/Users/marcor./Library/Developer/Xcode/DerivedData/Quiz_Patente_Nautica²-artbtxmikkngezdmetqktnqpnidv/SourcePackages/checkouts/CTFeedbackSwift/CTFeedbackSwift/Resources/PlatformNames.plist

Please send device name like "iPhone 13 Pro" but not "iPhone14,2"

iPhone 13 mini
iPhone 13
iPhone 13 Pro
iPhone 13 Pro Max
iPad mini (6th generation)

and other new devices.

min iOS version

I was wondering, why does this pod min iOS version is 9.0? I think 8.0 should be fine.
If it is possible, to have the min iOS version set to 8.0 please?

image menù is misaligned on ipad

Hi,
on ipad, when you try to add an image to the feedback, the menù is misaligned.
the actionsheet should be in popover pointing with the arrow on the touched cell (the one for attached images)

SPM support

Hi,
can you add support for swift package manager?

thank

Apple Rejection on MacCatalyst

When using MacCatalyst, the platform returns x86_64. In FTFeedback, that returns the string Simulator which Apple reject since they're not testing on the simulator.