rlaphoenix/pvsfunc

PHOENiX's compilation of VapourSynth Script's and Functions

pvsfunc's Issues

Document script dependencies and type annotations

It would be helpful for the documentation to include a line about installing vapoursynth script dependencies with VSrepo, or just linking them in the readme in general. It was helpful to link the script repository links in the error messages, but still a little frustrating to run the script and find a new dependency to install each time.

vsrepo intall mvsfunc havsfunc d2v lsmas

You may also want to consider adding type annotations to some of the methods like PDeinterlacer.VoidWeave. For example, if called through PDeinterlacer(clip, kernel=PDeinterlacer.VoidWeave), this results in an error.

TypeError: VoidWeave() missing 1 required positional argument: 'color'

From this error I had to dig through the source to see what you expected the argument to look like. I was surprised when I couldn't even find an example from VSMPEG/config.example.yml. I'm assuming from the docstring for VoidWeave that the color is supposed to be RGB green though, so maybe the type annotation could look like this.

VoidWeave(cls, clip, tff: int, color: float[] = [0, 255, 0], bob=False) -> VideoNode

I'm kind of new to using VapourSynth so I don't know if the type annotations I gave are 100% accurate, or what the type should be for clip, but hoepfully this helps. TFF is supposed to be a boolean integer, right?

AttributeError: 'PSourcer' object has no attribute 'set_output'

Maybe I'm just using it wrong, but I assume it should be used like any source filter?

With clip = PSourcer(r"f:\ep1_1.vob", debug=False) I get this error AttributeError: 'PSourcer' object has no attribute 'set_output'

The d2v is correctly generated. All modules installed via pip.

Windows 10 x64
VS R52
pvsfunc 3.15.4

import vapoursynth as vs
core = vs.core
from pvsfunc import PSourcer

clip = PSourcer(r"f:\ep1_1.vob", debug=False)
clip.set_output()