rmasters/culpa

A Blameable-type extension for Laravel's ORM Eloquent.

culpa's Issues

Consider breaking each blame-type into a separate trait

So the idea would be to have:

class Post {
    use Culpa\CreatedBy;
    use Culpa\UpdatedBy;
}

Which would auto-register the hooks and methods for createdBy and updatedBy, rather than having them available anyway.

Custom events

Use-case I've just come across is having a nullable datetime field, that once set would be nice to automatically assign who set it (separate from updated_at). E.g.:

$table->datetime('scheduled_at')->nullable();
$table->integer('scheduled_by_id')->unsigned();

$table->foreign('scheduled_by_id')->references('id')->on('users');

Potential model syntax:

class Broadcast extends Model {
protected $blameable = ['created'];
protected $blameable_extra = ['scheduled_at' => 'scheduled_by_id'];
}

Then setting scheduled_at sets scheduled_by_id to the current user.

Schema builder helpers

A nice-to-have if it's possible to add these - emulate the timestamps() helper for schema building:

Schema::create('comments', function($table) {
    $table->increments('id');

    $table->createdBy();
    $table->updatedBy();
    $table->deletedBy();
});

Aliasing to something like:

$table->integer('created_by_id')->unsigned();
$table->foreign('created_by_id')->references('id')->on(Config::get('culpa::users.table'));

Cannot eager load users with trashed

Might be a Laravel issue, the following does not work:

class Post extends Eloquent {
    public function createdBy() {
        // Culpa\CreatedBy
        return $this->belongsTo('User')->withTrashed();
    }
}

Post::with('createdBy')->get();

Results in "Invalid argument supplied for foreach()" in Illuminate/Database/Eloquent/Builder.php:388 ($this->query->wheres is null).

Some level of 5.3 compatability

While traits are PHP 5.4 and above, we still have a lot of people on 5.3 (even if it is EOL soonish).

It may be possible to pull the set-current-user-automatically parts into model hooks that are applied to all model events. So while 5.3 users would still have to define methods like createdBy(), updatedBy() on their models, the automatic-set part could be picked up automatically (I think the only user change would be making Model::$blameable public rather than protected).

deleted_by_id not being updated upon delete()

Hello, this is an amazing package I must say, but I'm having trouble to have the deleted_by_id field which is not being set after a softdelete. I can see that the delete_at field is updated as the updated_by_id, but not the deleted_by_id. I'm using the most recent version of Laravel:

"laravel/framework": "4.2.*",
"rmasters/culpa": "dev-master"

For my host I'm using the Laravel's Homestead via vagrant.

Any thoughts?

Appreciate your work and feedback! :)

deleted_by not set to null on restoring

Hi could you please add

    public function restoring(Model $model) {
        $model->{$this->getColumn($model, 'deleted')} = null;
    }

to the BlameableObserver, in order to also restore the deleted_by column when restoring a soft-deleted model

Thank you

There are no tests

Naughty me...

[Feature Request] Add support for sentry auth system

Is it possible for you to add support for sentry 2?

http://docs.cartalyst.com/sentry-2

You can do Sentry::user()->id to get the user id