roadiehq/backstage-plugin-buildkite

A BuildKite plugin for Backstage

backstage-plugin-buildkite's Issues

The BuildkiteBuildsTable shows all builds in buildkite, instead of the selected service

Hi there, thanks for creating this plugin!

When I was integrating this plugin in my backstage app, i found all the builds under my organization were shown up in the CI/CD tab. In my understanding, it should only shows the builds of that service.

And I noticed that, in the getBuilds function, the orgSlug and pipelineSlug are not passed to buildkite API here

Is this deliberate or a bug?

Tests appear to be erroneously passing

When the tests run, I see a number of errors logged. However, the build does not fail.

For example, please inspect the yarn run test step of this build.

  ● Console

    console.error
      Error: Not implemented: HTMLCanvasElement.prototype.getContext (without installing the canvas npm package)
          at module.exports (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:9:17)
          at HTMLCanvasElementImpl.getContext (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jsdom/lib/jsdom/living/nodes/HTMLCanvasElement-impl.js:42:5)
          at HTMLCanvasElement.getContext (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jsdom/lib/jsdom/living/generated/HTMLCanvasElement.js:130:58)
          at hasBrowserCanvas (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jspdf/src/libs/png.js:480:36)
          at /home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jspdf/src/libs/png.js:489:3
          at Object.<anonymous> (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jspdf/src/libs/png.js:28:11)
          at Runtime._execModule (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jest-runtime/build/index.js:1299:24)
          at Runtime._loadModule (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jest-runtime/build/index.js:898:12)
          at Runtime.requireModule (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jest-runtime/build/index.js:746:10)
          at Runtime.requireModuleOrMock (/home/runner/work/backstage-plugin-buildkite/backstage-plugin-buildkite/node_modules/jest-runtime/build/index.js:919:21) undefined

      at VirtualConsole.<anonymous> (../node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at module.exports (../node_modules/jsdom/lib/jsdom/browser/not-implemented.js:12:26)
      at HTMLCanvasElementImpl.getContext (../node_modules/jsdom/lib/jsdom/living/nodes/HTMLCanvasElement-impl.js:42:5)
      at HTMLCanvasElement.getContext (../node_modules/jsdom/lib/jsdom/living/generated/HTMLCanvasElement.js:130:58)
      at hasBrowserCanvas (../node_modules/jspdf/src/libs/png.js:480:36)
      at ../node_modules/jspdf/src/libs/png.js:489:3
      at Object.<anonymous> (../node_modules/jspdf/src/libs/png.js:28:11)

Running `yarn` on fresh clone of plugin causes `yarn.lock` changes.

Expected Behavior

There should be no diff in the yarn.lock.

Current Behavior

There is a diff in the yarn.lock.

yarn.lock | 2018 ++++++++++++-------------------------
 1 file changed, 65 insertions(+), 1953 deletions(-)

Possible Solution

1. Run yarn in the plugin.
2. Test that the plugin still works with the changes
3. Commit the changes.

Steps to Reproduce

1. Clone the plugin
2. Run yarn.

License file is missing