rob--/cluster-messages

Easily send messages between workers and the master with callbacks in Node.js

cluster-messages's Issues

Apparent bug in setTimeout function

Hi,

I see this code in your package:

        /* This should not actually be needed, but to be 100% safe in case
         * messages between the master and worker processes are lost,
         * delete the callback function after a set timeout to prevent permanent memory hogging. */
        setTimeout(function(){
            if(this.callbacks.hasOwnProperty(id)){
                delete this.callbacks[id]
            }
        }, this.callbackTimeout)

This causes exceptions like the following:

/usr/src/app/node_modules/cluster-messages/index.js:48
            if(this.callbacks.hasOwnProperty(id)){
                             ^
TypeError: Cannot read property 'hasOwnProperty' of undefined
    at Timeout.<anonymous> (/usr/src/app/node_modules/cluster-messages/index.js:48:30)

I believe the reason is that when the timeout function runs, "this" is a Timer object, and not the ClusterMessages object... and so the "this.callbacks" is undefined.