Giter Site home page Giter Site logo

module-notorama's Introduction

Aimes_Notorama

I no longer have the capacity to work on this. This repository is no longer maintained.

You're welcome to fork, continue, or whatever you like.

Magento 2 module: Remove's Fotorama and, hopefully, headaches.

Replaces the Magento 2 standard Fotorama gallery with a slick variant, as also used in PageBuilder for Magento Commerce stores.

WARNING:

This module is currently considered unstable and should not be used outside of development.

  • This project is still a work in progress. There are currently no options available through layout arguments or view.xml as intended.
  • CSS is added via the layout <head> argument which is bad and will be moved to _module.less in future.

Features

  • Replaces / Removes Fotorama
  • Uses slick (Magento PageBuilder also uses this)
  • Uses slick lightbox for fullscreen image viewing
  • Adds placeholder / preview content before the Gallery fully initialises, leading to a much smoother page load experience
  • Images that are not immediately visible on the page are lazyloaded appropriately
  • Supports video from YouTube and Vimeo
  • Only initialises iframe elements when the relevant video thumbnail is clicked (and automatically plays the video to save clicking twice!)
  • Moderately flexible styling, although the base CSS still needs work

module-notorama's People

Contributors

grimlink avatar jissereitsma avatar robaimes avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

jissereitsma djinnsour gjportegies frosit luizsantos1 gtlt ericclaeren konstantins90 orionpt performadigital ananth-iyer sproutdesk shopwhizzy

module-notorama's Issues

Dependency on vimeo breaks swatches

Hi,

The massive outage of Fastly, broke Vimeo and therefor broke the vimeo player require.js dependency and therefor broke the swatch renderer mixin.

Looking into a possible fix, but think vimeo player should not be loaded through require js and should not be mandatory for loading notorama.

Problem with configurable products

I'm using this plugin on magento 2.3.5 and it's amazing. I have some configurable products which have different images , if i change the subproduct form the dropdown in frontend the slick not resizes at right width and appears blank (like screenshot attached). The crazy thing is if I play changing options then the image appears good😅
image

Caption

How to add a custom caption

If product title contains a ' or " the json breaks resulting in a json error

Some of our product titles contain apostrophes or quotations. This breaks the json format for the product view image.

image

This is the full json:
{"initialImages":"[{\"thumb\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/79e1e7bedd753adfc5e16d432c6f3132\\\/m\\\/a\\\/makita_dub361z.jpg\",\"img\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/7c515c7d7aacb26b754ce8379b9a25b3\\\/m\\\/a\\\/makita_dub361z.jpg\",\"full\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/e0d1dcca11a1ec209e27b8dfb2eb5b8c\\\/m\\\/a\\\/makita_dub361z.jpg\",\"caption\":\"Makita DUB361Z 2x18 V Bladblazer | zonder accu'sen lader (Accu Bladblazer) 1\",\"position\":\"2\",\"isMain\":true,\"type\":\"image\",\"videoUrl\":null},{\"thumb\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/79e1e7bedd753adfc5e16d432c6f3132\\\/m\\\/a\\\/makita_tuinmachinesfb_14_1_41.jpg\",\"img\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/7c515c7d7aacb26b754ce8379b9a25b3\\\/m\\\/a\\\/makita_tuinmachinesfb_14_1_41.jpg\",\"full\":\"https:\\\/\\\/myron-m2.toolmax.nl\\\/media\\\/catalog\\\/product\\\/cache\\\/e0d1dcca11a1ec209e27b8dfb2eb5b8c\\\/m\\\/a\\\/makita_tuinmachinesfb_14_1_41.jpg\",\"caption\":\"DUB361Z 2x18 V Bladblazer | zonderaccu's en lader\",\"position\":\"3\",\"isMain\":false,\"type\":\"image\",\"videoUrl\":null}]"}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.