robertkarl/yabc

A cryptocurrency tax calculator.

yabc's Issues

Support multiple open 'pools'

Required for #62.

Currently the algorithm looks like this:

for each different coin:
  select all tx's that appear to contain that coin
  create an empty pool
  for each tx we selected:
    call process_one()

At the very least we need to make sure that we select the right tx's for each coin.

cost basis reports for coin/coin trades need to lookup prices

resolved when:
the cost basis reports generated from running yabc on adhoc.csv look up a dollar value for the amount of BTC and ETH on that date.

$ python -m yabc /home/rk/code/yabc/testdata/adhoc/adhoc.csv
...
<Sold 10000 ETH on 2018-05-22 00:00:00 for $0. Exchange: adhoc. Profit:$0.
	<TX 2018-05-22 00:00:00 SELL 0.33 BTC for 10000 ETH, from exchange adhoc. Fee 0.001 BTC>>

Coin/coin trades - make sure we add TradeInputs in all necessary cases

"Perpetual Futures" contracts

Perpetual futures are a strange beast.

https://help.bybit.com/hc/en-us/articles/360012865933-Bybit-Definition-Features-Uses

Two traders, one short and one long, enter into a contract with each other. Payments are made, typically in BTC, based on price movements in the underlying asset. TODO: Does the exchange take long and short positions with their customers?

bybit, bitmex and deribit offer these contracts.

Make yabc understand them better. AFAIK no IRS guidance has been given about this, so the best way to treat this seems to me to be:

• First, track the initial deposit to the exchange. This is typically in BTC.
• Once the user enters into one of these contracts, there is a daily stream of BTC inputs and BTC payments made.
  • For each input, when the price moves in your favor, assign a cost basis to that coin from the current price
  • For each output, when you lose bitcoin, treat this the same as making a payment for something that cost $0. The BTC vanished, you received nothing for it, create a sale at a loss equal to the cost basis.

Coin/coin trades

Support markets like ETH/BTC.

These are required for importing trade data from Binance for example.

• Right now, we have asset_name as a field on Transaction.

Migration plan

• add new fields to in-memory object (quantity_traded, quantity_received, symbol_traded, symbol_received)
• Allow passing the new fields to constructor of Transaction
• Deprecate usd_subtotal and quantity fields
• Add migrate script to add the fields to existing DBs
• write the values for 4 new fields to in-memory objects. (Still create Transactions using old syntax, but propagate it to new columns). This ability is critical for migration.
• Move basis calculation logic to use NEW fields. Stop using usd_subtotal in basis.py. This is the most critical step for making sure basis calculations are still correct.

At this point we should be able to use both syntaxes. Either usd_subtotal and asset_name, or the fully specified one.

• Migrate ALL usages of Transaction over to new syntax
• Remove the deprecated parameters from Transaction constructor

import non-BTC coins from gemini

ether, bch, litecoin should be supported

Make sure that gifts are properly accounted for in 8949

Make sure that the following history makes sense:

buy 1 bitcoin
give 1 bitcoin as a gift
No 8949 needs to be filed

Cost basis report quantization should be consistent

gain_or_loss field should be quantized the $1 or $.01 the same way as the other fields; right now it's clipped to the dollar.

Make it consistent

mining is income when it's mined.

The day mining occurs, trigger a taxable event.

If the inputs don't make sense, don't panic

If inputs are received with only SELLs, but no BUYS, we currently panic.

Instead detect this and use a cost basis of zero for those sells.

    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/rk/code/yabc/src/yabc/__main__.py", line 42, in <module>
    main()
  File "/home/rk/code/yabc/src/yabc/__main__.py", line 36, in main
    reports = processor.process()
  File "/home/rk/code/yabc/src/yabc/basis.py", line 293, in process
    reports, pool = _process_all(self.method, self.txs)
  File "/home/rk/code/yabc/src/yabc/basis.py", line 257, in _process_all
    ops = process_one(tx, pool)
  File "/home/rk/code/yabc/src/yabc/basis.py", line 128, in process_one
    amount += pool[pool_index].quantity
IndexError: list index out of range