Giter Site home page Giter Site logo

adop-pipeline-builder's People

Contributors

endahprastiwi avatar kramos avatar robertnorthard avatar

Stargazers

 avatar

Watchers

 avatar  avatar

adop-pipeline-builder's Issues

Issues setting downstream

  1. The cartridge collection loader expects it to be called downstream_folder. See:
    https://github.com/kramos/adop-platform-management/blob/master/projects/jobs/jobs.groovy#L342

  2. (Minor) the downstream for production is being set to "Production_Pipeline", it should be unset
    https://gist.githubusercontent.com/anonymous/a05ca0e651052deb016823347d5b0498/raw

  3. The downstream for an integration pipeline is not being set, it should be the downstream integration pipeline name or PROD
    https://gist.githubusercontent.com/anonymous/a05ca0e651052deb016823347d5b0498/raw

  4. The "Production_Pipeline" is being called "PROD" whereas "Production_Pipeline" is a both better name and what CI pipelines off the Prod node are expecting (see ADOP_Flyway_Cartridge)
    https://gist.githubusercontent.com/anonymous/a05ca0e651052deb016823347d5b0498/raw

  5. The downstream for CI pipelines off an integration pipeline is being set to "Application_Pipeline", it needs to be set to the name of the downstream Integration pipeline e.g. Integration1 in
    https://gist.githubusercontent.com/anonymous/a05ca0e651052deb016823347d5b0498/raw
    OR to "Production_Pipeline".

Happy to demo.

Enhancement

It would be nice to be able to name Integration pipelines and Prod as well.

Refactor hackathon code to promote OOP best practices

This was done during a hackathon and the code is rather hacky in place. It should be refactored to promote OOP best practices (low coupling, cohesive, law of demeter etc).

  • Use bower for all dependencies, if they exist.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.