Giter Site home page Giter Site logo

robertocapannelli / newsletter-card Goto Github PK

View Code? Open in Web Editor NEW
1.0 1.0 0.0 131 KB

WordPress Plugin to easily have a newsletter card pop up from bottom page on scroll

License: GNU General Public License v3.0

PHP 39.05% CSS 0.93% JavaScript 60.02%
php wordpress-plugin

newsletter-card's People

Contributors

robertocapannelli avatar

Stargazers

 avatar

Watchers

 avatar

newsletter-card's Issues

Fix outerHeight in main.js

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Mobile layout

Add

#newsletter-card-wrapper {
right: 0;
width: calc(100% - 30px);
margin: 15rem;
max-width: 400px;
bottom: 0;
}

toolchain javascript/css needed

Is your feature request related to a problem? Please describe.
Need a package manager to handle scripts and styles compiling all together

Describe the solution you'd like
Use something like npm

Set cookie when the form is submitted

Describe the bug
When a user submitted the form the first time without push the closing X, cookie won't set automatically.
To Reproduce
Steps to reproduce the behavior:

  1. Scroll the page will appear the pop-up newsletter
  2. Fill the form
  3. Submit
    4.Then refresh the page a the card will appear again

Expected behavior
It should set a longer cookie (about 30 days) even after the form is submitted, before set it it should check if the form is filled correctly without any mandatory field missing.

FIX: use a different duplicated proof name for nonce

Describe the bug
Using the suggested name from WordPress for ajax nonce could be create conflicts between plugins and themes

To Reproduce
Just use my_ajax_obj for nonce name to reproduce the error and use it for another purpose as well

Expected behavior
wp-admin-ajax.php returns 404 error

Allow submit with return button

Is your feature request related to a problem? Please describe.
You can't submit the form pushing return button on the keyboard

Describe the solution you'd like
Allow submit the form with return button
Describe alternatives you've considered
Let things like now

Custom style

Describe the solution you'd like
It should give the possibility to customise the front-end, maybe with a custom css field, or let decide the user where the card will be positioned (left or right)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Exclude pages

Is your feature request related to a problem? Please describe.
It shouldn't show the card every where at anytime
Describe the solution you'd like
It should let the user decide if some pages could be excluded to showing the card
Describe alternatives you've considered
Do nothing

Fix container class style

Describe the bug
The container class has been changed to newsletter-card-container to avoid css conflict with other plugins or framework

Expected behavior
The class should be fixed in css file

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.