robertskalko/mine-and-slash

Repo for my minecraft mod

mine-and-slash's Issues

Add support for silent gems scaling health

So this mod sounds great but my health mod of choice is easily SilentChaos scaling health. If you can make sure this mod does not conflict with that one I will test your mod in my project. To be honest your mod looks awesome.

[1.12.2] Dupe bug - Master bag

Mine and Slash-1.14.3-2.0.23

When a user makes two master bags, he can see the same inventory in both bags.

When he hands the second bag to another player, that player can throw everything out of that bag and it both throw out the items duping everything in the bag.

[1.14.4] Eggs need localizing.

Duplication issue (latest version)

Hello! So basically, when you open the special inventory (g) and shift click on a stack-able item inside of your inventory (while special inventory is open), this item duplicates itself over and over until it reaches 64.

Also, much smaller issue, when pressing the drop key on a item (q or a on my keyboard), sometimes other items just randomly pop ouf of my inventory too.

Thank you!

Feature request

Hello,

first off, I would like to say, that i really love your mod. I think it's very innovative aside from everything else that is offered moding wise.

Now that i said that, following things struck me:

• On a server i get a lot of nullpointer exceptions, i assume your mod is not ready for a server?
• Cobwebs cannot be cut with swords from your mod
• I'd love to see a config option for starting level and level distance on a per dimension base.
• One thing that would be really cool, because it would make interaction with other mods better is when crafting gear ie. diamond sword, it should get itemlevel of your char and random rolls from your mod.
• Any chance of cheating in gear with a special itemlevel for testing purposes?

I had some other problems with like no fall damage, almost no void damage, and other things like that, but that seems fixed with the latest update.
If anything else comes to my mind, I hope its ok to send it to you here on github.

Thank you for this great mod,

Greetings Shadowless99

Potion effect name needs localizing.

effect.mmorpg.self_regen

This was obtained by eating a Tombstone candy that you get on Halloween, or if you are a donor, it gives any random effect even the bad ones.

New version and old archive BUG

thank you for your timely update of Unsalvagable BUG.

Today I found a new bug, but it seems that this is not a problem with this mod. I don't know how to delete it, sorry.

I hope to add text about new content rune and set in lang, which can make the game translation better. Thanks for your mod, you and the mod are great.

My English is not very good, this comes from Google Translate.

No limit on secondary attributes?

Is this supposed to be allowed?

[1.14.3] Name needs localizing.

Players level reset to 1 - console stacktrace.

Stacktrace-
https://gist.github.com/ProsperCraft/ee50e00a5d06dc9f48bb4695737cb663

Full debug log-
debug-1.log

Full log-
2019-07-15-7.log

1.14.3 modpack - https://www.curseforge.com/minecraft/modpacks/the-adventures-of-halk

[v2.4.5] load error

Error on load:
Mine and Slash (mmorpg) has failed to load correctly
net/minecraftforge/fml/common/gameevent/TickEvent$PlayerTickEvent

latest.log

[1.14.4] mob catching mods re-roll how rare a creature is.

https://gyazo.com/4b395f4283b26a9690f5c0e2de2bbc1f

Every time I pick up this horse and put it back down it re-rolls it.

[1.14.4] Client crash when left clicking anything.

https://gist.github.com/ProsperCraft/d1bbd68a236d6405122fb62c94e0f0e1

[1.14.3] Crashes on loading dedicated server.

Crash -
https://gist.github.com/ProsperCraft/83760f4c814e7ef4aeafe9e16034a1b0

forge-1.14.3-27.0.16
Mods- Only
Mine and Slash-1.14.3-2.0.3
curios-FORGE-1.14.3-0.13

Logs-
https://gist.github.com/ProsperCraft/ed8cf0db692b5b760f624bf2a4edf454
debug-
https://gist.github.com/ProsperCraft/3c3de2a030e05fae778e967b2de550f3

Bag BUG

Any bag from the Hotbar to the inventory, then from the inventory to the Hotbar, will cause the contents of the bag to disappear.

My friend’s stuff is gone, he is very sad.

Sorry, my English is not very good. I am using Google Translate. I hope you can understand.

[request] 1.14 Crossbows and tridants as weapon bases.

Bonus points if they use fancy scaling. For example, Tridants could be inherently magic + melee hybrids.

[Suggestion] Add config option for spell damage multiplier or buff damage spells

The title explains itself.

Magic Spells does VERY LITTLE damage compared to regular weapons (swords and bows)

I found a level 6 fireball that does less damage than my lv1 common starter sword, why bother using magic then?

[1.14.3] Server crash - Group map- NoSuchMethodError: com.robertx22.blocks.map_device.TileMapDevice.getRenderBoundingBox(

Crash report-
https://paste.fedoraproject.org/paste/fa9U1Tm3vktiCP2gqSyL5A

Console-
https://gist.github.com/ProsperCraft/403a3a46fb6615b187a9f55ddd071097

We tiered this up to tier 20 then jumped in to this group map.

Clean Debug log-
debug.log

Clean Latest log-
latest.log

Mod version - Mine and Slash-1.14.3-2.0.27
Forge version - forge-1.14.3-27.0.50

Map Device (2.1.0 - 1.14.3)

Ive been playing with some friends, and when we use a Map, I (server Host, Map host) get teleported to the right map but they are teleported to a lvl 1 Map. Also when they come back they spawn under a block or in the nether.
Thx, awesome mod really enjoying it !

Auto Salvage Bag + Master Bag deletes every Spell

So I have a Common Auto Salvage Bag (->ASB) and a Master Bag. Every spell I collect gets nuked. The filter in the common ASB says "Spells: Common", so it only deletes Common Spells or am I wrong?

Every other Item works fine (Runes, Maps, RuneWords, Currency, Gear).

Dimension ID invalid

My server crashes when I try using a map on the map device. I've changed the dimension ID a few times to random numbers but it's always invalid.
I'm using mine and slash 1.6.19 and forge 14.23.5.2838

crash-2019-07-20_16.24.02-server.txt

[REQUEST] Option to turn off stamina requirement

Is there any way I can turn off the stamina requirement for attacking. I love your mod. But I wanna have Zombie Awareness in my mod pack as well. And the mechanic where when your stamina is too low you do no damage really makes that impossible. Zombie Awareness creates swarms of creatures. And with this stamina requirement it makes facing huge numbers of enemies pretty much guaranteed death.

Missing Shield Textures

I have been troubleshooting for several hours. There are many reasons, not caused by a single module. I still can’t judge what the reason is.

Staff damage error？

Staff left and right keys have double damage, is this a BUG?

Sorry, my English is not very good. I am using Google Translate.

Missing Shield textures

the title explains itself.

Image

Stacktrace in console

The server did that unexplained CME crash and rebooted while we were in the map dim, when we logged back in we were all dead with graves at 0 0 in the overworld.

This stacktrace was in console when I tried to log in...

https://gist.github.com/ProsperCraft/f7ae21f9d5b4016bc6b6d8426ff28dea

[Feature Request] Configured Items added to mob drops

Feature: Having the items you configure in the CompatibleItems config added to the mob drop list. This is something that can be added to the config like so it would still be a feature that can be turned off and on.

"rcraft:dualswords": {
      "itemType": "Sword",
      "uniqueItemWeight": 0,
      "normalItemWeight": 80,
      "runedItemWeight": 20,
      "randomUniqueUpToTier": 10,
      "minRarity": 0,
      "maxRarity": 5,
      "itemIsPlayerLevel": true,
      "itemLevelIfDoesntUsePlayerLevel": 1,
      "levelVariance": 0,
      "uniqueId": "",
      "uniqueIsRandom": true,
      "useDropSystem": true
    }

Reasoning: I mean you already have the items and such being given stats, this is honestly the logical next step. I know you are working on the 1.13 port but would you be able to include it in the 1.12.2 version?

Mine and Slash is re-registering already registered enchantments.

Please remove this method call. It does nothing but break things. https://github.com/RobertSkalko/Mine-and-Slash/blob/1.14.4/src/main/java/com/robertx22/mine_and_slash/mmorpg/registers/common/EnchantRegisters.java#L32
You cannot re-register already registered enchantments.

Portals are not removed when a map is closed nor when a map device is broken.

I died in a permadeath map, then removed my map device and placed it one block under its original position. I now have two sets of portals as seen here. https://i.imgur.com/GbtqIwM.jpg

Entering a new map will take me to the old permadeath map about 75% of the time. I'm unsure if it uses the stats of the new or old map.

Exiting the map at one point took me about 1,000 blocks away from my map device and put me one block into the ground. I suspect these were the coordinates for the spawn of the other map.

[Suggestion] Add config option for biomes

Feature idea:
Adding a config option where you specify biomes where mobs would get an additional level added(could be additive/multiplicative) so that you can have certain areas as more dangerous than others.

Staff and Bow Config Options Request

Hello, and thanks for a very interesting mod.

We are here to ask you to add the config options (list) for Staffs and Bows.
Experimenting on our server, would prefer to use their own set, rather than adding them to... Hammers (?)

I always get this crash

I always get this crash everytime I use your mod
---- Minecraft Crash Report ----
// I let you down. Sorry :(

Time: 7/11/19 8:00 PM
Description: Exception ticking world

java.lang.IllegalStateException: Entity is already tracked!
at net.minecraft.world.chunk.ChunkManager.func_219210_a(ChunkManager.java:875) ~[?:?] {}
at net.minecraft.world.chunk.ServerChunkProvider.func_217230_c(SourceFile:441) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.world.ServerWorld.func_217465_m(ServerWorld.java:950) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.world.ServerWorld.func_72835_b(ServerWorld.java:350) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:813) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:748) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:112) ~[?:?] {pl:runtimedistcleaner:A}
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:609) [?:?] {pl:accesstransformer:B}
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Server thread
Stacktrace:
at net.minecraft.world.chunk.ChunkManager.func_219210_a(ChunkManager.java:875)
at net.minecraft.world.chunk.ServerChunkProvider.func_217230_c(SourceFile:441)
at net.minecraft.world.ServerWorld.func_217465_m(ServerWorld.java:950)
at net.minecraft.world.ServerWorld.func_72835_b(ServerWorld.java:350)

-- Affected level --
Details:
All players: 1 total; [ServerPlayerEntity['neobenmike'/252, l='Neo Empire', x=74.30, y=81.00, z=-64.41]]
Chunk stats: ServerChunkCache: 2025
Level dimension: DimensionType{minecraft:overworld}
Level name: Neo Empire
Level seed: 280823388
Level generator: ID 00 - default, ver 1. Features enabled: true
Level generator options: {}
Level spawn location: World: (80,74,-48), Chunk: (at 0,4,0 in 5,-3; contains blocks 80,0,-48 to 95,255,-33), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,0,-512 to 511,255,-1)
Level time: 337982 game time, 171158 day time
Level storage version: 0x04ABD - Anvil
Level weather: Rain time: 125293 (now: false), thunder time: 9966 (now: false)
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: true
Stacktrace:
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:813)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:748)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:112)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:609)
at java.lang.Thread.run(Thread.java:745)

-- System Details --
Details:
Minecraft Version: 1.14.3
Operating System: Windows 8.1 (amd64) version 6.3
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 2276478600 bytes (2171 MB) / 4294967296 bytes (4096 MB) up to 4294967296 bytes (4096 MB)
JVM Flags: 8 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx4G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
FML: New FML!
Loaded coremods (and transformers): Nothing
Player Count: 1 / 8; [ServerPlayerEntity['neobenmike'/252, l='Neo Empire', x=74.30, y=81.00, z=-64.41]]
Data Packs: mod:mmorpg, mod:ceilingtorch, vanilla, mod:xaerominimap, mod:waila, mod:uteamcore, mod:usefulbackpacks, mod:torchbandolier, mod:silentlib, mod:scalinghealth, mod:practicaltools, mod:mobcatcher, mod:metalbarrels, mod:jei, mod:inventorysorter, mod:gobber2, mod:funores, mod:forge, mod:findercompass, mod:fastleafdecay, mod:f2l, mod:extrabows, mod:extraanvils, mod:curios, mod:autodropper
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'forge'

Copy jewelry BUG

First of all, this module is very good, I like it very much, my friends like it too, I hope to continue to update.

In the server, click any jewelry from the jewelry bar and put it directly into the auxiliary handrail (shield bar). When the player transmits to other worlds, you can copy the jewelry.

Transfer refers to the use of a plug-in written with a transfer command (menu). After the transfer, the jewelry in the accessory bar (the shield bar) will appear again in the jewelry bar, so that the jewelry can be copied.

I know this is a bug in the Baubles mod, but I want you to know.

I am sorry that my English is not good. I am using Google Translate.

首先这个模组非常棒，我很喜欢，我的朋友们也很喜欢，我希望能够继续更新下去。

在服务器中，将任意饰品从饰品栏中点击直接放入副手栏(盾牌栏)，当玩家传送到其他世界后可以复制饰品。

传送是指使用写有传送命令(菜单)的插件进行传送 ，传送后当初饰品栏放入副手栏(盾牌栏)中的饰品会在饰品栏中再次出现一个，这样就可以复制饰品了。

我知道这是Baubles mod的BUG，但是我想让你知道。

很抱歉我的英语不好，我使用的是谷歌翻译。

[Feature Request] Side by side equipment compare like Diablo

Would be very useful if we could press a key and mouse over equipment to bring up your current gear vs the gear you are moused over.

Unsalvagable BUG

Hello, I like this module very much. I have been playing with my friends for a week, which is great.

Feedback on a bug, the equipment obtained in the Newbie Gear Bag can be recycled in the Gear Salvage Station to get Ore.

My English is not very good, I am using Google Translate.

您好，我很喜欢这个模组，我和朋友们已经玩了一个星期，这很棒。

反馈一个BUG，Newbie Gear Bag中获得的装备可以在Gear Salvage Station中回收获得Ore。

我的英语不是很好，我使用的是谷歌翻译。

[1.14.3] Stacktrace in Server console when player stood in a map portal block.

https://gist.github.com/ProsperCraft/34b70146a76fe8983b88d54e6e6f1337

Mine and Slash-1.14.3-2.0.22

Cant Use Crafting Station

No MAtter what gear I put in and ores the gear crafting station simply will not work, Am I do it wrong? Cause the book doesn't really specify where to put what.

[BUG]1.12.2 Awaken RuneWord

Ghost's combination VOH+XAH+BER+XAH+CEN cannot be put into 2 XAH。

http://i1.fuimg.com/542480/c8beddc06c4a59f5.png

[Feature Request] Ability to link items in chat to show off.

Like this- https://forums.factorio.com/viewtopic.php?f=6&t=21974

So you can share your loots with other players, they can see their stats without having to list them.

[1.14.3] Registry Feature: The object com.robertx22.world_gen.structures.TowerStructure@3ecf180 has been registered twice for the same name mmorpg:tower.

Is this a problem? -
on my client-

[12:38:28.487] [modloading-worker-3/WARN] [ne.mi.re.ForgeRegistry/REGISTRIES]: Registry Feature: The object com.robertx22.world_gen.structures.TowerStructure@3ecf180 has been registered twice for the same name mmorpg:tower.

[1.14.4] Every server start leads to this error -ava.lang.Exception: Unique Id doesn't exist: swordphysical0

I see this in console every time I start a new world.
Mine and Slash-1.14.4-2.2.5

https://gist.github.com/ProsperCraft/ffb338b17473e2db3214850a7a0528a3

Shields doesn't block projectiles

I'm with a shield up and defending, but I'm getting hit as if I weren't with the shield equipped and blocking

Random game crash 1.14.3

The game randomly crashes with seemingly different triggers each time, but with the same error message, but with this latest crash I got the crash report, the crash doesn't happen without mine and slash.

---- Minecraft Crash Report ----
// This doesn't make any sense!

Time: 7/9/19 10:20 AM
Description: Exception ticking world

java.lang.IllegalStateException: TickNextTick list out of synch
at net.minecraft.world.ServerTickList.func_205365_a(SourceFile:57) ~[?:?] {}
at net.minecraft.world.ServerWorld.func_72835_b(ServerWorld.java:298) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:813) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:748) ~[?:?] {pl:accesstransformer:B}
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:112) ~[?:?] {pl:runtimedistcleaner:A}
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:609) [?:?] {pl:accesstransformer:B}
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Server thread
Stacktrace:
at net.minecraft.world.ServerTickList.func_205365_a(SourceFile:57)
at net.minecraft.world.ServerWorld.func_72835_b(ServerWorld.java:298)

-- Affected level --
Details:
All players: 1 total; [ServerPlayerEntity['epicninja532'/111, l='OWO', x=-354.64, y=118.73, z=-120.87]]
Chunk stats: ServerChunkCache: 3351
Level dimension: DimensionType{minecraft:overworld}
Level name: OWO
Level seed: -3651833984138631357
Level generator: ID 07 - biomesoplenty, ver 0. Features enabled: true
Level generator options: {}
Level spawn location: World: (-256,64,176), Chunk: (at 0,4,0 in -16,11; contains blocks -256,0,176 to -241,255,191), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)
Level time: 38946 game time, 27131 day time
Level storage version: 0x04ABD - Anvil
Level weather: Rain time: 92420 (now: false), thunder time: 2958 (now: true)
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
Stacktrace:
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:813)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:748)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:112)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:609)
at java.lang.Thread.run(Thread.java:745)

-- System Details --
Details:
Minecraft Version: 1.14.3
Operating System: Windows 8.1 (amd64) version 6.3
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 951664640 bytes (907 MB) / 2147483648 bytes (2048 MB) up to 2147483648 bytes (2048 MB)
JVM Flags: 8 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
FML: New FML!
Loaded coremods (and transformers): Nothing
Player Count: 1 / 8; [ServerPlayerEntity['epicninja532'/111, l='OWO', x=-354.64, y=118.73, z=-120.87]]
Data Packs: vanilla, mod:waterstrainer, mod:uteamcore, mod:usefulbackpacks, mod:tombstone, mod:ruins, mod:mmorpg, mod:jei, mod:forge, mod:doggytalents, mod:curios, mod:curioofundying, mod:creeperspider, mod:biomesoplenty
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'forge'

Exiting a map with a pearl sometimes does not return you to your map device.

https://i.imgur.com/PCo71VC.png

I was returned to the overworld correctly, but I think the coordinates I was returned to are the same as what I had inside the map dimension, as the mobs are the same level.

The pearl may have been in my inventory from a previous map.

Gear Craft Station and Capacitor BUG

Capacitor is used in Gear Craft Station and will disappear。

Sorry, my English is not good. This is from Google Translate. I hope you can understand it.

NullPointerException: Rendering overlay

I get a crash as soon as Forge finishes loading.
I am running forge 1.14.4 (28.0.45) and MaS version 2.4.10

Here is the crash log
crash-2019-08-11_19.53.24-client.txt

No Unique Gear?

So me and my friends have been playing with this mod for a while now were all lvl 20 and up and we have yet to find any mobs that drop any of the unique gear shown in images on this mod it is some prettty awesome looking gear so i'm wondering if theres like something i need to enable in config if its not implemented yet or if we just haven't reached the level for them yet or something.

[Feature Request] Do mild pregen of the map worlds while the server is over 19 TPS.

If the server TPS is above 19 pregen the map worlds, this will cause less violent lag when they are generating when the player goes there.

No health bars with Optifine (with or without shaders)

1.14.4 Forge with Optifine preview HD U F4 pre2

Skeleton Despawn When Arrow Rebounds To Itself

Reported on the discord, and tested by myself. Just posting here for public reference.