robin-rpr/marker

Highlight the Web

marker's Issues

Add Contrasting Cursors

Is your feature request related to a problem? Please describe.
Some Users reported they have a hard time seeing the Cursor sometimes on different Backgrounds

Describe the solution you'd like
I created this example implementation:
https://jsfiddle.net/vnsxrmqj/5/

Additional context
None

Flaky Storage on Initial Install

Marker Version: 1.5.2
OS: macOS

What steps will reproduce the problem?

1. Install Marker Extension
2. Draw something on Website
3. Close Marker
4. Open Marker again

What is the expected result?
Show last drawing

What happens instead?
A clean Canvas appeared

Please feel free to add additional Images / Links / Notes below
to help us understand and / or reproduce the issue:
Seems like the storage initialization is not being considered during the initial session.
Maybe the Storage is not initialized and we are trying to auto-save.
In the next session the Storage is initialized and auto-save works(?)

show saved markings automatically on page visit

why do I have to activate the addon manually when the page has saved markings?

Rename "clarity" to "opacity"

There is a button in the floating panel called "clarity". I would suggest to rename it to "opacity", since that is the term that is used in most drawing software (and in CSS) for that attribute -- sometimes also called alpha, or transparency, which is the opposite of opacity.

Using the same term will make it more clear/intuitive for users who are already familiar with the term. For others, it will not make a difference.

Thanks.

Color Picker does not open on Windows 10

Marker Version: 1.4.1
OS: Windows 10

What steps will reproduce the problem?

1. Start Marker on any website
2. Click on Pen to open Color Picker

What is the expected result?
Opens System Color Picker

What happens instead?
Color Picker (?) flashes quickly but does not open.

Please feel free to add additional Images / Links / Notes below
to help us understand and / or reproduce the issue:

Issue Source:
https://www.reddit.com/r/firefox/comments/y0u2k1/comment/is5p7cb/?context=3

Marker Shows blank Canvas on Reddit.com in Darkmode

Marker Version: 1.4.1
OS: macOS

What steps will reproduce the problem?

1. Go to Reddit.com
2. Enable Reddit's Dark Mode Setting
3. Start Marker

What is the expected result?
Show Marker on Website with transparent Canvas as usual.

What happens instead?
Marker opens and presents a white (non-transparent) Canvas

Please feel free to add additional Images / Links / Notes below
to help us understand and / or reproduce the issue:

Reddit Light Mode:

Reddit Dark Mode:

This issue seems to affect all Versions of Marker.
I checked versions back until 1.1.1

Add a close button to the floating panel

Right now, to close the floating panel and stop drawing/marking, I need to click the extension button.

I would prefer (or in addition) to have a close button directly on the floating panel.

• That's where I initially searched for, when trying to stop drawing, so it would be more intuitive.
• Having to click on the extension button to close the panel is not convenient when the button is under the extensions drop down instead of directly in the toolbar (for those users, like me, who prefer to keep it there).

Thanks.