robintty/nordigenapiclient

A .NET client for https://gocardless.com/bank-account-data (formerly Nordigen API)

Hi there 👋

nordigenapiclient's Issues

Error with CurrencyExchange deserialization

I'm using the AccountsEndpoint.GetTransactions(string id) function but it throws an exception:

System.Runtime.Serialization.SerializationException: Deserialization failed, please report this issue to the library author: https://github.com/RobinTTY/NordigenApiClient/issues
The following JSON content caused the problem:  [json]

System.Text.Json.JsonException: The JSON value could not be converted to RobinTTY.NordigenApiClient.Models.Responses.CurrencyExchange. Path: $.transactions.booked[2].currencyExchange | LineNumber: 0 | BytePositionInLine: 1084.

I don't want to post the whole json here since it contains all my bank transactions but I think this might be the part of the json that causes it:

"currencyExchange":[{"sourceCurrency":"USD","exchangeRate":"10.3373000","unitCurrency":"USD","targetCurrency":"SEK"}]

RequisitionsEndpoint.GetRequisitions Results.Result is empty

GetRequisitions does not have a good result.

var req = await client.RequisitionsEndpoint.GetRequisitions(0, 100);
foreach (var item in req.Result.Results)
{
}

if you check:
req.Resoult.Count = 3
But
req.Result.Results = 0

I think this is a deserialization issue.

Further CurrencyExchange issues

Further to issue #6 it appears that the CurrencyExchange can be returned as either an array or a single object! Using the latest version failed as my request for account transactions included the following JSON:
"currencyExchange": { "instructedAmount": { "amount": "3.35", "currency": "EUR" }, "sourceCurrency": "EUR", "exchangeRate": "1.1552", "unitCurrency": "GBP", "targetCurrency": "GBP" },

Furthermore, it also contained an InstructedAmount section which appears to be new. I will submit a pull request later

Unknown fields {'payments_enabled'} in payload (https://ob.nordigen.com/api/v2/institutions)

I think nordigen removed the "payments_enabled" in query string.

var query = new KeyValuePair<string, string>[] {new("country", country), new("payments_enabled", paymentsEnabled.ToString())};

We give back an error:

Unknown fields {'payments_enabled'} in payload

Would you remove from the querystring?

Improve compliance of CreateAgreement with API spec

Currently the class CreateAgreementRequest, which is used as a payload to create an end user agreement, has the required properties MaxHistoricalDays, AccessValidForDays, AccessScope and InstitutionId. The GoCardless documentation mentions that MaxHistoricalDays, AccessValidForDays and AccessScope are optional when sending the request. The class should be changed to respect the API spec and tests added to see if the actual behavior is as described in the documentation.

Unable to mock response classes

I'm currently trying to write some unit tests for a project that uses this library. I'd like to be able to mock the NordigenApiResponse<T1,T2> class, and check that my code responds to various response objects appropriately. However I can't do this as the class doesn't have an interface or public constructor/setters.

If this class could have an interface that would be great, although I'm open to other suggestions as to how this could be achieved.

Add unit tests for unsuccessful responses.

I should add unit tests that check for successful deserialization of error responses.

InstitutionsEndpoint.GetInstitutions - US is not a valid choice?

Hi - if I call the GetInstitutions with Country = US I get an error below.

according to this page https://bankaccountdata.gocardless.com/api/docs#/institutions/retrieve%20all%20supported%20Institutions%20in%20a%20given%20country United States of America should be country code US.

System.Runtime.Serialization.SerializationException
HResult=0x8013150C
Message=Deserialization failed, please report this issue to the library author: https://github.com/RobinTTY/NordigenApiClient/issues
The following JSON content caused the problem: {"country":{"summary":"Invalid country choice.","detail":"US is not a valid choice."},"status_code":400}
Source=RobinTTY.NordigenApiClient
StackTrace:
at RobinTTY.NordigenApiClient.Models.Responses.NordigenApiResponse2.<FromHttpResponse>d__13.MoveNext() at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task) at RobinTTY.NordigenApiClient.NordigenClient.<MakeRequest>d__262.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at RobinTTY.NordigenApiClient.Endpoints.InstitutionsEndpoint.d__2.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()

This exception was originally thrown at this call stack:
System.Text.Json.ThrowHelper.ThrowJsonException_DeserializeUnableToConvertValue(System.Type)
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)

Inner Exception 1:
JsonException: The JSON value could not be converted to System.Collections.Generic.List`1[System.String]. Path: $.country | LineNumber: 0 | BytePositionInLine: 12.

Add previously undocumented fields to models

Since the documentation moved to the GoCardless website the Swagger docs now contain the complete response models which contain some fields which aren't covered yet by the library. Like AccountDetails.OwnerAddressStructured or multiple fields in the Balance schema. These missing fields should be added.