robmikh/displayrecorder

A utility to record displays.

displayrecorder's Issues

Errors don't automatically end a recording

Currently an error on the encoder thread only stops that thread. The user must still press ENTER to stop the recording, after which the error will be printed.

Ideally, an error would immediately end the recording. Although a stop-gap may be to print that the error thread is ending due to an error to tell the user the recording isn't happening.

Allow custom encoder settings

The current encoder settings for bit rate, frame rate, and resolution are determined automatically. Users should be able to specify their own settings values if they wish.

• Bit rate
• Frame rate
• Resolution
• Encoder device

Potential memory leak when writing to sink

Hey! First, just want to say thank you for making this repo, I've learned a lot.

I've been playing with this code for a bit and I've created a few fairly long screen recordings with it. I noticed that memory seems to increase at the same rate as the output file. I am fairly new to Rust and very new to Media Foundation and Window Graphics Capture. That said, I was able to get memory usage way down by calling RemoveAllBuffers() on the output sample.

pub fn write(&self, sample: &IMFSample) -> Result<()> {
    unsafe {
        self.sink_writer
            .WriteSample(self.sink_writer_stream_index, sample)?;
        sample.RemoveAllBuffers()
    }
}

Doing this however seems to corrupt the end of the file in some way :/

There are a few other things that seem to stick around causing memory to still increase at random times. Using VS debug profiler I can see there are two things being created repeatedly that are consistent in their size.

EDIT:

Doing this however seems to corrupt the end of the file in some way :/

The above was actually not true, I need to rethink programming at 3am.

Is there a way to record only the particular window screen with specified resoultion

Is it possible to record only the given window in the screen and save with the window's resoultion or predefiened resoultion provided while saving

Low framerate

I'm stuck at around 15 fps (capturing 4k@60 Hz) even though I'm using Nvidia hw encoding. My CPU is pretty much idling. I assume it's the encoder keeping the frames for too long and missing new frames.
Are you getting decent framerates?

Better error messages for unsupported configurations

We need better error messages for the following scenarios:

• No suitable input media type was found for the given encoder.
• Windows.Graphics.Capture is unavailable.
• No hardware encoders found.
• Invalid path specified.

How to get an unencoded frame?

Hi, im trying to add a directx display/windowcapturer to https://github.com/H-M-H/Weylus
Since encoding is handled already i only need a bgr8 slice of the unencoded frame.
Before you pointed me to this repo i tried the same with screenshot-rs and it worked, but i dont know how to get the data i need here.

ARM64 version doesn't work

Testing v0.1.0 on a Surface Pro X ends with E_INVALIDARG:

thread 'main' panicked at 'HRESULT 0x80070057', src\main.rs:149:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace