Comments (3)
Hey @LeoSpyke
This is indeed a feasible feature that should be easy to implement.
An straight forward way to go about it is to add 2 new fields to the Order model: is_private
and password
. If an order is_private == True
, it should not be served via /api/book
. Only a direct link should be able to access the order. Once a user opens the direct link, he should only be able to take it if he knows the password.
We could further simplify it if the /api/order/
endpoint accepts the password as an argument (e.g, /api/order/?order_id=9999&password=abcd
) and if we can relay this argument directly from the frontend by using the route /order/9999/abcd
. That way users do not need to share link and password, but only the link. And we do not need to create a new frontend component to enter the password (less work, gud!).
This feature will require both, new backend and frontend functionality. I am a bit at capacity lately, but happy to help if anyone wants to take the challenge!
from robosats.
I think the buyer could have this option as well... I imagined like if you're in a multiplayer game looking for lobbies and there are "public" and "private" matches. The private ones have a password. Is that the idea @LeoSpyke ?
Idk if this is a lot for the escope of the application. I don't see any other DEX having this kind of feature. So maybe is worth collecting users opinions on this just like @Reckless-Satoshi did for the #1154 PR on Telegram.
Anyway, I'm willing to take this enhancement. Assign me if it's still desirable.
from robosats.
I think the buyer could have this option as well...
Yes, this should be a new field in the MakerForm
under "Advanced Options" available for both, buy and sell orders.
Idk if this is a lot for the escope of the application. I don't see any other DEX having this kind of feature. So maybe is worth collecting users opinions on this just like @Reckless-Satoshi did for the #1154 PR on Telegram.
Mmm, I think it is potentially useful! It will be a niche feature though. Therefore, it is best if this option is kind of hidden and does not clutter the UI or makes it difficult to navigate for newbies.
Anyway, I'm willing to take this enhancement. Assign me if it's still desirable.
Awesome! We can turn it into a Sats rewarded task for 120K Satoshis. I am assigning you.
from robosats.
Related Issues (20)
- Coordinator ratings over Nostr
- Cannot collaborative cancel before buyer posts invoice HOT 3
- Server not available? pending contract HOT 2
- Onchain deposit with PSBTs HOT 5
- [federation]: coordinator 'BitcoinVeneto' HOT 8
- Stuck on Sending satoshis to buyer Order status HOT 2
- Telegram notifications HOT 2
- Filtering by multiple payment methods HOT 6
- Incorrect Sats now for Swaps HOT 4
- [feat] Ability to Upload Images in Chat HOT 3
- Buyer stucks on last step while preparing an order
- Coordinator is not being notified for new disputes in Telegram HOT 1
- Not possible to create a second order with the same robot HOT 1
- Api and website URL issues HOT 2
- POST api/order/ cancel returns error 400 bad_request when successful HOT 1
- Html instead of json output returned when wrong token in Header Authorization
- Upload the Android App to a F-Droid repository HOT 24
- android app nostr link not using njump HOT 1
- Chat delays when in active order HOT 2
- POST /api/order cancel should include current status HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from robosats.