robthefivenine/company-icons

A collection of over 5,000 standardised 1:1 icons for publicly traded companies.

@robthefivenine/company-icons

company-icons is a small web application written to share a collection of icons / logos that I have collected for use in a different project. The icons maintain a 1:1 aspect ratio, making them useful for use in applications that need to maintain a consistent style.

You can access the web application at https://robthefivenine.github.io/company-icons/

License

This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at https://mozilla.org/MPL/2.0/.

company-icons's Issues

Bug: There are more logos than companies

After a PR was submitted (#6 Making icon count dynamic), which removes the hard coded icon count with a dynamic one based on the number of entries in the src/icons.json file, it has revealed there are notably more files in the logos directory, than there are companies in the JSON file.

To calculate the number of icons previously, I ran this command:

$ ls -lah logos/ | wc -l
6117

As you can see, this would indicate there are 6,114 files (3 deducted from the 6,117 returned from the command due to it returning lines that are not files).

Running a similar command for the companies listed in src/icons.json, however, reveals there are only 5,882 companies:

$ cat src/icons.json | grep "exchange" | wc -l
5882

As this equates to a lot of files, that can take up quite a bit of disk space, a file needs to be made that can determine which files in the logos directory are not part of a company listed in src/icons.json, so they can subsequently be removed.

A script that is reusable will be useful, to ensure that if this situation arises again in the future, there is an automated means of cleaning this up.

Enhancement: Expand the library of icons

I am opening this issue for people interested in contributing during Hacktoberfest. As the purpose of this web app is to make a library of standardised icons for publicly traded companies available, any new icons are always welcome.

Information on how to do this can be found in the CONTRIBUTING.md file. Please be sure to verify that you are not duplicating any existing companies.

Please do not be spammy with any pull requests to add new icons though. For example, if you are going to add five new companies, please do not open five separate PRs; compiled them into a single PR.

I will close this issue at the end of the month, but until then, if there are any questions related to adding new icons or troubleshooting the task, please feel free to ask any questions in here.

Happy Hacktoberfest 👻 🎉

Enhancement: change the number of icons listed to be dynamic

Currently, the number of icons served by the web app is hard coded in src/index.html. Ideally, this should be calculated when the icons JSON file is loaded, as it will be one less thing that needs to be updated alongside the JSON.

Enhancement: Update dependencies

Several of the runtime dependencies are currently outdated and should be updated.

Doing this update, however, is likely to cause issues with the latest major updates. After doing the updates (hint: yarn upgrade-interactive makes this easy), proper testing should be carried out to ensure everything still works (both by running the tests via yarn run test and a hands on test using yarn run serve)

Note to Hacktoberfest participants: although this may seem like an easy issue, it could in fact be quite challenging depending on what the updates could break. Please, do not just run the update command and send a PR; ensure your changes do work.

Add favicon

You can add a favicon in this project to make it distinguishable when many tabs are open in the browser.
Please assign it to me #hacktoberfest