rocio01/to-do-list

To Do list

A simple HTML list of To Do tasks. This simple web page will be built using webpack and served by a webpack dev server.

Built With

• HTML5
• CSS3
• JavaScript
• Webpack
• Bootstrap

Live Demo

Live Demo Link

Getting Started

To get a local copy up and running follow these simple example steps.

Setup and Install

• Clone this repository using the link above (click on the 'code' button)
• Open a terminal and cd to the cloned repository
• run npm install
• runnpm run start to open a live server in your preferred browser

Test

• run npm test

Usage

• Add a task

Deployment

• Deployed on GitHub Pages

Author

👤 Rocio Martinez

• Github: @Rocio01
• Twitter: @rugiada8801
• Linkedin: zulma-rocio-martinez

🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check the issues page.

Show your support

Give a ⭐️ if you like this project!

Acknowledgments

• Microverse

📝 License

This project is MIT licensed.

to-do-list's Issues

Morning Session Peer Review

Morning review

Conditionals

I used negative conditionals.
` if (deleteIcon !== null) {
........}

if (clear !== null) {
.......}`

Morning Session Peer Review

Great project!

Code review coding partner

Great work Rocio! 👍

There are some things that could be improved:

To-Do-list/src/load.js

Line 15 in b139207

window.addEventListener('DOMContentLoaded', displayTodos(toDosArr));

Here, you could target the document instead of the whole window.

To-Do-list/src/load.js

Lines 41 to 47 in b139207

	spans.forEach((span) => {
	span.addEventListener('click', (e) => {
	const newSpan = document.createElement('span');
	const editForm = document.createElement('form');
	editForm.className = 'edit-form';
	const inputEdit = document.createElement('input');
	newSpan.appendChild(editForm);

Also here you could align all your variable declarations together on the top of the block.

Happy coding! 💯

Variables

I have some variables without a strong name
editForm.addEventListener('submit', function () { const newDescription = inputEdit.value; const p = this.parentElement.previousElementSibling.previousElementSibling; const indexC = p.previousElementSibling.previousElementSibling.id; const todo = toDosArr.find((x) => (x.index) === Math.floor(indexC)); ToDo.changeDescription(todo, newDescription); updateTodosLs(todo); });