rockefellerarchivecenter/argo

Formats API responses from ElasticSearch

argo's Issues

Separate out Elasticsearch document definitions to separate library

Create Term fixtures

Use JSON Generator: https://next.json-generator.com/4yGavXKPI

Update tests for Objects

Create Collection fixtures

JSON Generator https://next.json-generator.com/4JXfyktP8

Update fixtures

Floats should now be strings
Term URIs should be consistently named (either subject or term)
Use iterators rather than randoms for AS URIs

Add filtering and ordering to ViewSets

See https://github.com/wellcometrust/platform/tree/master/docs/rfcs/008-api_filtering

Add tests for filtering and ordering in ViewSets

Set non-required fields to `allow_null=True` in serializers

Create Serializers for Objects

add `required=True` to required fields

Prerequisite for #35

Add related Objects to Terms

Add docstrings to Elasticsearch Document definitions

Prerequisite for #35

Define ancestor structure

Update django-elasticsearch-dsl-drf to 0.20.1

barseghyanartur/django-elasticsearch-dsl-drf#154

See if this resolves issues with views.

Set up linting using pre_commit

Is your feature request related to a problem? Please describe.

Clean code is easier to maintain and debug.

Describe the solution you'd like

Add linting with pre_commit as we have done for other Django apps, and make sure it's baked into Travis.

Create `search/` endpoint

This endpoint should search all indices

Convert ID field to URI

Update schema and fixtures to account for type changes

Improve README

Is your feature request related to a problem? Please describe.

The README for this project is pretty minimal, and doesn't really communicate what this codebase is/does.

Describe the solution you'd like

Build out README to look more READMEs for our other apps.

Add issue template

Pagination styling

Implement facets

On main search endpoint.

Create ElasticSearch Documents for Terms

Add rights_statements to fixtures for Objects and Collections

Improve analyzers

Figure out what analyzers we need, build them out, and implement them in documents

Refactor get_objects method of DocumentViewSet

fail (ie raise) first rather than last, see if logic can be simplified.

Create ViewSets for Terms

Create Serializers for Terms

Create Serializers for Collections

Update fixtures to reflect new reference model

Prerequisite for #35

Define children structure

Create ViewSets for Collections

Move index and connection methods to helpers file or mixin

Consider in combination with RockefellerArchiveCenter/scorpio#36 - may be able to factor this out to a common package.

Update tests for Terms

Create ViewSets for Objects

Create ElasticSearch Documents for Collections

Create ElasticSearch Documents for Objects

Use rac_schemas library for validation

Is your feature request related to a problem? Please describe.

Tests use a submodule of the rac-data-model repository, but the pip installable rac_schemas library exists for this purpose now.

Describe the solution you'd like

• Implement validation using the rac_schemas library
• remove the rac-data-model git submodule

Add related Objects to Agents

Improve dates in fixtures

Currently, dates are all the date that the JSON was generated. Figure out a way to generate date ranges or single dates.

Add related Collections to Terms

Add related Collections to Agents

Make use of date and datetime fields consistent in Documents and Serializers

This may require looking at odin mappings from ArchivesSpace

Ensure relations are being created correctly

Ideally this could be added to unit tests.

Add OpenAPI schema

Update tests for Collections

Create Object fixtures

JSON Generator: https://next.json-generator.com/Vy2GIlKDI

Remove unused static files

Is your feature request related to a problem? Please describe.

In order to slim down build files, unused static files should be removed. This mostly includes extraneous Bootstrap CSS and JS files, but there might be some stray image files as well.

Improve response time for Collections

Is your feature request related to a problem? Please describe.

Collections take a long time to load. Preliminary investigation reveals a long time between get_queryset and page load, which indicates something in the serializers?

Describe the solution you'd like

Faster page load times for Collections!

Queries for stop words result in 0 hits

This causes tests to fail. Need a workaround.