rocketseat-education/gostack-template-reactjs-crud

💻 Projeto

gostack-template-reactjs-crud

📝 Licença

Esse projeto está sob a licença MIT. Veja o arquivo LICENSE para mais detalhes.

---

Feito com 💜 by Rocketseat

gostack-template-reactjs-crud's Issues

Warnings on test file

Variable debug is unused;

const { getByText, getByTestId, getByPlaceholderText, >debug< } = render(
      <Dashboard />,
    );

Some others variables referencing a property that doesn't exists on HTMLElement.

const inputImage = getByPlaceholderText('Cole o link aqui');
expect(inputImage.>value<).toBe('http://rocketseat.com.br');

Update availability test missing api check

The following code at Food/index.ts would make the test pass:

async function toggleAvailable(): Promise<void> {
  setIsAvailable(!isAvailable)
}

But if you reload the page, the state is not maintained because there isn't any api call to update food availability.

Doubt about use put/patch to update available status according obtained test results

At the begining of the bootcamp, Diego has been reinforce the difference between this two methods and its applications. For me, in this case PATCH makes much more sense than PUT because I'm changing only the "available" attribute of the food resource, not all the resource.

But if you try to use PATCH to toggle the available status, the tests will return error 404, otherwise if you goes to use PUT, everthing will be ok and the test will return success.

According Mozilla.org:
The HTTP PUT request method creates a new resource or replaces a representation of the target resource with the request payload. (https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PUT)

The HTTP PATCH request method applies partial modifications to a resource. https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PATCH

There is a reason to use PUT in this case?

Regards.