rokucommunity/roku-requests

Python requests inspired Brightscript Network Library for Roku

roku-requests's Issues

Enable setting the log level

The package is quite chatty, it would be great to be able to set the log level. Ideally, the roku-log package could be used so that one could set the desired log level.

crash if param value is invalid

                m._qs_array.push([param, key])```

crashses if one of the params is invalid. If I get time I'll submit a pr - flagging so there's somewhere to track this.

How can I handle the response status code 200?

How can I handle the async function?

Better handling of XML response

Request shouldn't try parsing obvious HTML/XML, e.g. anything starting with a < for instance, possibly also response starting with whitespace.

Some design considerations

I recently started using this library, and it's going great, loving lots of the built-in features!

But I'm also hitting some of the limitations that other libs of this kind don't face:

• The ability to "build" the request, but not send it yet
• Send the request in parallel with other requests

In short, sending a request today is doing everything in one shot: build a request, send, wait for a response.

This needs to potentially become 3 methods:

• Request() (get()/post()/etc)
• Send()
• Await()

This way, it becomes possible to send multiple requests, and control the flow of blocking the UI until a request is ready. (And by blocking the UI I don't mean blocking the UI thread, I know this lib does async behind the scenes)

roUrlTrasnfer problem creating MAIN|TASK-only component failed on RENDER thread: pkg:/source/Requests.brs(34

Hi have this problem when I call an API

Array in POST body

Please add support for array in POST request
Request.brs, line 54
if args.json <> invalid and (type(args.json) = "roAssociativeArray" or type(args.json) = "roArray")

CreateObject("roFileSystem") can fail

I saw a case where CreateObject("roFileSystem") can return invalid (crash report in iBicha/playlet#62)
Worth adding a null check on it

Fix test project

The test project currently uses rooibos, and has a few syntax errors. @georgejecook can you give this a quick look and get the tests working again?

Add option not to parse response as JSON

It would be great if parsing responses as JSON could be made optional. I am accessing an API that accepts JSON in request body but responds only with the string "ok". This results in errors such as ERROR: ParseJSON: Unknown identifier 'ok'.

Could there be an option for it? Alternatively, the parsing could be dependent on the response content-type.