Giter Site home page Giter Site logo

Comments (3)

jessewgibbs avatar jessewgibbs commented on June 13, 2024

@cog-qlik thanks for bringing this to our attention. We'll stick this into the backlog for future improvements in the SDK.

from rollbar-go.

rokob avatar rokob commented on June 13, 2024

Yeah this is doable, it will require a version bump as it will be a breaking change because the new behavior would result in nothing getting sent until someone calls the init. There already is a constructor if you don't want to use the default one. The overhead of a single goroutine is pretty minimal. Perhaps we should make close on the transport actually close the channel which will terminate the range loop and therefore exit the goroutine. We can then add Close to the top level which will close the std one. Auto opening it just to have it closed is a tiny bit wasteful but that would be backwards compatible.

from rollbar-go.

 avatar commented on June 13, 2024

Yes, I realized that implementing a different initialization mechanism implies a breaking change. Leaving the importer package the ability to decide whether to run goroutines in the back or not is preferrable IMHO.

@rokob adding a Close() function to stop that dangling goroutine if the std transport is not required at least gives a way to get rid of the problem and, at the same time, it's a backwords-compatible change. It could be a good compromise.

from rollbar-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.