romainnorberg/residue

Divide a float into several parts, with distribution of any remainder

residue's Issues

About edge case

Hi @romainnorberg,

Sorry for a so soon come back of myself to discuss about a new edge case :

Consider this test :

yield [
    100, // value
     5, // divide
     null, // decimal value
     45, // step
     [
         45,
         45,
         0,
         0,
         0,
     ], // expected result
     10, // remainder
];

Of course, it pass perfectly, but maybe it should not... nothing to distribute to 3, 4, and 5 part seems strange in a way...

What do you think ?

According to the set of equation, we can quickly determine if everyone will have something distributed.

The only check to do, it's to check if Divder is greater than Ns. If it is, we can throw an error...Of course, if we consider that this is the expected behaviour.

In the same way, this is a fully valid test :

yield [
    100, // value
     5, // divide
     null, // decimal value
     150, // step
     [
         0,
         0,
         0,
         0,
         0,
     ], // expected result
     100, // remainder
];

Talk about division and visibility

Hello Romain

I open this issue to discuss two points:

• Can a division really be negative? Is there any sense in doing Residue::create(100)->divideBy(-3)? I sincerely ask myself this question and have no idea in either direction.

• All methods are public, but I think that many of them don't make sense to be public.

Waiting for your feedback