rombert/ereviewboard

A mylyn-based Eclipse integration for Review Board

ereviewboard's Issues

Query dialog does not restore values

Instead, they are preset to the original values

Insure we are not using the old API in any place

Fix version number

This should be 1.0.0 all over, including in the feature descriptions.

Open changed files in compare editor

http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/file-diff/ indicates how we can obtain file diffs,either as patches or as very detailed diffs.

It remains to be seen how we can hook into the compare ui. One possibility is to start from the org.eclipse.compare.internal.core.patch.PatchReader and work our way towards using org.eclipse.compare.internal.patch.PatchCompareEditorInput . The obvious problem is that these are internal classes.

Map bugs_closed as a list of values

Spurious JSON parsing errors

Apparently the result is received partially . One suspect is incorrect synchronisation - perhaps multiple threads read from the same result. Another possibility is that the result is not completely read and the next reader gets bad data.

org.review_board.ereviewboard.core.exception.ReviewboardException: The server has responded with an invalid JSon object : A JSONObject text must begin with '{' at character 1
": "Bla Bla", "id": 861}, {"status": "submitted", "last_updated": "2011-07-28 13:42:07", "description": "Bla bla bla bla bla", "links": {"diffs"...
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.readReviewRequests(RestfulReviewboardReader.java:189)
at org.review_board.ereviewboard.core.client.RestfulReviewboardClient$7.doLoadInternal(RestfulReviewboardClient.java:268)
at org.review_board.ereviewboard.core.client.PagedLoader.doLoad(PagedLoader.java:64)
at org.review_board.ereviewboard.core.client.RestfulReviewboardClient.getReviewRequests(RestfulReviewboardClient.java:273)
at org.review_board.ereviewboard.core.ReviewboardRepositoryConnector.performQuery(ReviewboardRepositoryConnector.java:491)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQuery(SynchronizeQueriesJob.java:311)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQueries(SynchronizeQueriesJob.java:268)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.run(SynchronizeQueriesJob.java:201)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeRepositoriesJob.updateQueries(SynchronizeRepositoriesJob.java:186)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeRepositoriesJob.run(SynchronizeRepositoriesJob.java:142)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: org.review_board.ereviewboard.core.exception.ReviewboardException: The server has responded with an invalid JSon object : A JSONObject text must begin with '{' at character 1
": "Bla Bla", "id": 861}, {"status": "submitted", "last_updated": "2011-07-28 13:42:07", "description": "Bla bla bla bla bla", "links": {"diffs"...
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.checkedGetJSonRootObject(RestfulReviewboardReader.java:112)
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.readReviewRequests(RestfulReviewboardReader.java:178)
... 10 more
Caused by: org.json.JSONException: A JSONObject text must begin with '{' at character 1
at org.json.JSONTokener.syntaxError(JSONTokener.java:496)
at org.json.JSONObject.(JSONObject.java:180)
at org.json.JSONObject.(JSONObject.java:403)
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.checkedGetJSonRootObject(RestfulReviewboardReader.java:99)
... 11 more

Open in browser unavailable

The latest build does not have the 'Open in browser' editor icon. Neither is the menu item available.

Map review request replies as comments

http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/review-reply-list/

Display file comments in compare editor

Just check what Gerrit is doing and do the same.

Display non-file related comments for diffs

The diff has an optional message, and we should display that.

JSON conversion: check for stat/ok on every conversion

Remove tests feature

It's not used anywhere

Query with 'all' status does not return any results

Use real names in comments and for the submitter

Remove all external plugins from update site

We should instead refer to the Mylyn update site as an associate site, if needed.

Remove private page

We already have the private part.

Close review request and commit in one operation

Improvement: it should be possible to close a review request and commit in one operation.

One should also have the possibility to link review request and commit:

1. by automatically enter information about the review in the commit comment (which information to include and format to be defined by a template provided by user):

• review id
• reviewer
• url to review
  1. by adding commit identifier as a comment in review

Paged retrieval of users from repository

We are not setting max-results, which means that for repositories with >25 users we will not be retrieving all of them.

Map diffs as attachments

All diffs should be visible in the list, with all but the most recent one being marked as obsolete.

Create task editor page icon

Set the max-results parameter when querying

We need to:

• expose this in the query page;
• set it in the ReviewRequestQuery instances;
• make sure it is also used when retrieving the changed review request ids.

Move logic from RRClient.getTaskData to RRReader

Map dates to the local timezone

The WebAPI returns dates in UTC. We should convert to the local timezone.

Create review requests with Subclipse

The steps seem to be:

• create a new request, repository only ( http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/review-request-list/#POST )
• post a new diff http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/diff-list/#POST
• post a request draft for the newly created request http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/review-request-draft/#PUT ( public = true to publish it )

Repository connectors should have the 'review category'

In the teams view, repositories are listed under the unknown category.

Display non-file related comments for reviews

The top and bottom comment entries from reviews should be displayed as comment text.

Create an update site

On the gh-pages, upload the latest stable version.

Close -> Submitted does not apply in the task list

If I close an issue from the Web UI it is not reflected in the task list. If I perform a manual sync of the query that it is correctly marked as closed.

Make ship-it count an attribute

It's important enough to display visibly.

Create wiki page with description

Should describe what the current features of the connector are, and include screenshots.

Register on the Eclipse marketplace

Make sure that installation from the Marketplace client is functional with a fresh 'Eclipse for Java developers' installation.

Remove usage of Marshallable

Map screenshot comments as replies

http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/screenshot-comment-list/

Add 'close' actions

Map reviewers to the people part

We should map the people and the groups set for review.

Create archived update site for upload

Task list change notifications are shown twice

The current change detection is incorrect - a change is show twice and opening the task editor shows that the task has incoming changes, but it doesn't.

NPE when trying to create a new query

!ENTRY org.eclipse.mylyn.tasks.ui 4 0 2011-03-08 13:22:34.488
!MESSAGE 
!STACK 0
java.lang.NullPointerException
at org.eclipse.jface.wizard.WizardDialog.updateButtons(WizardDialog.java:1326)
at org.review_board.ereviewboard.ui.wizard.ReviewboardQueryPage$UpdateButtonsListener.handleEvent(ReviewboardQueryPage.java:557)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1282)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1263)
at org.eclipse.swt.widgets.Combo.select(Combo.java:1840)
at org.review_board.ereviewboard.ui.ReviewboardUiUtil.selectDefaultComboItem(ReviewboardUiUtil.java:62)
at org.review_board.ereviewboard.ui.wizard.ReviewboardQueryPage.createControl(ReviewboardQueryPage.java:402)
at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:170)
at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:734)
at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:606)
at org.eclipse.jface.window.Window.create(Window.java:431)
at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089)
at org.eclipse.mylyn.internal.tasks.ui.actions.NewQueryAction.run(NewQueryAction.java:97)
at org.eclipse.mylyn.internal.tasks.ui.actions.NewQueryAction.run(NewQueryAction.java:59)
at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3161)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
at org.eclipse.equinox.launcher.Main.main(Main.java:1384)

Map screenshots to attachments

"Did not find session cookie in response" when Validating Settins

During Repository setup, When I "Validate Settings" to my company's Review Board server, I get this error:
"Did not find session cookie in response"

Browser based access from the same client machine to the same server works fine.

What does that mean? How can I diagnose?

I mean, it's clear that this is where the error happens:

        // look for session cookie
        for (Cookie cookie : httpClient.getState().getCookies())
            if (cookie.getName().equals("rbsessionid"))
                foundSessionCookie = cookie.getValue();

        if ( foundSessionCookie == null )
            throw new ReviewboardException("Did not find session cookie in response");

but...why?

Possibly related: On some machines, (Firefox on Windows 7 in my office), I can't browse into ReviewBoard, because the server reports an error that my browser is not accepting cookies.
Chrome on the same machine can log in fine, though.

On the machine (Mac OS X 10.6,) where I am running Eclipse (Helios), though, logging in and out with Firefox works with no problems.

I have no Proxy set up, but I am connecting to the server via a VPN

Use review board icon for request editor page

Move TaskData-related operations from ReviewboardClient

They obviously do not belong in there, should in the the ReviewboardRepositoryConnector

Reviewboard Repository Settings: The server has responded with an invalid JSon object.

I added ereviewboard plugin to my Eclipse workspace. Installation went fine.
However, While adding Task Repository, I added server details. When we click "Validate Settings" command button, It tries to connect to the server and gives the following error:
"The server has responded with an invalid JSon object : A JSONObject text must begin with '{' at character 1"
"Next" button is never enabled.

I can login to my reviewboard account using my credentials from a web browser.

Please let me know, is this a bug or I am making some mistake in configuration.
Is there any workaround for this problem?

Thanks
Aakash

Map testing done field to be similar to the description field

Validate repository version

We should only allow access for 1.5 or higher servers.

Display affected files list for diffs

Investigate what Gerrit is doing and do the same.

Upload new diffs to existing reviews with Subclipse

1. Improve the wizard to accept posting to an existing review request. The final page will only accept a change description, rather than all the fields. The user can change other fields by using the task editor, if needed.
2. Create an extension point from the ui plugin for contributing actions.
3. Have the subclipse.ui plugin implement the extension point to contribute a 'Upload new diff' action.
4. The 'Upload new diff' action will need to map the review to an existing project and start the post review request wizard with the detected project and the selected review request.

Ensure that all calls are using paging

The new REST API has limits in place for retrieving almost every entity. We should make sure to use the paging calls, otherwise we will start missing data.

Paged retrieval of repositories from repository

Same deal as with user retrieval, but less likely to occur.

Change number is mapped to null

Rather, it should be mapped to ''.