several functions depend on agency_id, which is an optional field

[ropensci-archive]

several functions depend on agency_id, which is an optional field

[dantonnoriega]

Great catch. agency_name is required but not agency_id --- which is different for other ID vars (like stop_id).

I'll change it to be so that it depends on agency_name.

[dantonnoriega]

OK! The input is now agency_name values. I still need to input some checks but it should be working. Note that the default is agency = NULL for the map_gtfs_agency_routes which means the function assumes there is only one agency and takes the first observe agency_name by default.

Here is a gist for plotting CTA using the version I just pushed.

Let me know if it works and I'll close the issue.

[murcoil]

Still wasn't doing it for me--map_gtfs_agency_routes is choking on checking for a null value of agency_id rather than existence of the variable. I think I might have fixed it, if you take pull requests.

[murcoil]

I believe this is fixed by PR #9

[murcoil]

Thanks for catching names(), my mistake. Your new commit works for me.

With the is.null() test I was still getting an error when the agency_id variable did not exist. My understanding of is.null() is that is looks at whether the content of the variable is null, but it assumes the variable exists.

`> "route_id" %in% names(gtfs_obj$routes_df) #variable exists
[1] TRUE

"agency_id" %in% names(gtfs_obj$routes_df) #variable doesn't exist
[1] FALSE
is.null(gtfs_obj$routes_df$route_id)
[1] FALSE
is.null(gtfs_obj$routes_df$agency_id)
Error: Unknown column 'agency_id'
`