rs/net-server-mail

Extensible Perl implementation of the STMP protocol and its different evolutions (ie: ESMTP, LMTP)

net-server-mail's Issues

Incorrect behaviour on empty line

According to RFC5321 section 4.3.2 Command-Reply Sequences server should just reply with 500 for invalid command.

Current implementation reply with 500 and write perl error message.

Steps to reproduce issue:

1. Start service
2. Telnet to it

telnet localhost 2500
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.

220 Server.com ESMTP Service ready

500 Syntax error: unrecognized command

3. Read error from console:
   Use of uninitialized value $verb in uc at /home/getresponse/perl/lib/site_perl/5.28.0/Net/Server/Mail.pm line 564.

Test `lmtp.t` fails

When running the testing suite, the lmtp.t test fails for me. CPAN Testers shows an issue on Windows, but I'm running GNU/Linux here, so I'm not sure why it's failing. I'm investigating further and hope to update with what I learn.

1..11
ok 1 - use Net::Server::Mail::LMTP;
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
not ok 11
#   Failed test at t/lmtp.t line 52.
# Looks like you failed 1 test of 11.

"quit" broken

Bug was introduced in:

$line =~ s/^(.*\s)/uc($1)/ge;

Lowercased "quit" does not have any following params. Because of that \s does not match and command is not uppercased. Therefore it is not recognized as registered command:

< 220 Service ready
> quit 
< 500 Syntax error: unrecognized command