Giter Site home page Giter Site logo

multierror's People

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

multierror's Issues

A few notes

I was just talking with someone about multierrors when i stumbled across this. Glad to see you're using Glide. A few thoughts:

  1. What license is this project under? A LICENSE file and maybe a note in the glide.yaml license file would be helpful.

  2. The readme says the import is:

import "github.com/multierror"

I think this needs to be fixed.

  1. In formatting the error there's an optimization. Instead of:
var formattedError []string

You could use:

formattedError := make([]string, len(m. errs))

This way the backing array to the slice is the right size from the start.

And, one quick question... why didn't you expose the underlying individual errors the way others, like codegangsta/cli, do?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.