rsimmons / subadub Goto Github PK
View Code? Open in Web Editor NEWChrome+Firefox extension for studying foreign languages using Netflix subtitles
License: MIT License
Chrome+Firefox extension for studying foreign languages using Netflix subtitles
License: MIT License
First Thank you very much for this amazing tool i have been using it for a long time with no issues, i think Netflix updated something which led the tool to stop working anymore, i hope someone will be able to fix it.
Thanks
Thought it might be nice to place the UI in Netflix's subtitle menu like Netflix Subtitle Downloader does:
How to reproduce error:
When using the Add to Anki functionality of Yomichan on Netflix with this extension installed, the last word from the title of the current episode gets added to the beginning of the expression field on Anki.
How to reproduce:
When word is added to Anki, the episode's last word will be added to the beginning of the expression field.
Related issue on Yomichan's repo: FooSoft/yomichan#276
If you can display your subtitles along the top, then this could enable people to view 2 languages at once. For instance, English subs from the native Netflix player along the bottom, and subs from this extension along the top.
With chrome it works fine, but not for firefox, still cannot select any language from dropdown. Has anyone run into the same problem or just me?
The extension stopped working suddenly:
The UI is still displayed, but clicking the Show/Hide button doesn't display the subtitles, and the "Download SRT" button is greyed out.
Tried on episodes of shows that I watched before with Subadub subtitles on, so I know they have them.
Tried uninstalling/reinstalling the addon, restarting the browser, restarting the computer, tried on Chrome/Brave/Firefox, and it's still not working.
Any reason why that would happen? It was working just fine a couple of days ago.
Thanks!
If it’s not too much to ask could this extension be adapted to work on Hulu.com and Happyon.jp?
twoseven.xyz is a platform that enables users to watch videos together. Our extension allows embedding Netflix and sets up listeners to synchronize play/pause/seek/etc.
Recently, some of our users reached out to us and pointed out that this extension, subadub, does not work when they use Netflix on twoseven.
I was wondering whether you'd be open to allowing users to use it in this way. If it's acceptable with you, I can certainly make a PR for enabling this.
Thank you so much for your great add-on, in the right to left languages like Arabic and Hebrew Netflix uses in the WebVTT subtitles right to left mark (&rlm ;) and left to right mark (&lrm ;) to adjust the text direction (both are without space before ;), like these subtitles files
Vikings-S1_E1-Rites of Passage_ar.zip
and this makes the subtitles lines shown in the wrong direction in the subtitles.
To fix this problem you need to replace:
&rlm ; with ''
http://unicode.scarfboy.com/?s=%27%E2%80%AB%27
&lrm ; with ''
http://unicode.scarfboy.com/?s=%27%E2%80%AA%27
there are hidden control characters between '', i will appreciate if you do this replacement, thanks.
Describe the bug
When having the Subadub plugin together with the MAL-sync-plugin ( extension page, github ), the MAL interface does not appear, and the anime is not recognized by it.
When loading the console, an error appears:
Uncaught InternalError: too much recursion
isSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:431
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:438
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
findSubtitlesProperty https://www.netflix.com/watch/70303649?trackId=xxx:443
This error only appears when both extensions are running, disabling either one of them makes it disappear.
I have also reported this on the MAL-sync-repo: link.
Steps to reproduce the behavior:
Load both extensions, open Netflix on an anime that MAL-sync normally recognises.
Additional information:
This is a feature than Language Learning With Netflix has that I'm a big fan of, would definitely love to see it in Subadub as I prefer Firefox for my browsing. It allows easily "looking back" through subtitles without having to scrub the video if, for example, you don't pause in time or something along those lines and can also help give full context for fragments (with part of a sentence in one subtitle, then another in the next) that can often be found in subtitles.
It keeps switching back to English. It might be useful if we can set the default language ourselves. If the default language not found, then English is the fallback language.
In web browsers, Netflix displays some recommended subtitles, then a line and the rest of subtitles. Subadub has the recommended subtitles in its list. When changing in Netflix to subtitles below the line, Netflix gets Error Code NSES-UHX. Workaround: either use the other browser with subadub turned off to change the subtitles, or turn off subadub, change subtitles in Netflix, turn on subadub, refresh webpage. (Netflix Help says that "the video player or webpage does something Netflix didn't expect and then temporarily stops what it's doing".)
Just so you know, the filenames are still "broken" when downloading
Since episode name, season number and episode number get removed from the dom when no mouse movement is happening they are not included in the filename.
Therefore filenames are always <netflix_id>_<language_tag>.srt
Originally posted by @juligreen in #29 (comment)
It worked perfectly yesterday. Today I've noticed that netflix changed their design of the website. Does this have anything to do with my subadub not working?
edit: re-installing the addon didn't change anything.
Not sure if this is of any use to you in terms of code or inspiration but before Subadub came along I was using my own user script https://github.com/chriskempson/netflix-study-assist
Now I used Subadub plus this script as for me, Subadub is currently missing a few basic features and control options.
I'm trying to use Subadub to learn chinese but it seems to switch back to English on every new episode. It might be because the audio is set to English or because English is the default language.
This happens on Firefox on Linux. Is this a known issue?
It would be very useful if we could upload/drag an .srt file into netflix which then appears in the subadub menu. Many shows don't have subtitles in their original language, so it'd be great if we could select custom ones.
Not working on some videos such as
Subadub is not working after one episode. After reloading the page everything is working again.
Impetus for this request is a transliteration (e.g. Chinese characters -> Romanization) feature.
This could be generalized to any function of the subtitle text (say, if you wanted to capitalize everything, or run it through another translate service, etc)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.