rsksmart/bitcoinj-thin

Reduced version of BitcoinJ used in RskJ

bitcoinj-thin's Issues

toString method called by the debugger should not change the state of the BtcBlock object

The method toString is called by the debugger many times during a debug session, even if the debug window is not open.
The BtcBlock.java class implements the following code:

    public String toString() {
        StringBuilder s = new StringBuilder();
        s.append(" block: \n");
        s.append("   hash: ").append(getHashAsString()).append('\n');

But the method getHashAsString modifies the internal state:

    public String getHashAsString() {
        return getHash().toString();
    }
  @Override
    public Sha256Hash getHash() {
        if (hash == null)
            hash = calculateHash();
        return hash;
    }

Therefore the method getHashAsString / getHash methods should be replaced by:

    public String toString() {
        StringBuilder s = new StringBuilder();
        s.append(" block: \n");
        s.append("   hash: ").append(getHashAsStringDebug()).append('\n');

.....
    public String getHashAsStringDebug() {
        return getHash().toString();
    }
....
    public Sha256Hash getHashDebug() {
        Sha256Hash  localHash = calculateHash();
        return localHash;
    }

Watch Memory Pool Example

Hi
Do you have an example of how you can watch the memory pool ? I tried to use the bitcoinj but I couldn't extract the sender addresses (unspend outputs addresses) from the TransactionInput for each transaction.

For more security spongycastle -> bouncycastle

For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?

• https://www.bouncycastle.org/
• https://www.bouncycastle.org/releasenotes.html
• http://www.bouncycastle.org/latest_releases.html
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncy%20castle
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncycastle
• https://www.cvedetails.com/vulnerability-list/vendor_id-7637/Bouncycastle.html

When to open the main chain

Hello:
I very like this project （RKS）， When to open the main chain？

Segwit integration

It seems that upstream now has preliminary segwit support. I believe this will be required for proper decoding of segwit transactions sent to federation address.

The upstream branch is here:
https://github.com/bitcoinj/bitcoinj/tree/segwit