rsksmart/rwallet

The RSK Wallet is based on our rWallet open-source code-base, which will allow developers and organizations to use it to build their own apps.

rWallet

Open-source easy to use blockchain wallet

• 💰 rWallet currently supports: Bitcoin (BTC), smartBitcoin (RBTC), RIF Token (RIF), Dollar on Chain (DOC).
• 🔒 Provides 100% security — Neither RSK or any 3rd party can access your money or data.
• 🌐Available in 4 languages: Chinese, English, Spanish and Portuguese

Run for development

For further documentation, please refer to our wiki: https://github.com/rsksmart/rwallet/wiki

Branching model

• master has latest release. Do merge commits.
• develop has latest approved PR. Do squash & merge.
• Use branches pointing to develop to add new PRs.
• Do external PRs against latest commit in develop.

rwallet's Issues

Fastlane Slack url cannot be set in the repo

Slack has invalidated our Slack url configured in fastlane, although it's not important let's move that variable into .env too.

The fastlane configure file then needs to read from .env

Order of crypto amount and fiat amount are different across pages

In the main page, the amounts in fiat are shown bigger than the amount in crypto. When you select the asset and see the asset page, is the other way around. Is this intended ? I personally like that the amount in crypto is shown bigger than the amount in fiat.

Bottoms Sends/receive are not working and the My Assets square UX is confusing

• Bottoms Sends/receive are not working

• Below "My Assets" I see Send/Receive but it is not clear, which token I will send/receive. If I enter to a token the send/receive works.

The copy button of Recovery Phrase is not easy to click, all the copy buttons add button hot zone

For example, this copy button
In addition, the copy is too close to the above. What is the interval set on the design?

Create a wallet address using a password

"Reset passcode" is unclear during the first password setup

Reset passcode: I selected this option after launching the app for the first time, I guess what I was doing was setting a passcode for the first time, but it was nothing clear to me. I guess it shouldn’t say Reset Passcode if you don’t have it set.

2FA displays facial recognition when the device allows

Reference article
https://medium.com/p/707e7db17edc/responses/show

Send: it says “Mineer fee”. It’s wrongly written, and I don’t think everybody understands what Miner fees mean. I would use “Transaction fee”

Create Wallet page: confirm 12-word needs to show the number of the word

The number of wallets in a key not always shows the correct number

The number of wallets in a key not always shows the correct number when you make changes to the assets you manage in the key (I don't have the detailed steps to reproduce it but it kind of fails when you remove all assets and go to the Me section)

How many Fiat currency does Mello support?

Mello里面能显示几种法币？

RBTC logo: we are using a different one now, not the RSK classic logo.

White background visibility

There’s a white background that looks bad behind the green one. It appears when scrolling down.

Incorrect backup phrase message: there is a typo ‘corretly’.

Balance amount does not appear

Passcode appears all the time

I needed to put passcode 6 times per minute

There is no balance shown in Send page

When I go to send Test RBTC, it shows amount in ARS (not sure what that ARS amount is) and also it doesn’t show how much I have available to send, only if I click on “Send All”

HDWallet paths

The derivation path we should use for RSK HDWallets is described here https://github.com/rsksmart/RSKIPs/blob/master/IPs/RSKIP57.md

Term and conditions not working

@chrisli30 Term and conditions not working

Here some examples:

• https://brd.com/terms
• https://wallet.coinbase.com/terms-of-service
• https://www.bitstamp.net/bitgo_customer_terms/

Educational: https://legacy.mycrypto.com/

Tabbar text needs to switch language with App

Manual reload

It is useful to manually refresh balances, mostly when receiving money. This is not posible or I could not find the way to do it.

List of currencies doesn’t take into account the selected language.

Modify the clickable range of dashboard Send Receive and Swap

App config information needs to be retrieved from server on app start

1. coinswitch supported pair. Right now only BTC<-> RBTC and BTC<->DOC are supported and hard coded in the app

Parse query limits the number of result rows and cannot fetch all transactions

default limit: 100 rows

When you see the details of a transaction, it would help if you have the possibility to refresh without going back and forward.

Coinswitch Page: remove unused UI element

"Reset passcode" is unclear during the first password setup

testnet wallet is not working

I sent to my tesnet address rbtc using the faucet but it didn't displayed: https://explorer.testnet.rsk.co/address/0xf6e347537f5b2462e56f4374fdbe8ee9f3b79cd3.

Then I checked the seed of the wallet in MyCrypto and I realised that I couldn't get the address of my testnet rsk wallet.

Update Dashboard Token style

The name and symbol are not perfect now, please see the picture below for modification
Also, the two numbers on the right, the one above should be replaced with the number of tokens, which are displayed in thick and large, and the one below is displayed in the amount of fiat currency, which is displayed in small light-colored

The currencies in the “Add Asset” screen are ordered differently from wallet page

The currencies in the “Add Asset” screen are ordered differently from the screen when you set the wallet for the first time where Testnet and Mainnet currencies are separated. I personally prefer when they are separated.

When you select the option “Add Asset” it takes you to a screen with title “Add Tokens”. This should be unified.

List of currencies: not homogeneous use of casing. eg: Argentine Peso, Pound sterling.

sterling in Pound sterling is intentionally written in lower case by Google, but I guess not may people know that. We will capitalize the first letter.

Wrong checksum

The checksum address encoding is wrong, it is using the Ethereum encoding. RSK encoding spec here https://github.com/rsksmart/RSKIPs/blob/master/IPs/RSKIP60.md

Add Passphrase

I would a good idea to allow to add a passphrase to the seed. I don't know if this is possible for RSK network. It would be good to know the comments of @juli about this.

Select Asset page: It shouldn't let you have no assets selected.

It shouldn't let you have no assets selected. If it should, then other sections should consider this possibility.

Testnet FIAT values

Testnet balances have a USD value. I think this is misleading.

Strip out Android production certs and replace it with a public one

Test fastlane for both iOS and Android

Make sure both iOS and Android

1. can build
2. can commit with the version number corrected
3. can upload the build to test flight

Setting name: if max is 32 characters, why don’t you limit it instead of showing an error message?

rWallet vs MyCrypto RBTC address checksum

1. coinswitch supported pair. Right now only BTC<-> RBTC and BTC<->DOC are supported and hard coded in the app
   
   

The first address should come out from the testnet

Backup Pharse: Cancel swipping page

Passcode: Reset, Cancel and Delete Spanish words go out of box

"Me" section, when you have only 1 Wallet for a Key it says "1 Wallets" instead of "1 Wallet"

"Add Tokens" screen doesn't change title or "Add custom tokens" label when you change language

Add Wallet: non homogeneous use of casing. eg: Create Basic Wallet, Import existing Wallet

I would give it a better default name for Key 0

I would give it a better default name for Key 0 and give users the possibility of renaming it from there (the main page) or at least be able to go to the edit page from there.

Uniswap feature for RBTC and RIF swap

Coming feature:
In order to achieve token swap between RBTC, RIF or any other ERC20 tokens on Rootstock blockchain, in the next version we will add Uniswap function. We will be using the same UI as Swap, but the backend call will be different since we are interacting with another third-party service

Documentation
https://docs.uniswap.io/frontend-integration/connect-to-uniswap

Back button: you need to click on the arrow but it doesn’t work if you click on the words, only the arrow, that's annoying.

If the clickable area is small, it cannot be clicked. It must contain the entire arrow and text.

Add the Terms of Use link on the Settings page